From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37E0525B098 for ; Fri, 5 Jun 2026 08:34:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780648456; cv=none; b=B2C9T3ZfVyJHo+Bj63Ie0k4AhBEBOaAEr/wnL5zpDeimygzqp792P7eDijWKQE+rnthcLEUhXBbWmniWRcG7TfPiCiIyhgxa6lVkzDrDch9N44bmS7Pf88n1UCOe+V72oyQt6cXgVBLRahsP1oRvkAFA+FLlRTNAGky4Ac2XwrU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780648456; c=relaxed/simple; bh=hwk5Ufni6f0ui1uhxQ4qvdCW2d+UAuDzM4ftpmHZpMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MhCPKniXPi5EBOg94rBA/3Mkx/PtUa08lq0AsCOBMt40P/PdbedAg6N+PRpSspI6KwbQVjBX1wk/f5lqQkdjItdaS9ufSkdgs4SYcLm5ycjl+zvQfFaJJ0KWiaX8hjjLP9qw7Kdtd8RTTP8m3/NpM9AWr4n65EghIkpfZX+5hE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu; spf=none smtp.mailfrom=monstr.eu; dkim=pass (2048-bit key) header.d=monstr-eu.20251104.gappssmtp.com header.i=@monstr-eu.20251104.gappssmtp.com header.b=0k1sWk8W; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=monstr.eu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=monstr-eu.20251104.gappssmtp.com header.i=@monstr-eu.20251104.gappssmtp.com header.b="0k1sWk8W" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-68d23396ed3so2925298a12.1 for ; Fri, 05 Jun 2026 01:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20251104.gappssmtp.com; s=20251104; t=1780648451; x=1781253251; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gg+NzF08qy8SSomOhLMa0xQuogjTZBZj8sDtWKiB0Yo=; b=0k1sWk8W5372xjICuHReKvZrwDsn/GmUFw83WOmQOhMytG5ENAPk1YpKdar5J6eGtc ZNdx0puF0C5M2HmKu+noyVMPWRyMnXhs9QbQ82yf6FDOnOMXbf2ZVyXaabyB+wvZzseQ klEKxe9GMh/f3YrpBf7YCv2rN/w1qM2EBuA+MxA41MC+aJKGViWVyY2nH4MDuS3DIiQU aBxjUBwgNFQL16YdqkJUy7DEMs94rZXmMgHLP6hgtwf+iVHr9O2AF+G2JkdGlz8jadDt QiKxTN0WHq8Zt7KjtUsjASCBg6Y/tNPGc0C+LKac442A3Yn9LOw1fOLimKE5hsuEh0PD dgFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780648451; x=1781253251; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gg+NzF08qy8SSomOhLMa0xQuogjTZBZj8sDtWKiB0Yo=; b=hEX4QcoJUr3R/DRMMDMyyIK10mW4Q6IODE/adIi5XQX0Sff9SVcFbHRrUPdrnLtDIZ cH5Iu8pZnlG/DQTBYaUHPldnsUxdwi47ODeI8S2okTEhA6rXqeiYNV3yrfZ/lrw7+weY xU5jO5DWB3kCfRqHJB9chLGkTCyQu7pp7Ih7yVwPlRd3bAzRLjINANVTxu4j371GS5Kn YM+WLTt2OlX47WM+yXdIuVH9uflEm/2LzXO4qpW2Q0urd6AcI9AyLP0TLMn9RBprI1a1 2u6ixsCfAY0frc1KOvw8na4C3U9+diCMVJEjeF76P2fY6t0g3p6/ikeS5zmPLo1ORiLp O2dg== X-Gm-Message-State: AOJu0YzdGcXgx3zeWzzYRffqbR9EkVBKLTCDU2mIFSary/oudqUb5H8t EZ7rolYTPC4yJnrtixAB/QMnENp7WOrw5BgR+6gdWvwe2PxckwF38l/wMORVCZ3+pRSr50MJWmJ Ibwsnwg== X-Gm-Gg: Acq92OEkRtn8pruVzMhxRJ3h1G3wLado8NsIZ5EkdFPI1KyxHhACT6KQMsXlI7HRsOZ u4oYYBgqooPyd/YkwfQswba3PzPpCVxM07TRyNKAmRCDIixoh+PxWXKHd700+daSNkyDYqd1FxQ fHPcLALGxXEWGiLPOXFlGOa3eKdDOgAsTd1FJQJupmdROubhhIpl7kJjqwA8EAW3/GTN5h+kfsw ASx+VYGj04kbQ4Z/hsY3w1oC1mbstjXndgzStctARi4T5T7+LZ/X0xlr3DtUsH06BaGxcXHZnvW tem6edl0fKADqdlwQUzn3JhVBE2ViC69nXv51cab4DIQr3VLdSh8u/YT+KnSgZG5r5rw1p8YM4b ve/MrO2T/L3F7M3CcjjZ3AOeBPRhNY7obtxQuW2ku266qDJLqpcyuLBy7+w0h6Qz2OIJ+mY+4tA RzqmupeAAgPD0BtsdrDbNWyOWfax2QexU3eacRLQLLaPR+au8hxM5ZQBTg0Wc+8gt/dgU= X-Received: by 2002:a05:6402:2345:b0:68c:7812:745a with SMTP id 4fb4d7f45d1cf-68fa504a485mr1432494a12.18.1780648451111; Fri, 05 Jun 2026 01:34:11 -0700 (PDT) Received: from [10.254.183.223] ([149.199.62.131]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64c2f34asm3568755a12.4.2026.06.05.01.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2026 01:34:10 -0700 (PDT) Message-ID: <45528e81-254d-4f07-bfbe-aeb3d49f40a9@monstr.eu> Date: Fri, 5 Jun 2026 10:34:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/2] microblaze: fix signal-frame handling for NPTL To: Ramin Moussavi Cc: linux-kernel@vger.kernel.org References: Content-Language: en-US From: Michal Simek In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/5/26 10:20, Ramin Moussavi wrote: > Two independent fixes to the microblaze signal-delivery path, both found > while bringing the uClibc-ng NPTL test suite up on microblazeel under > qemu-system (petalogix-s3adsp1800). > > Patch 1 wires up sigaltstack(), which is currently routed to > sys_ni_syscall even though the signal code fully supports an alternate > stack - microblaze is the only architecture leaving it unimplemented. > > Patch 2 reserves the ABI argument-home area at the top of the signal > frame. The MicroBlaze calling convention reserves [r1+0] for the return > address and lets a handler store its incoming register arguments r5..r10 > into [r1+4]..[r1+24]; since r1 points at struct rt_sigframe on entry, > those stores land in siginfo/ucontext and corrupt the signal state. A > seven-word leading gap moves them into scratch space. > > Both were tested with the uClibc-ng NPTL tests; the affected tests > (tst-cancel20/21, tst-cancelx20/21, tst-signal6, tst-timer4/5, > tst-mqueue5) pass. checkpatch --strict is clean and both apply to > current linux-next. > > Changes since v1 [1]: > - Patch 2: shrink the gap from eight to seven words. Michal pointed > out that the home area is exactly seven words (r15 at r1+0, r5..r10 > at r1+4..r1+24); the eighth word was never written by the ABI. > Retested on qemu - tst-timer4/5, tst-mqueue5, tst-signal6 still pass. > - Patch 2: fix the offset range in the commit message and the in-code > comment ([r1+4]..[r1+24], not [r1+28]). > - Patch 1: unchanged. > > [1] https://lore.kernel.org/all/cover.1780587199.git.lordrasmus@gmail.com/ > > Ramin Moussavi (2): > microblaze: wire up sigaltstack > microblaze: reserve the ABI argument-home area in the signal frame > > arch/microblaze/kernel/signal.c | 8 ++++++++ > arch/microblaze/kernel/syscalls/syscall.tbl | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > 2 issues here. 1. Do not send it as reply to v1 but separately. 2. Author of patch is not matching SOB in the email You are sending it from Ramin Moussavi and SOB has Ramin Moussavi Please fix it and send v3 Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP/Versal ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal/Versal NET SoCs TF-A maintainer - Xilinx ZynqMP/Versal/Versal NET SoCs