From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932339AbdJWNvV (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Oct 2017 09:51:21 -0400
Received: from mout.web.de ([212.227.15.4]:63724 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932191AbdJWNvT (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Oct 2017 09:51:19 -0400
Subject: Re: [PATCH] tpm_tis_core: Use common error handling code in
 tpm_tis_send_data()
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        linux-integrity@vger.kernel.org
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        =?UTF-8?Q?Peter_H=c3=bcwe?= <PeterHuewe@gmx.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <fb0a6fbb-db2f-ce3f-f1c2-02f934accc4e@users.sourceforge.net>
 <20171023134202.d6td6vvhd7pfv5ue@linux.intel.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <455e93f6-c419-8318-6129-80e99fc8552f@users.sourceforge.net>
Date: Mon, 23 Oct 2017 15:51:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171023134202.d6td6vvhd7pfv5ue@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:owWoWl1m6w9N3iATdL44NroHQ8juTbA3k7hNPzGJKSI7NTbbeIs
 blpkXmgb8gwO49ZWOleR6VxPu6+ZvhEN7v8z9COqv5a0MipSni9vJ+3WbtD7/D41qrHI47e
 jvGZXGDOAziMDvLdMmgHD/l910eDqAuLApEUk/D4LxVNU/kJeqZ7geJt5qDb15xZrV5vpuM
 givIeBFmZJC95bX17igdA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:wnudYZ0tZI8=:ZPyUfq3MC4JYbb2hnfTJMD
 9oq/nE6cowSWjyAsaWxeXYK54RFTtyiCP/aGrEYsNg5SaZALUAGEjmki5WcwZ1vm9fuR3uCqo
 fsKHBNw24NT77bkv0raNcv7PAKTAlEV3P+/2mh2MX9DAQut7e2ZeA9cNcnJ1kizrF0+zPzgOe
 JFQ7BNTgjbz8S8DcwMDFXM5TDanpy8OpHF2Zw48upO00c6cQgEHeLkwMOyvGGxGUIzuJAto7e
 X40bPw8bw748vhXOjTfY6kPp9DNfVC5nrvywSQRSdKzxql07Jkjds6B3DbHWS8xaz9iri4QJF
 drjlPll7PsA9k7U9NpvFk8VGQBZheX5seOpvZV2herygmqmqYkoQdwjlYdDxj0xxj3S9gXxOh
 rwSrLkRFuKYqX7H2Gq4fqboHOH2uC15YZBjIBkZCZAE1gehHe4fFIoyg3bUWa/Hs5iQ8PA202
 bjh/cPi78VYLDZ5R7iu2odKdwtKBmmJL1nPfKvxTWW5S+1sBDDPbRBEh4lvE9Qa9u3qdP1PRe
 XkNM+AhqNsmlqNBISvHbadnhvinb4yYFpe6L+Pu7UJYcqYeBdwzUfG7t+DwA6BHylA7zQs587
 EtL9SIIer5IEjJYJojU14dS4p6aUQwkzImIJr2NWYmGJmBd+LIbGxWqZrJwI5scTloqyaeEAl
 GZXBZbQMT+YI2E9AdWwORckqDcXUKS7qRFWzuvEIBEcDgUcX73KJX/u7/8bSDUvWEK2iEeKH0
 mArDPbPJzHmQLUjeVOTiN4t6J2idGJoGRc+ekVN3gJPjFJv/9RJUoyoafaZh5LprOzw0oKF5z
 GH2qmwurOlQk3pgCJz2W94EeaXjYGCmwCKLoFukYK/yBqcIJOo=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -315,6 +311,8 @@ static int tpm_tis_send_data(struct tpm_chip *chip, const u8 *buf, size_t len)
>>  
>>  	return 0;
>>  
>> +report_timeout:
>> +	rc = -ETIME;
>>  out_err:
>>  	tpm_tis_ready(chip);
>>  	return rc;
>> -- 
>> 2.14.2
>>
> 
> NAK. wait_for_tpm_stat() should give that error code.

This is a pity that you reject another bit of code reduction.

Regards,
Markus