From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
briannorris@chromium.org
Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] mwifiex: clean up some inconsistent indenting
Date: Sat, 11 Nov 2023 01:57:53 +0100 [thread overview]
Message-ID: <455eae9e8a583d1ea5b8a3c59e134b85538fff39.camel@sipsolutions.net> (raw)
In-Reply-To: <76eeb452-dd61-44ce-ae9c-a8f8afa83fb8@quicinc.com>
On Fri, 2023-11-10 at 16:38 -0800, Jeff Johnson wrote:
> > drivers/net/wireless/marvell/mwifiex/sta_event.c:789 mwifiex_process_sta_event() warn: inconsistent indenting.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > if (!adapter->pps_uapsd_mode &&
> > (priv->port_open ||
> > - (priv->bss_mode == NL80211_IFTYPE_ADHOC)) &&
> > + (priv->bss_mode == NL80211_IFTYPE_ADHOC)) &&
>
> this change looks incorrect to me
> this condition is *inside* the parenthesis from the beginning of the
> previous line, and hence this should align after that parenthesis, not
> with that parenthesis, which is what the existing code is doing
Hah, you're right, I completely missed that! I guess someone should fix
their tools :)
johannes
prev parent reply other threads:[~2023-11-11 0:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 8:33 Jiapeng Chong
2023-11-10 21:39 ` Johannes Berg
2023-11-11 0:38 ` Jeff Johnson
2023-11-11 0:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455eae9e8a583d1ea5b8a3c59e134b85538fff39.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=abaci@linux.alibaba.com \
--cc=briannorris@chromium.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®