From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF031E5B95 for ; Mon, 19 Jan 2026 01:34:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768786468; cv=none; b=oOwCb5CusgoShRlRmNE9qzo4uhgGaFARb2NuKiB8o+m4dI9SQ58QP8a9mu5r1VDHp+8KIHDC0mHamiD3bwgFtUG+jPLAJgdz2TNUSEIo41wBomSv8ElsuSPRih8NsjLJNNh20lhEJK15S4L7x6PABUjGux3nvxrsad2xokpwKUA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768786468; c=relaxed/simple; bh=N5uHfs6ZcdF+4EryWWhcGuHg+C+sHxM9bRx58GDOBw4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=inc5eS3RjbmCkayg5LJCUZzMWOcrAIvsVUXnDOaKQ8z1xcyQRwc2ynkLY5TExKvlFdPpNmxxj0nsq2LNKquJ9Sb7LHE04wH9er8LuDyKmunotcHGMwZg5piwG3SEc9E56cet0zEZxl4/0BMtN3BbDodtea5/E5IqRDP8DSJ+Erg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=myYNhLUS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TXJGqus7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="myYNhLUS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TXJGqus7" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60IMjetD3328758 for ; Mon, 19 Jan 2026 01:34:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hOvdQBWjYZXhCIlZ66x3GrM29+gZ2gMcRylv0MRQCG8=; b=myYNhLUSWKWQV6iq XUr3MoXG3IAjYcV666prFefSHXzxLoxVClBTwY9osmYFrba6o2pjD/4qytYKH7qT UKeNMl0bjCT+OhVgx20eS0dauXbx1rReNJf6lVLXqkJofovAe1x5jYqZvde+dEtq ufeLvGWCyCPsWpuWUikbU/WQ1dc7UYuj7gg0bjt2VXhqUuRxfRZRHurdsjghKnGN j3qKa9Hc5mPa7H/x+rYBvifzQjQjWayC2kaRzJ3g37mJ956cXn6diL8Cgh8w0Iub JHsRPr4hkLJT6O6z6dvkYNRV2VL+XF+h2EELno3m0QNSM/opLNsALo4G77q02z2G J4txag== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bs788093m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 19 Jan 2026 01:34:25 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81ea3358dd3so3099053b3a.3 for ; Sun, 18 Jan 2026 17:34:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768786464; x=1769391264; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hOvdQBWjYZXhCIlZ66x3GrM29+gZ2gMcRylv0MRQCG8=; b=TXJGqus7UOX5lF4D9Bmwuv63TGkMFBvC6CZgjegh7hNz8hoHkAWdKpuGRMePe/bIcZ 21H6Dq6Rs4UW9d7qbCqwnBOXsJzpb8ErEHHFz4YBaXJU6fSOKFF8AaLPqOoOeUJ2W+sp nk5a0iWZIDxGKBDOYmGJF5otKavVBtzqoPF/+2jT6A6PWKhYof9UezSbYRWJ3PeldQrx /Kp2b78EmDdnrXYZPqJMs9BvceA+LXaaZRJreAMfVH59Q0AphGC3MX8Cv5M7fA3pGW3Y zytGYwjfCVY3DQmnrYW79hcU/7C0dGNHMDBrmUxRldwnGhMoz3nbNrHV5goTrCtg7Rvm 8/6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768786464; x=1769391264; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hOvdQBWjYZXhCIlZ66x3GrM29+gZ2gMcRylv0MRQCG8=; b=VAeVYfGmTw0rBJ5wqnHkKGDfT38bh9mIJ6xVCZ7hGJCKVVlSWnHLdWFwGh4bQnv/aD U1nu4fQjzN68aMzS3DmEbCmkwfaVjP161j8ajXr6GYwDUVA0KzPJwRDcjM8xlELC9Cnu mmnjZ9ZKn4j1pWB32zJERTn+QMrmzcQmogWX8moTKytNrCUr2R6gJ5TLtIA4nloWc2hI WXTr7xOIIMzuBEnQBDwMGMLIsXcoyh5G6qViGqxInLXRsg6h3Fq6OaccXpBgnsFXwni0 ZgpEwUenDthY+BMEvRMRsT5J5rItfZ/gP4A3Au1zC7iM/PUpdxz0vqj3s4B3p58OkqyW jW3A== X-Forwarded-Encrypted: i=1; AJvYcCXhxNA/9sOzDiNhV0SN+wQXRxT0t8NqYDNIHjY4wGpcU5GLsMt5u+q2YYowC3yE004fSdUbbBVBmoZcEpc=@vger.kernel.org X-Gm-Message-State: AOJu0YxEngUCn1q3b2LxrnS9xWRTKRMT9x8GseD86txZJn2q5x/tp8h4 64XlTt+nNhp/5405195RZk5dUE1UBFxj/oA9fR185drgsDSuUOziHGxwWnXFwzlizg758Pkri/8 xnTlGCEjJ3zVj3u/LrGqPNnCSS2moLEsbawHNaFeyJhI3FO2EvIMIlL0dP8Q0q1NcMTQ= X-Gm-Gg: AY/fxX515T1X/gQqgjf81e+zdXlamd0IakqcLIlHC6hrMvZRoZBOQvT8eK1eKjjG6h1 28GHKd0Xaqc3sqrKBuWhLcIFX+071uO89yzVj7ESPLheqkfJqzE0xTbkyeDqqh/MTma7vHfy9wZ MJfk3+pcreZkMn4KNzGooAkUQtCA7U7A4OlXU3oJWOv0ekWG1JbYtbRc9KI6BO59JX2iNUa4fEn Fi85pQlVldjzbO2fdMsJaNsosCvOXk46bhGMiMHFDQaAe7X6L4tZh2s8jSHY3rAPqaJHe4memmP aGp5iGnsj54cL4vfWl1fmF/5UchE7IThjzVC/NTwYUfUmp78dJ50l/s4CG3+8QzYZTu5ZxptvUA Y/JmTPlOa2Ijp4PYdlIMsw76canod5CpovaVvfQnp+s8i6RaZdl0lKNYfe6nfKbni5JrlXBKIsO aDcs+x X-Received: by 2002:a05:6a00:1407:b0:81e:81fb:b391 with SMTP id d2e1a72fcca58-81fa181fee4mr8040802b3a.45.1768786464104; Sun, 18 Jan 2026 17:34:24 -0800 (PST) X-Received: by 2002:a05:6a00:1407:b0:81e:81fb:b391 with SMTP id d2e1a72fcca58-81fa181fee4mr8040784b3a.45.1768786463569; Sun, 18 Jan 2026 17:34:23 -0800 (PST) Received: from [10.133.33.36] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa1277a15sm7499351b3a.42.2026.01.18.17.34.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jan 2026 17:34:23 -0800 (PST) Message-ID: <4562bdbc-9811-4f73-bc4b-f5a62ba1c965@oss.qualcomm.com> Date: Mon, 19 Jan 2026 09:34:17 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 ath-current 2/2] dt-bindings: net: wireless: ath11k-pci: remove obsolete firmware-name property To: Krzysztof Kozlowski , jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251214025230.716387-1-miaoqing.pan@oss.qualcomm.com> <20251214025230.716387-3-miaoqing.pan@oss.qualcomm.com> Content-Language: en-US From: Miaoqing Pan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=KLVXzVFo c=1 sm=1 tr=0 ts=696d8a21 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=a9Ey2deuWmHcFssUcOUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE5MDAxMSBTYWx0ZWRfX02Pu7T9KruVC W/7q+AZgXX+ELrmwhGtIMo+5qnzB3UCBzp/k+FgIoompiXuLTxluretY7ojEcIpkpUQGnej4WRz BMYrSM6KHsHEnYmYa2+ETZdRJF9GIC5IGNc4M/wl+u8TtLKOmdxkc1cYk+LPHiyXAlKRf4BPBa6 R6pqWPXw6bIDF7ZHXzUlRGHi5/nBD6fSSH+6Hvez6awD/UN/bgm+Ongvw6klwUZturD00NZpyQw GTmBht0zgsVB9eb5dB2lZKsILuZ81uVG2IJthDrJN0ofCGsNgG8+VDqw37p1precx/35LRxMPQ+ HYJGnpQnNoptUsQWaln0QeMIahxkw+6aCrpP+VeXWkQ1BJRzLR0AFszKezKQl5PENt0pViBt7LL YkU/8IlCx6B6FbGcUApO2TrorCP8O6ttq7I6e0P05ILbbf8XMgHjtXrGhq/HwN3SzQvaEC7+a4r yGDma/D9/+lWeEDs/FQ== X-Proofpoint-GUID: NZ3VKyTvQZy5Rgwxo5vOpEnfqJtLcBkG X-Proofpoint-ORIG-GUID: NZ3VKyTvQZy5Rgwxo5vOpEnfqJtLcBkG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-17_03,2026-01-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 impostorscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601190011 On 1/13/2026 3:28 PM, Krzysztof Kozlowski wrote: > On 14/12/2025 03:52, Miaoqing Pan wrote: >> The firmware-name property was introduced to allow end-users and >> integrators to select usecase specific firmware for the WCN6855. >> However, specifying firmware for an M.2 WLAN module in the Device >> Tree is not appropriate. Instead, this functionality will be handled >> within the ath11k driver. >> >> The driver has removed all support for firmware-name, and no upstream >> Device Tree files reference this property. Therefore, this patch >> removes the property from the binding and marks it as obsolete. > > No, it does not mark it obsolete. Point me to the place. > >> >> This is a DT ABI-breaking change, but safe since there are no in-tree >> users. > > It's not safe. What about my board using this WiFi? Or Mr. foo's board? > > Still NAK, you did not improve it. > > I think it’s necessary to clarify the background here. As you can see from the git log, all changes related to ath11k firmware-name were submitted by me, and the intention was to allow the lemans-evk, monaco-evk, and hamoa-iot-evk boards to specify dedicated firmware for the WCN6855 Wi-Fi chip. However, the Wi-Fi‑related DTS nodes for these boards have never been submitted upstream, because adding a firmware-name property for an M.2 device is not appropriate and would be difficult for the community to accept. Therefore, the original approach was abandoned. The alternative solution is to propose a static lookup table that maps device compatibles to firmware names. As a result, we have not submitted any DTS patches adding firmware-name for those boards to date. This is why I believe that removing firmware-name from the bindings is safe. If this explanation is still not sufficient, please let me know what additional steps are required for accepting these two patches. Thank you. >> >> Acked-by: Rob Herring (Arm) > > And that's a fake tag. > > Rob never acked such patch! Adding tags for something completely > different is not acceptable. > > > Nacked-by: Krzysztof Kozlowski > >> Signed-off-by: Miaoqing Pan >> --- >> .../devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> index e34d42a30192..653b319fee88 100644 >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml >> @@ -35,12 +35,6 @@ properties: >> string to uniquely identify variant of the calibration data for designs >> with colliding bus and device ids >> >> - firmware-name: >> - maxItems: 1 >> - description: >> - If present, a board or platform specific string used to lookup >> - usecase-specific firmware files for the device. >> - >> vddrfacmn-supply: >> description: VDD_RFA_CMN supply regulator handle >> > > > Best regards, > Krzysztof