From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Yan Burman <burman.yan@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
wli@holomorphy.com, sparclinux@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc6] sparc: replace kmalloc+memset with kzalloc
Date: Fri, 24 Nov 2006 20:13:23 +0100 [thread overview]
Message-ID: <45674453.9040108@s5r6.in-berlin.de> (raw)
In-Reply-To: <456741DD.6060103@gmail.com>
Yan Burman wrote:
> Stefan Richter wrote:
>> ...in this ^, the old code and your update don't check for NULL return.
>
> Both of this parts are done at early stages, so it is probably:
> a) Impossible to recover from failure
> b) If you run out of memory at this stage, you are probably in very big
> trouble anyway
>
> I could modify it to check and panic if the check fails.
> Would that be better?
I hope the domain experts answer this. (I have no recommendation but
wanted to point out a potential, although unlikely, cause for trouble.)
--
Stefan Richter
-=====-=-==- =-== ==---
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-11-24 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-24 12:01 Yan Burman
2006-11-24 17:33 ` Stefan Richter
2006-11-24 19:02 ` Yan Burman
2006-11-24 19:13 ` Stefan Richter [this message]
2006-11-24 21:52 ` David Miller
2006-12-01 1:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45674453.9040108@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=burman.yan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®