mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Robert Crocombe <rcrocomb@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux1394-devel <linux1394-devel@lists.sourceforge.net>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: ieee1394: host adapter disappears on 1394 bus reset
Date: Mon, 27 Nov 2006 19:26:24 +0100	[thread overview]
Message-ID: <456B2DD0.4060500@s5r6.in-berlin.de> (raw)
In-Reply-To: <e6babb600611270946o738327feqd7a18f2f1ff8fccd@mail.gmail.com>

Robert Crocombe wrote:
> Okay, so the code looks like this now:
> 
>                         DBGMSG("PhyReqFilter=%08x%08x",
>                                reg_read(ohci,OHCI1394_PhyReqFilterHiSet),
>                                reg_read(ohci,OHCI1394_PhyReqFilterLoSet));
> 
>                         reg_read(ohci, OHCI1394_IntMaskSet);
> 
>                         hpsb_selfid_complete(host, phyid, isroot);
> 
>                         DBGMSG( "IntEventClear %08x "
>                                 "IntEventSet %08x "
>                                 "IntMaskSet %08x",
>                                 reg_read(ohci, OHCI1394_IntEventClear),
>                                 reg_read(ohci, OHCI1394_IntEventSet),
>                                 reg_read(ohci, OHCI1394_IntMaskSet));

OK.

> this is in 2.6.16-rt29 which has proved to be the easiest to provoke.
> I actually couldn't get 2.6.18 to break earlier this morning (few
> hundred resets).

You could replace 2.6.16-rt29/drivers/ieee1394/ by drivers/ieee1394/
from 2.6.16.28 or later plus one of the patches from
http://me.in-berlin.de/~s5r6/linux1394/updates/2.6.16.x/ and see if it
makes a difference. But judging from the changes that went in, I would
be surprised if there was any improvement.

> Okay, I've lost host1 (on the Indigita), but this time the last print
> statement is:
> 
> Nov 27 10:38:27 spanky kernel: ohci1394: fw-host1: IntEventClear
> 00000000 IntEventSet 04588000 IntMaskSet 818300f3
> 
> just like all the other hosts.  I can confirm that no bus reset
> handlers are called, and there are another 4,000 lines of statements
> from the other hosts after the last from host1.

This is strange. The mask has bus reset and self ID received events
switched on. There is nothing manipulating this mask besides the
interrupt handler and the initialization and shutdown routines. And if
I'm not mistaken, the interrupt handler does not run concurrently to
itself for the same chip.

Ingo et al, is the -rt patched kernel fundamentally different WRT
reentrance of interrupt handlers?
-- 
Stefan Richter
-=====-=-==- =-== ==-==
http://arcgraph.de/sr/

  reply	other threads:[~2006-11-27 18:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-22 15:31 Robert Crocombe
2006-11-22 21:44 ` Stefan Richter
2006-11-23  0:28   ` Robert Crocombe
2006-11-27 15:39     ` Robert Crocombe
2006-11-27 17:11       ` Stefan Richter
2006-11-27 17:46         ` Robert Crocombe
2006-11-27 18:26           ` Stefan Richter [this message]
2006-11-27 20:34             ` Robert Crocombe
2006-11-27 22:34               ` Stefan Richter
2006-11-28 19:07                 ` Robert Crocombe
2006-11-28 20:14                   ` Stefan Richter
2006-11-27 18:29         ` MMIO write ordering (was Re: ieee1394: host adapter disappears on 1394 bus reset) Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456B2DD0.4060500@s5r6.in-berlin.de \
    --to=stefanr@s5r6.in-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=mingo@elte.hu \
    --cc=rcrocomb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®