From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80EEC13958E for ; Thu, 29 Feb 2024 15:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709219656; cv=none; b=LUaGFWo6B4HXOl813CmarncXB3q7Gh0ukKwgrzKgnb6kr2hggqk0dsYwnDDX1IzsLkFxyYx+JcFhrzclxXKplhEUAD4WDZN/YDap5IZilrcKkLSMCYwVBx4S6AJHhtiPXKaB2Hpp8aZRMiEcXUJiEA11ThFD59Pw+6nao34AM2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709219656; c=relaxed/simple; bh=qCUSI7hzEBIgieQ+TKOpTD8trXzeXh6ezG4o/l5h41U=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=ay3LszPo3Giu4WeQf0JhJXqy8zq/9XjuqgE+9hdFeeCdhdsGrUOhF1r9raI5AWEFj1JeItEF+OITJ6sKkF3Qu6fA0pqu6lRws9PDcRS6HpCC3Ac+INVL8oMYZJH2QKQe7+Jn59ZBL6Ly/o0eeKmljMdzYgB1wY/haz/K824uj+4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RMR7OVga; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RMR7OVga" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-412c2c635bbso1733305e9.2 for ; Thu, 29 Feb 2024 07:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709219653; x=1709824453; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=BXEUZD7HIc5+BDhLp1eCYIkSCHTY2l0iyo8ZM3GFsdA=; b=RMR7OVgahViloB+vMkQvVHYjiTfFAJt9iEfF0NJFuCYdrhmhE48CzzGBjZC93mCBKS lAxD4bfGrRcK2HCh3tY9eVBJVqmvH7rAVuPvlhLsGbFhYtYyY0wXLGHIiZKrAX5NBBCg coiY/LEEZvOLmIcE9CViawHiYr9hogoPD85i3QLgOza/I7eJRhbgFkts28edK1UWCCEB vpiaaRVh2AKBZijpot467jZVrKVv5rwUwwFWf5/rv8zNlb3P/caKdChv1OAZgJ3sM4x/ 1UKhwemSa8Tu8Z1gvOlM8QiBmmaqgGbK8eZh+eQvEZ8dZAHyh8zXDkXagDEBKAxkBRxy eseA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709219653; x=1709824453; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BXEUZD7HIc5+BDhLp1eCYIkSCHTY2l0iyo8ZM3GFsdA=; b=O66zxeUTorCnBONLgJWUTZhFrzNNpHNtnzlgyTKznXcPo37oTLvCOwZlqsTb2zENfU hfTID3RKlh+KSNUkYl3KHw7rDj8NMFxWi1VIahvQ/rdPKG5YZKtsUdjykd2V9M6hooa3 8O2qPj8UcT8LRwTOXa5DOWvYYwM3/hMbpzI56+NTHnPrB5uVjEHHLVsD9DWutaDaR1/j /kRS8ByncCdjd9eKGzq/fjZxaBwVynFmGPwE6mDwfq5FkMtaYuQkN1AVD54L8PdrTa1O y2GTh/4rk8/rO00FPRz+86Eye0tNSeJzEeaAEt0AUjvm5B4ZaHNnQ1oToilWujTQ2baT VqAA== X-Forwarded-Encrypted: i=1; AJvYcCWr0bOKNqyThhyvH/QU1AiphJdtwGQ39ZwgMmVjU6WxtamQKWqLUzYtiIy9Ej+JC/M0UT359/GRMrEUqsjWrcWFir2mmutMO3k/KFnw X-Gm-Message-State: AOJu0YwWJRSM4GV717GUK1nOTKdZt1KUd5UrWl/S5gXYBRHWeEogDB6f dlkndjtgsg2fDqfKXzHHTgKThzRx1d34zXVhxGrNoU5zf7Oc/irTAdlahmmtmCo= X-Google-Smtp-Source: AGHT+IEiNaycCnI+8/fdk5xkL9CXSWuu/KBH0Xt6zhKFcDq5ZtgRezOd+aaT2eCbXnVsaGyxIl30yA== X-Received: by 2002:a05:600c:4ec7:b0:412:a206:ad3c with SMTP id g7-20020a05600c4ec700b00412a206ad3cmr2261718wmq.3.1709219652688; Thu, 29 Feb 2024 07:14:12 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:651:5318:b12c:be82? ([2a01:e0a:982:cbb0:651:5318:b12c:be82]) by smtp.gmail.com with ESMTPSA id h3-20020adfa4c3000000b0033dd2a7167fsm2010514wrb.29.2024.02.29.07.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 07:14:12 -0800 (PST) Message-ID: <456a6aa7-60e0-4a56-9efa-731f717012ac@linaro.org> Date: Thu, 29 Feb 2024 16:14:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: "neil.armstrong@linaro.org" Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v4 00/20] Support more Amlogic SoC families in crypto driver To: Alexey Romanov , Corentin Labbe Cc: "clabbe@baylibre.com" , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "khilman@baylibre.com" , "jbrunet@baylibre.com" , "martin.blumenstingl@googlemail.com" , "vadim.fedorenko@linux.dev" , "linux-crypto@vger.kernel.org" , "linux-amlogic@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , kernel References: <20240212135108.549755-1-avromanov@salutedevices.com> <20240215104719.njq6ie2niisntcnv@cab-wsm-0029881.sigma.sbrf.ru> <20240228133656.24bic6djmjvkill7@cab-wsm-0029881> <20240229025337.ftbvoaafmu5zvyha@cab-wsm-0029881> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro Developer Services In-Reply-To: <20240229025337.ftbvoaafmu5zvyha@cab-wsm-0029881> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/02/2024 14:05, Alexey Romanov wrote: > Hello! > > On Wed, Feb 28, 2024 at 09:19:32PM +0100, Corentin Labbe wrote: >> Le Wed, Feb 28, 2024 at 01:37:02PM +0000, Alexey Romanov a 'ecrit : >>> Hello, >>> >>> On Mon, Feb 19, 2024 at 07:57:27AM +0100, Corentin Labbe wrote: >>>> Le Thu, Feb 15, 2024 at 10:47:24AM +0000, Alexey Romanov a 'ecrit : >>>>> On Tue, Feb 13, 2024 at 08:21:12AM +0100, Corentin Labbe wrote: >>>>>> Le Mon, Feb 12, 2024 at 04:50:48PM +0300, Alexey Romanov a 'ecrit : >>>>>>> Hello! >>>>>>> >>>>>>> This patchset expand the funcionality of the Amlogic >>>>>>> crypto driver by adding support for more SoC families: >>>>>>> AXG, G12A, G12B, SM1, A1, S4. >>>>>>> >>>>>>> Also specify and enable crypto node in device tree >>>>>>> for reference Amlogic devices. >>>>>>> >>>>>>> Tested on AXG, G12A/B, SM1, A1 and S4 devices via >>>>>>> custom tests [1] and tcrypt module. >>>>>>> >>>>>>> --- >>>>>>> >>>>>> >>>>>> added patchs up to "drivers: crypto: meson: process more than MAXDESCS descriptors" >>>>> >>>>> Including this patch or not? >>>> >>>> The crash start with "drivers: crypto: meson: move algs definition and cipher API to cipher.c" >>> >>> Unfortunately I was unable to reproduce this. I use Khadas Vim1 board >>> and my custom tests (https://gist.github.com/mRrvz/3fb8943a7487ab7b943ec140706995e7). >>> Tried both build as module and built-in. >>> >>> Can you, please, give more information? Maybe your test cases? >> >> My test case is simple, simply load the driver. >> >> The problem is that you moved the algs[i].mc = mc after the register of algs (in drivers: crypto: meson: move algs definition and cipher API to cipher.c) >> Test could happen as soon the register is done and so mc is deferenced. > > Yeah, you are right. Will fix it. Thank you. > >> >> Since you didnt hit the case, I suspect you didnt test the driver as module. > > No, I test the driver as module. > I think the problem is that on my system no one uses this crypto backend > outside of my tests module, unlike your system. I reproduced the issue, testing each commit with enabled runtime cryto tests: I get the following when applying "drivers: crypto: meson: introduce hasher": [ 4.514031] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 4.517193] Mem abort info: [ 4.519934] ESR = 0x0000000086000004 [ 4.523641] EC = 0x21: IABT (current EL), IL = 32 bits [ 4.528903] SET = 0, FnV = 0 [ 4.531920] EA = 0, S1PTW = 0 [ 4.535025] FSC = 0x04: level 0 translation fault [ 4.539856] [0000000000000000] user address but active_mm is swapper [ 4.546155] Internal error: Oops: 0000000086000004 [#1] PREEMPT SMP [ 4.552359] Modules linked in: [ 4.555376] CPU: 2 PID: 77 Comm: cryptomgr_test Not tainted 6.8.0-rc6-next-20240229-g2296d426c21a #105 [ 4.564608] Hardware name: Libre Computer AML-S905X-CC (DT) [ 4.570125] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 4.577025] pc : 0x0 [ 4.579178] lr : ahash_def_finup+0x12c/0x14c [ 4.583406] sp : ffff8000825037a0 [ 4.586683] x29: ffff8000825037a0 x28: 0000000000000001 x27: ffff000007ab8060 [ 4.593758] x26: ffff800082503958 x25: 0000000000000400 x24: ffff800082503918 [ 4.600830] x23: 0000000000000820 x22: ffff0000048ec390 x21: ffff000003d9e200 [ 4.607903] x20: ffff0000048ee300 x19: ffff000003d9e400 x18: 0000000000000020 [ 4.614976] x17: 00000000b5f74d5b x16: ffff800081bbbc60 x15: ffffffffffffffff [ 4.622048] x14: ffff0000049fb380 x13: 0000000000000000 x12: 0000000000000000 [ 4.629120] x11: ffff800082503778 x10: ffff800082503780 x9 : 0000000000001388 [ 4.636193] x8 : ffff800082503988 x7 : fefefefefefefefe x6 : 0101010101010101 [ 4.643265] x5 : ffff0000049fb300 x4 : ffff00007f2d5830 x3 : 0000000000000000 [ 4.650338] x2 : 0000000000000000 x1 : ffff0000048ee300 x0 : ffff000003d9e200 [ 4.657411] Call trace: [ 4.659823] 0x0 [ 4.661633] crypto_ahash_finup+0x38/0x44 [ 4.665602] test_ahash_vec_cfg+0x680/0x7dc [ 4.669742] test_hash_vec+0xac/0x1ec [ 4.673364] __alg_test_hash+0x158/0x308 [ 4.677246] alg_test_hash+0xfc/0x1a0 [ 4.680868] alg_test.part.0+0x51c/0x524 [ 4.684750] alg_test+0x20/0x64 [ 4.687854] cryptomgr_test+0x24/0x44 [ 4.691477] kthread+0x118/0x11c [ 4.694668] ret_from_fork+0x10/0x20 [ 4.698214] Code: ???????? ???????? ???????? ???????? (????????) [ 4.704247] ---[ end trace 0000000000000000 ]--- Please make sure every single commit builds without error and doesn't regress at runtime on existing platforms. Thanks, Neil > >> >> Regards >