From: Aleksa Savic <savicaleksa83@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: savicaleksa83@gmail.com, linux-hwmon@vger.kernel.org,
leonard.anderweit@gmail.com, Jack Doan <me@jackdoan.com>,
Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (aquacomputer_d5next) Check if temp sensors of legacy devices are connected
Date: Wed, 25 Oct 2023 22:04:36 +0200 [thread overview]
Message-ID: <456be27a-1e62-4b88-a868-6238813c26c8@gmail.com> (raw)
In-Reply-To: <ac61decf-8ab7-46c1-83f0-d3f79f737bbf@roeck-us.net>
On 2023-10-25 21:41:00 GMT+02:00, Guenter Roeck wrote:
>
> Why is the sensor instantiated in the first place ?
> Returning -ENODATA for every reading is not desirable.
> If this can happen, the is_visible function should check
> for it and skip affected sensors.
>
> Guenter
>
The external temp sensor(s) are hot-swappable and can be plugged
or unplugged anytime. Similar logic already exists in
aqc_raw_event() for the sensors.
Thanks,
Aleksa
next prev parent reply other threads:[~2023-10-25 20:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 8:35 [PATCH 0/2] hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow USB and MPS Flow Aleksa Savic
2023-10-16 8:35 ` [PATCH 1/2] hwmon: (aquacomputer_d5next) Check if temp sensors of legacy devices are connected Aleksa Savic
2023-10-25 19:41 ` Guenter Roeck
2023-10-25 20:04 ` Aleksa Savic [this message]
2023-10-16 8:35 ` [PATCH 2/2] hwmon: (aquacomputer_d5next) Add support for Aquacomputer High Flow USB and MPS Flow Aleksa Savic
2023-10-28 16:24 ` Guenter Roeck
2023-10-29 15:58 ` Aleksa Savic
2023-10-29 16:59 ` Guenter Roeck
2023-10-29 17:13 ` Aleksa Savic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456be27a-1e62-4b88-a868-6238813c26c8@gmail.com \
--to=savicaleksa83@gmail.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=leonard.anderweit@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=me@jackdoan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®