From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CB7A3F7896 for ; Tue, 30 Jun 2026 12:04:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782821082; cv=none; b=iNaT0h9BwzQMsZtJZP4PjeIVMI3ap4+zVoH/jshUtNZ7LMOdceX97KG7KzZP0cTKFVaUJIs+XP9tIymXLrSOr7Lvb/zuGTChCHICT1Pmb3l94FE4OG9xOubOhpHzl7tG/+2RpJL9Bgvuwfd/6EGACmzkq6VxdIOcSFcVJIQE3DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782821082; c=relaxed/simple; bh=2u1+1s3LllqRcXvrtwNyjdlEgfbYJsRTb31iaSqge2U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LlhNLF+gEcoQ7lWD6ldSilDXNJxXxmeTY92OU0MUfbfQkPMJwj4DPnXtuYNh1XsPmWJB4F7Uo4sYlzIcJb7bHVhB0AJd6n32mhUx/SQfRhgdDnsO35XbVt/kMC855OwlbC2prP0fMAOmSjMMXWUkf5ERO7rUxcg4FnPeXhbSx20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CWsZJXTk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WxOOiySw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CWsZJXTk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WxOOiySw" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9n9JA1605923 for ; Tue, 30 Jun 2026 12:04:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +30fU8u7ebAIK9tBeViJ2CQuNZoM6yp3p/ercnVPPxs=; b=CWsZJXTkef4pdvqf /qcr9ap24auSylx3VWie1K/SBvMf/FR5e6y7HU8IW1CjtyV8tdul0A3Z4ceflAk6 P9t49NkyHdUgaireLYNO+hTILgYoRzdcCbT1Nyx4y2kWEJEO/eGaFglp8gUVA2IJ B249ZMHzH5a//+WjzYjy96Yr0urhYHGvE/B2u5RUwUBiVWwRx60K5Lix+0ff0KUd yFrqTF42FjeCqhETRjfbiQKcQCNjhn11JauCiyzvSPbS7qgolgFoiiKSeDv65fKP ro0EcieAT80Vwpk0jiSVnyiovwVYW/lE0C2lSTEMEz7krTW65ybkkfCxYa9ob2X8 VM6IhA== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f45k5t7s3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 12:04:40 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-96929cba004so118630241.1 for ; Tue, 30 Jun 2026 05:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782821079; x=1783425879; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+30fU8u7ebAIK9tBeViJ2CQuNZoM6yp3p/ercnVPPxs=; b=WxOOiySwmKc85gI+5m1Dj+a+XapA98t+EsRkUfEbLf//HyxmySViNA6ldoGyWEt/Bg tTWwDULrMQJo5nQmobfIuWFQAqUy5pYoDWrFP2zibuRncygS7YFSlkIZdZKucXTtDdBx 5EVp7+Ep9lzjFOoRnW/GTyrBihQOKLCY9vm1gW5NLjdN8TDMRtwJ4zfaBJa1VXitxKqO gI9PzjQrv+2IGXhMOgl92GjPltBbnVEB2KARXoeKvduCq1i1OYgrQWaeIWx7pa48g8Tu Q3fS/Idgcr5UGXFYGBYZbog3By7FwFaP8KMyrasn1DxuBSG+ExEI3K2SXNCx89fzm4nq oqhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782821079; x=1783425879; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+30fU8u7ebAIK9tBeViJ2CQuNZoM6yp3p/ercnVPPxs=; b=o04+n1FXDempZMKjbOo9Qy473rNJpZxFhpu4LAtuRNZ4Zv8imWVqOnHo5hgZ8yqXsv VAEFG74VcSF6F1Z8/WRqK2tJFzr2Y9VMMi1Sedc7GSjTFXjM4fhu3I4k8qudbYowrqR+ fL7sPHe9yjGVAdo2CgjNNNVGvNPCaahoOgmKmv5YYINdTiYT8rIRZonrbL5Gp63TFtdi vVV26XDyXPgq0dy7ZjNJ3HbX4aRx68Xe+J/40o2DATS4cA48tklI81IJ4pu3i7mE8Rmr Px6aO2IpAYk3lEbG4U4C9zEX1eaIgfm2r06ytDaJNRrwumD7L6X2UDvTXz+F5CrAKEwu oaEA== X-Forwarded-Encrypted: i=1; AHgh+Rpx6hakC+g5X+fhribQ7VJYndRW0IIg+XgqHUlMAKjzp9xUJ/hNj16px3xpyrH6kb2azUXrIMkH5DaL8u8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9CdY7PqbMquI7QU8LyUAAIXe/8a9bHDlm7+64oKZNqSroR3aw vH/mkbuv/DSNYl/9kljex3VRAiVMILyt2n78vUzIA6lFxXDzyDyHt1pXirwuX4N6bA15jMBH3s3 29XzoyB/tLMxAfgvN0UEyKdaqvapYRyetImtJn/spxijdfAVQrmrmzdsy80gptLxapcw= X-Gm-Gg: AfdE7clc5um3q9W4H703PyMHiIn+X6MrILoFgwXQ4XdUoM2Gm/7w6ftJRQgl0geOeCT yYt1ErgdOg9Bd2B2VokJrSn8KcVk8pII1tAtMwploOuXnFhZZbCtxyVlWAdeHo6iYIQOQ1ToYHw AkFO2D3tFcDr37PLCRent0qVlG7h3JSbpKDta/zov/exLGsp0FTIEFHKTeAgPjysX+CjfwoibXE L6LlcC0JOcz3pocdojkZkRJ0PtT97CSDbrEJ+p3A4ukkQJSBVkV44v6q0WFrBEKAtRVnoGGpw/k SM60GYHcR0Fb4guB/WJUWUTgZCo6k9AJSw8O2K8F7gW8Cn1SCH7I3ASTXEXZtR9GZ/SwQnRUqXY rIfR/qpgTkhjyZGqf8O8E7mudznfIDj6tXIY= X-Received: by 2002:a05:6102:6886:b0:738:8d0f:72a3 with SMTP id ada2fe7eead31-73a3853a35fmr562314137.4.1782821079601; Tue, 30 Jun 2026 05:04:39 -0700 (PDT) X-Received: by 2002:a05:6102:6886:b0:738:8d0f:72a3 with SMTP id ada2fe7eead31-73a3853a35fmr562301137.4.1782821079207; Tue, 30 Jun 2026 05:04:39 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c3b5ca9sm1117702a12.9.2026.06.30.05.04.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 05:04:38 -0700 (PDT) Message-ID: <4571c6af-2a5b-49ac-903e-b158d9cbad16@oss.qualcomm.com> Date: Tue, 30 Jun 2026 14:04:36 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au To: Jishnu Prakash , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayyagari Ushasreevalli , Kamal Wadhwa References: <20260614-adc5_gen3_dt-v2-0-32ec576c5865@oss.qualcomm.com> <20260614-adc5_gen3_dt-v2-2-32ec576c5865@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260614-adc5_gen3_dt-v2-2-32ec576c5865@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=AqDeGu9P c=1 sm=1 tr=0 ts=6a43b0d8 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=bnp5ujGDWJDzncnA5ckA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-GUID: KQJiLdDX-28-aylbIQ3mPpnMIY6zqm2w X-Proofpoint-ORIG-GUID: KQJiLdDX-28-aylbIQ3mPpnMIY6zqm2w X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDExMSBTYWx0ZWRfX7a++amuXlaF5 AkxIRh2bFB8kJ1y/+MN/uqC632+DHvngJ1DKaNGqZjHXElCtcaMLpzui/vaF/IsSwENnnx9Tu2n rDPi9ahFDu+XT0RG+FN9i4S/7FeBaDB92GRzBmo5qczBRimqj0a+q6MD/D3QQBfYtC1OzM0eNYo npQMOXpPR9ANcS3x/awN5rabb7HqwiZ3zxH3W/XTov8PYzd1hS9bUMQL13RGIyaBnw/qO2FrXLc b1bjN+iYCvATP+HFiV2DRqabucjwtmc25U8j8z3zMYUq1396eDP6YxBRDeVpHuGCXOL/QWMEw8C 0EayxCmyvom+l9Q+5SgyqYGH8r387IthN6bTFxUS8ar8ehGjxVpDVdzfi4uJiI17XIaKuTw38ZW NRBVQM37yt7I0pNIPVbM6BBkC4B/9ndSkjX4gKcGiLq4mFMc0ulQkGt7jt73j3hloesWwQMq7Da 9kTYoPZUVzNhDWKNF4Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDExMSBTYWx0ZWRfX/osXOk2/CiZG F0xMwZmNnh36lTsxbU+mR6bkDMEDumWh1TauUa9LXXwRn3zhaIxsKyUPWyyaQZwEz1bn+B0k71H pNKpsBsANVkdIDdqK3jEhBdtfM31sko= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300111 On 6/14/26 10:05 AM, Jishnu Prakash wrote: > From: Ayyagari Ushasreevalli > > Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through > pmm8654au_3) on the Lemans platform. > > Each ADC node exposes the following ADC channels: > - DIE_TEMP: PMIC die temperature channel > - VPH_PWR: Battery/supply voltage channel > > Also add the io-channels and io-channel-names properties under > the temp-alarm nodes so that they can get temperature reading > from the ADC die_temp channels. > > Signed-off-by: Ayyagari Ushasreevalli > Signed-off-by: Jishnu Prakash > --- [...] > + pmm8654au_0_adc: adc@8000 { > + compatible = "qcom,spmi-adc5-gen3"; > + reg = <0x8000>; > + #address-cells = <1>; > + #size-cells = <0>; > + interrupts = <0x0 0x80 0x1 IRQ_TYPE_EDGE_RISING>; > + #io-channel-cells = <1>; Same nit as patch 3 and only now I realized - s/interrupts/interrupts-extended - this is necessary for !Linux, see 2d5cab9232ba ("arm64: dts: qcom: sc8280xp-pmics: Specify interrupt parent explicitly") with that: Reviewed-by: Konrad Dybcio Konrad