mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasant Hegde <vasant.hegde@amd.com>
To: "Jörg Rödel" <joro@8bytes.org>
Cc: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@amd.com>,
	will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev,
	linux-kernel@vger.kernel.org, suravee.suthikulpanit@amd.com,
	Santosh.Shukla@amd.com
Subject: Re: [PATCH] iommu/amd: Enhance "Completion-wait Time-out" error message
Date: Wed, 29 Oct 2025 16:18:53 +0530	[thread overview]
Message-ID: <4571f444-01ca-45e4-8465-745e16c1b73d@amd.com> (raw)
In-Reply-To: <5uof463yi5zq6y3rsjqdifktvqxe4ctb63koz4qgbwvjgiudlg@qtjxrrymt3mj>



On 10/29/2025 2:00 PM, Jörg Rödel wrote:
> On Tue, Oct 28, 2025 at 02:45:16PM +0530, Vasant Hegde wrote:
>> We have debugfs support to extract entire command buffer. Also many cases once
>> we hit completion wait timeout, buffer won't progress.. and we will hit
>> completion wait repetitively. Hence in V2 he has removed printing entire command
>> buffer.
>>
>> Do you want to log entire buffer once to dmesg if amd_iommu_dump=1 ? (for first
>> completion wait timeout event).
> 
> I think there is some value in printing the command buffer contents at the
> point in time when the timeout happens. When it is read later from debug-fs,
> the state of the command buffer might already be different, making debugging
> harder.

Ack. if amd_iommu_dump=1 then we can log entire command buffer to dmesg once.


-Vasant


  reply	other threads:[~2025-10-29 10:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16 15:08 Dheeraj Kumar Srivastava
2025-10-27 12:49 ` Jörg Rödel
2025-10-28  9:15   ` Vasant Hegde
2025-10-29  8:30     ` Jörg Rödel
2025-10-29 10:48       ` Vasant Hegde [this message]
2025-10-29 11:16         ` Dheeraj Kumar Srivastava
2025-11-05  6:43   ` Dheeraj Kumar Srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4571f444-01ca-45e4-8465-745e16c1b73d@amd.com \
    --to=vasant.hegde@amd.com \
    --cc=Santosh.Shukla@amd.com \
    --cc=dheerajkumar.srivastava@amd.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®