From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 059061BBBE5 for ; Tue, 6 Jan 2026 08:56:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767689793; cv=none; b=BSIaCMHjyNv/Atkbly/YONBi7bPNF6U/IovG3WgulhhWgDAMLAV10g4/jYAOpiB+5jjD3a+0ys73aT7rcMVIw2HzGy4rkI5YKti+yvqCqqSA5wIUHnAV3F4gTTQ68nC+s+XJvH8QDtAy/v1Ty6PRD/KbRHUxCdONEt8FyY8slPk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767689793; c=relaxed/simple; bh=ZQd0mkaoJ/k0RLz6SCLM9O40MtyyNiV+xhQ59qze/4Q=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=j+K2Ie0MwtJqRZhJrFold6vRW9sWUyB+HzcWSCVie08oGgV3JWT22pTMtM5y18l0yTlF2DrsfM+gbPXZ09yWIaomUuhVqhIU3ZRSt0J4AoUtNKHJWylTjVrTm5afdg82kobfp/cSZZSfS8w8R+RMork6OHnAkON+zqL42pH5MZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hTyJ4kjh; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hTyJ4kjh" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so6580855e9.1 for ; Tue, 06 Jan 2026 00:56:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767689790; x=1768294590; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=6IZeLqj+ruvOseCJfQqbCMgkS4X67AcGqRU1gJ/WVx0=; b=hTyJ4kjhky0fqLL2gm8cdoEAYSOvXihcq93TEKfUDPw6SVjBxhKjvSzQzORt4y6P3l qDEoXqMcfztNILE42q+mhsLIUCL209/HPNWbl8Dqafg4OhM+NWJrL894vv5uXtG4slyh y5NZm6ISe/ogts7dw80z753n7MlFqAOMGRZ7kqcg4PM7B0ZEgXKD9CFUFpomRQaO9dom 0UWFnAx7JS9tNiYKrL+YM8zeYgU9NrO3INRiIhh41fkuOB/wIoL5lwO+ssNiVCRJwRDp lRCiHAn6xdhx1/Zny9rCiXBMYIj41uNoUxcXiEtirYdgPnkHc8JWCXgXG4UPdwiefF4V rKdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767689790; x=1768294590; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6IZeLqj+ruvOseCJfQqbCMgkS4X67AcGqRU1gJ/WVx0=; b=Y9BNGD++v3qOQrAf5TOOnTNHT7TDWd0UM8kbaTxwVLejXw2Ax6Hikhs6NTkIsoM8kW 7bISXX1E7zrAFPWPai9MOXKNKsR9AkgpRsIVKXtGR5ofFUSxv1FHkJgvzJojb8AsX5nF koRPin5vgYuekL8u7zu1KnpRW/iqr41dYudPYb8f2BUetFg3BGXU8KKnzcsg5yuDXdjX tjZ+Cloja5Cp+cs+TvLLW6purJKQcqBeR5rKhLRMmQm5wbnp6f5A8DXK0zKifFDPG5e1 sEiYSczzylNYRDsyUY1aNdVY7pIUNEOoYj0xJOinvENN/XCU3BeCylUsQShPJb6UehPM THHg== X-Forwarded-Encrypted: i=1; AJvYcCX2MIB2Lg2FtZLNFPgLvCkQk7kgAcwqX0nG4WiZhceVbkFTk/QPLRAOTbItWhAFoea/hRXSBnltwyPIiLc=@vger.kernel.org X-Gm-Message-State: AOJu0YwY6kIXBsGghQK7sod0OYZCV2pk25tO8l0xt8HNKC6v/ygih4YN tm1Q05UuPs0wBbIX3l0U0gVuRkTvD0MIXg3LZXKgIrKweg2KJ76AgXIGa79cbY+VYb4OpY9YeGH uEZ5a X-Gm-Gg: AY/fxX4O40mrOJOoKhegtSN6VqFVvNBua0XQsa7tjsRTE3xPKOogtgCQB3gaNKvU8bO FYzhiS8TcXptOulGt5R0D8aANXeAm7bMlfoGotoU+NNHFmpvdKk2g+TwF+xijAC0Kj+twf0+HnD tL2wcLRdPnYjV0n5nfMVNkAL3QhHHjCCAzzfzogwuGYclMb9uTrWm6Nd1aNtmlUXJi7sL0NWf2r GwBYgoAWLWbsKXITqbhXvKUHf1ItBDbqGc1L1+t/VfNl6hDPApeYwFE3BHaTad8IxKS275u2kf8 HE9NIyoxpMqAfWwSX0uz3G+7gRQqFeEetBGX3YL6uE3r2yYWLeiU9c+vjla6Ka0gXC+B1VuWn8R GmbRAr8ZLX5M1LAxFU/344/9bNDttmFylhD9anTQRKe3PYt/Fn9fkg2rVJYKsW1iwVdEBvM6bQu 80bSa2dJzcySJw+SMHxeLxLhQ7yJMUyO3D7LGwgVX5I19Iclei85ekFiUI2x1/pus= X-Google-Smtp-Source: AGHT+IG80cOu+UYpaSS69Js4IGq8lZkxpoi0TpsqqXRYJFgEZTRy7wjNDpSqoquo9LkYuW0Gnc5yGQ== X-Received: by 2002:a05:6000:4301:b0:432:b951:ea00 with SMTP id ffacd0b85a97d-432bca5470amr2758228f8f.51.1767689790219; Tue, 06 Jan 2026 00:56:30 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:d283:7a7e:4c57:678d? ([2a01:e0a:3d9:2080:d283:7a7e:4c57:678d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e19bfsm3231120f8f.18.2026.01.06.00.56.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 00:56:29 -0800 (PST) Message-ID: <4573ac2e-795b-42d7-a30b-892bb932aed4@linaro.org> Date: Tue, 6 Jan 2026 09:56:29 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions To: Avinal Kumar Cc: jessica.zhang@oss.qualcomm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251127161337.396531-1-avinal.xlvii@gmail.com> <2a9f7c54-3669-4f8b-b46b-b7e01712a1b8@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/6/26 09:53, Avinal Kumar wrote: > Hello Neil, > > Unlike mipi_dsi_turn_on_peripheral, mipi_dsi_shutdown_peripheral isn't marked deprecated, and no multi function available yet. And I wanted to keep it simple for the first patch. > > If it is okay, I can: > - Create another patch or update this patch, to add a mipi_dsi_shutdown_peripheral_multi() function and deprecate the normal function. > - Update the remaining function in this patch. > > Please let me know. Thank you Yes please do that, first patch introduce mipi_dsi_shutdown_peripheral_multi(), then second patch switch to multi for wuxga_nt_panel_on() and wuxga_nt_panel_disable(). Thanks, Neil > > > On Tue, Jan 6, 2026 at 1:51 PM > wrote: > > Hi, > > On 11/27/25 17:08, Avinal Kumar wrote: > > Changes the panasonic-vvx10f034n00 panel to multi > > style functions for improved error handling. > > > > Signed-off-by: Avinal Kumar > > > --- > > Here is the todo list for reference: https://www.kernel.org/doc/html/latest/gpu/todo.html#transition-away-from-using-deprecated-mipi-dsi-functions > > > > This is my first patch in Linux Kernel :) > > > >   drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 7 ++++++- > >   1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > > index 3c3308fc55df..03c87c02fb57 100644 > > --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > > +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > > @@ -44,7 +44,12 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel) > > > >   static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt) > >   { > > -     return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi); > > +     struct mipi_dsi_multi_context dsi_ctx = { > > +             .dsi = wuxga_nt->dsi > > +     }; > > + > > +     mipi_dsi_turn_on_peripheral_multi(&dsi_ctx); > > +     return dsi_ctx.accum_err; > >   } > > > >   static int wuxga_nt_panel_disable(struct drm_panel *panel) > > Why didn't you also update wuxga_nt_panel_disable() ? > > Thanks, > Neil >