mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: sxwjean@me.com, 42.hyeyoo@gmail.com, cl@linux.com, linux-mm@kvack.org
Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
	roman.gushchin@linux.dev, corbet@lwn.net, keescook@chromium.org,
	arnd@arndb.de, akpm@linux-foundation.org,
	gregkh@linuxfoundation.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Xiongwei Song <xiongwei.song@windriver.com>
Subject: Re: [PATCH v2 0/3] supplement of slab allocator removal
Date: Wed, 6 Dec 2023 17:13:19 +0100	[thread overview]
Message-ID: <457899ac-baab-e976-44ec-dfdeb23be031@suse.cz> (raw)
In-Reply-To: <20231203001501.126339-1-sxwjean@me.com>

On 12/3/23 01:14, sxwjean@me.com wrote:
> From: Xiongwei Song <xiongwei.song@windriver.com>
> 
> Hi,
> 
> Patch 1 is to remove an unused parameter. This patch actually is v3, but
> it is not reasonable to add v3 tag in the cover letter, so I put the
> change history inside the patch.
> 
> ---
> Patch 2 is to replace slub_$params with slab_$params.
> Vlastimil Babka pointed out we should use "slab_$param" as the primary
> prefix for long-term plan. Please see [1] for more information.
> 
> This patch is to do that. However, the patch is big, I'm not sure if
> everything is proper in it, so I added "RFC" in the patch title. For more
> information please see the commit message of patch.
> 
> I did the basic tests with qemu, which passed values by sl[au]b_max_order,
> sl[au]b_min_order, sl[au]b_min_objects and sl[au]b_debug in command line.
> The values looks correct by printing them out before calculating orders.
> 
> One thing I'm not sure about the forth parameter of __setup_param(),
> Is it correct to set the parameter to 0 directly?

Yep it's fine.


  parent reply	other threads:[~2023-12-06 16:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-03  0:14 sxwjean
2023-12-03  0:14 ` [PATCH v2 1/3] Documentation: kernel-parameters: remove noaliencache sxwjean
2023-12-06 15:35   ` Vlastimil Babka
2023-12-03  0:15 ` [RFC PATCH v2 2/3] mm/slub: unify all sl[au]b parameters with "slab_$param" sxwjean
2023-12-06 16:14   ` Vlastimil Babka
2023-12-08  1:58     ` Song, Xiongwei
2023-12-09  1:02     ` Song, Xiongwei
2023-12-13 11:10       ` Vlastimil Babka
2023-12-03  0:15 ` [PATCH v2 3/3] mm/slub: correct the default value of slub_min_objects in doc sxwjean
2023-12-05  0:53   ` Hyeonggon Yoo
2023-12-05 14:10     ` Song, Xiongwei
2023-12-06  0:22       ` Hyeonggon Yoo
2023-12-06 14:33         ` Song, Xiongwei
2023-12-06 16:33     ` Vlastimil Babka
2023-12-08 23:17       ` Song, Xiongwei
2023-12-06 16:13 ` Vlastimil Babka [this message]
2023-12-08  2:03   ` [PATCH v2 0/3] supplement of slab allocator removal Song, Xiongwei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457899ac-baab-e976-44ec-dfdeb23be031@suse.cz \
    --to=vbabka@suse.cz \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=keescook@chromium.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=sxwjean@me.com \
    --cc=xiongwei.song@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®