From: <Claudiu.Beznea@microchip.com>
To: <walker.chen@starfivetech.com>, <broonie@kernel.org>,
<dan.carpenter@linaro.org>, <lgirdwood@gmail.com>,
<tiwai@suse.com>, <perex@perex.cz>
Cc: <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ASoC: starfive: Remove some unused macros
Date: Fri, 9 Jun 2023 09:08:26 +0000 [thread overview]
Message-ID: <45793158-b1af-ce7f-1da1-9a63cea670d8@microchip.com> (raw)
In-Reply-To: <20230608135750.11041-3-walker.chen@starfivetech.com>
On 08.06.2023 16:57, Walker Chen wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> These macros are unused and can be dropped.
>
> Signed-off-by: Walker Chen <walker.chen@starfivetech.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> sound/soc/starfive/jh7110_tdm.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_tdm.c
> index a9a3d52bdd2a..e4bdba20c499 100644
> --- a/sound/soc/starfive/jh7110_tdm.c
> +++ b/sound/soc/starfive/jh7110_tdm.c
> @@ -25,11 +25,8 @@
> #include <sound/soc-dai.h>
>
> #define TDM_PCMGBCR 0x00
> - #define PCMGBCR_MASK 0x1e
> #define PCMGBCR_ENABLE BIT(0)
> - #define PCMGBCR_TRITXEN BIT(4)
> #define CLKPOL_BIT 5
> - #define TRITXEN_BIT 4
> #define ELM_BIT 3
> #define SYNCM_BIT 2
> #define MS_BIT 1
> @@ -42,11 +39,6 @@
> #define LRJ_BIT 1
> #define TDM_PCMRXCR 0x08
> #define PCMRXCR_RXEN BIT(0)
> - #define PCMRXCR_RXSL_MASK 0xc
> - #define PCMRXCR_RXSL_16BIT 0x4
> - #define PCMRXCR_RXSL_32BIT 0x8
> - #define PCMRXCR_SCALE_MASK 0xf0
> - #define PCMRXCR_SCALE_1CH 0x10
> #define TDM_PCMDIV 0x0c
>
> #define JH7110_TDM_FIFO 0x170c0000
> --
> 2.17.1
>
next prev parent reply other threads:[~2023-06-09 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 13:57 [PATCH v2 0/2] Fix error check and cleanup for JH7110 TDM Walker Chen
2023-06-08 13:57 ` [PATCH v2 1/2] ASoC: starfive: Fix an error check in jh7110_tdm_clk_reset_get() Walker Chen
2023-06-09 9:08 ` Claudiu.Beznea
2023-06-08 13:57 ` [PATCH v2 2/2] ASoC: starfive: Remove some unused macros Walker Chen
2023-06-09 9:08 ` Claudiu.Beznea [this message]
2023-06-09 12:14 ` [PATCH v2 0/2] Fix error check and cleanup for JH7110 TDM Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45793158-b1af-ce7f-1da1-9a63cea670d8@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=walker.chen@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®