From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7A8C4167B for ; Tue, 29 Nov 2022 21:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237094AbiK2Vyw (ORCPT ); Tue, 29 Nov 2022 16:54:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237061AbiK2Vyt (ORCPT ); Tue, 29 Nov 2022 16:54:49 -0500 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 697E06C72A for ; Tue, 29 Nov 2022 13:54:48 -0800 (PST) Received: by mail-io1-xd29.google.com with SMTP id r81so11119058iod.2 for ; Tue, 29 Nov 2022 13:54:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ur6a/CzXJIypB8RYZUhojWApn7N1bPxeoQ/GZe4dipA=; b=gzcqXxjvNW6BZ3wOYM5yYHr3eUcD+l8Qw/s4DjB26DCMtvo7UxZ7DmoJwVC5fA0lGp HVtjdK7eTE11no/FnqNrxB4rOX88+GRSvf4RfZjf9a5mqSvRxhikadM6e7jIwlpDLQC+ iZFYPlxx3eAI8oNhhgr7OuWohSNVbuIq5JL8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ur6a/CzXJIypB8RYZUhojWApn7N1bPxeoQ/GZe4dipA=; b=L5sGkW4w79OqufCu7oZ0udYNIwTewWtuseTWDYDvopcGrmfgv+qirNv1xWtBCrOuad VXApr/HhKslx5w1FosKN0spDdQ6ccRgQwgszf3M7179SxBkm2yiISEjIO/pIKZHTzK0z BigMhUqYcod8xrdu985L/4KMpWYh4YJpKdnqBRTgDYjXRjBbjUXP/SwHatAqKdfiXBpU 7LxaFvs9Y2f78GukrezP9UKuV53f8MNGR73gdlXJ1V9lQX0MZFNwWl9/MiDmavYTeqzQ VhfSgHGXIf7TaGgsvsNqCcepU9qH7BFmt+wpAH/PngFW2cgc+zpGaJVddC6k+WnCZIhI LD8Q== X-Gm-Message-State: ANoB5pnhjm7x+v/sL9zRODUXYprpwx3/ha2ahtcq3QPQIqhk56dTLs9m EHk8XEwQ/QB4zjYEI6MEAulzKQ== X-Google-Smtp-Source: AA0mqf7LHtE52CmTARBNuYJtjnj/4Aq5OQqGdnW1PT00LdzNDs4Ib56U1AUEE6p4ZUYmZ0aWlAZiWA== X-Received: by 2002:a05:6638:1a98:b0:375:61b2:825a with SMTP id ce24-20020a0566381a9800b0037561b2825amr28405190jab.147.1669758887713; Tue, 29 Nov 2022 13:54:47 -0800 (PST) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id b36-20020a0295a7000000b0037612be6830sm5491192jai.140.2022.11.29.13.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 13:54:46 -0800 (PST) Message-ID: <45793334-f890-d0e6-dd3a-6335ed0628f8@linuxfoundation.org> Date: Tue, 29 Nov 2022 14:54:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 3/3] selftests: Make a warning if getcpu is missing on 32bit. Content-Language: en-US To: Sebastian Andrzej Siewior , linux-kernel@vger.kernel.org, x86@kernel.org Cc: Roland Mainz , "H. Peter Anvin" , Borislav Petkov , Dave Hansen , Ingo Molnar , Thomas Gleixner , Shuah Khan , linux-kselftest@vger.kernel.org, Shuah Khan References: <20221125094216.3663444-1-bigeasy@linutronix.de> <20221125094216.3663444-4-bigeasy@linutronix.de> From: Shuah Khan In-Reply-To: <20221125094216.3663444-4-bigeasy@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/22 02:42, Sebastian Andrzej Siewior wrote: > The vsyscall for getcpu has been wired up on 32bit so it can be warned > now if missing. > > Cc: Shuah Khan > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Sebastian Andrzej Siewior > --- > tools/testing/selftests/x86/test_vsyscall.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c > index 5b45e6986aeab..47cab972807c4 100644 > --- a/tools/testing/selftests/x86/test_vsyscall.c > +++ b/tools/testing/selftests/x86/test_vsyscall.c > @@ -92,11 +92,8 @@ static void init_vdso(void) > printf("[WARN]\tfailed to find time in vDSO\n"); > > vdso_getcpu = (getcpu_t)dlsym(vdso, "__vdso_getcpu"); > - if (!vdso_getcpu) { > - /* getcpu() was never wired up in the 32-bit vDSO. */ > - printf("[%s]\tfailed to find getcpu in vDSO\n", > - sizeof(long) == 8 ? "WARN" : "NOTE"); > - } > + if (!vdso_getcpu) > + printf("[WARN]\tfailed to find getcpu in vDSO\n"); > } > > static int init_vsys(void) Assuming this is going through x86 tree due to dependencies, here is my ack Acked-by: Shuah Khan Let me know if you would like to me pick this up. thanks, -- Shuah