From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vidya Sagar <vidyas@nvidia.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
thierry.reding@gmail.com, jonathanh@nvidia.com,
mperttunen@nvidia.com
Cc: devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, kthota@nvidia.com,
mmaddireddy@nvidia.com, sagar.tv@gmail.com
Subject: Re: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support
Date: Thu, 27 Oct 2022 17:18:53 -0400 [thread overview]
Message-ID: <4579404d-b3f7-8342-6704-2644f5cd489d@linaro.org> (raw)
In-Reply-To: <20221027051214.22003-2-vidyas@nvidia.com>
On 27/10/2022 01:12, Vidya Sagar wrote:
> Add support for ECAM aperture for Tegra234.
>
> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> ---
> .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml | 10 ++++++++--
> .../devicetree/bindings/pci/snps,dw-pcie.yaml | 2 +-
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> index 75da3e8eecb9..15cc2d2055bb 100644
> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
> @@ -27,6 +27,7 @@ properties:
> - nvidia,tegra234-pcie
>
> reg:
> + minItems: 4
> items:
> - description: controller's application logic registers
> - description: configuration registers
> @@ -35,13 +36,17 @@ properties:
> available for software access.
> - description: aperture where the Root Port's own configuration
> registers are available.
> + - description: aperture to access the configuration space through ECAM.
> + This is applicable only for Tegra234.
Then restrict it per compatible in allOf
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-27 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 5:12 [PATCH V1 0/2] Add ECAM aperture for Tegra234 Vidya Sagar
2022-10-27 5:12 ` [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support Vidya Sagar
2022-10-27 21:18 ` Krzysztof Kozlowski [this message]
2022-10-28 12:09 ` Vidya Sagar
2022-10-28 12:47 ` Krzysztof Kozlowski
2022-10-31 16:33 ` Rob Herring
2022-10-31 16:42 ` Vidya Sagar
2022-10-27 5:12 ` [PATCH V1 2/2] arm64: tegra: Add ECAM aperture info for all the PCIe controllers Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4579404d-b3f7-8342-6704-2644f5cd489d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=mperttunen@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sagar.tv@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®