From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F1EEB64DD for ; Thu, 15 Jun 2023 10:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343651AbjFOKID (ORCPT ); Thu, 15 Jun 2023 06:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343779AbjFOKHo (ORCPT ); Thu, 15 Jun 2023 06:07:44 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D19830E1; Thu, 15 Jun 2023 03:07:13 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EE699223EE; Thu, 15 Jun 2023 10:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686823591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WH1mOxnVXww19hxVqg6mJd5pC69heDnq/9XJzwgco1Q=; b=cYn/C7bZx8ySP+HeQK+9vk+yZsclzMHDTS/BPwkBDk8Eyr7DDHdgLwAx3xvjXrfgF35Y/7 nSfrPw4++G1yZupHofx73GKVy2tYII05Zq5TMfDRMtN6i4bzLzNsJ7PEOuSJVuZgsLusuh XQRe2LRKrOaYEGZE6j71Yicp2+vkydA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686823591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WH1mOxnVXww19hxVqg6mJd5pC69heDnq/9XJzwgco1Q=; b=25u5d22tQ+jkIbkpeLqw76KNimb7pmyI6sWsCH5usLZaYGB9qteRVdzibS76e8yV4iAkDr nP2/kFLITUyObCBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CE34513A47; Thu, 15 Jun 2023 10:06:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ivIFMqfiimRNZgAAMHmgww (envelope-from ); Thu, 15 Jun 2023 10:06:31 +0000 Message-ID: <457be842-a975-9ab5-8aca-02141e99b6a0@suse.de> Date: Thu, 15 Jun 2023 12:06:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 2/2] nvme-fcloop: queue work items correctly Content-Language: en-US To: Daniel Wagner , linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Chaitanya Kulkarni , Shin'ichiro Kawasaki , Sagi Grimberg , James Smart References: <20230615094356.14878-1-dwagner@suse.de> <20230615094356.14878-3-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20230615094356.14878-3-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/15/23 11:43, Daniel Wagner wrote: > The arguments passed to list_add_tail are reversed. The new element is > first argument and the queue/list is the second one. > > Fixes: 38803fcffb5b ("nvme-fcloop: fix deallocation of working context") > Fixes: 437c0b824dbd ("nvme-fcloop: add target to host LS request support") > > Cc: James Smart > Signed-off-by: Daniel Wagner > --- > drivers/nvme/target/fcloop.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes