From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B37B2C4363C for ; Sun, 4 Oct 2020 13:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EC49206B5 for ; Sun, 4 Oct 2020 13:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbgJDNZA (ORCPT ); Sun, 4 Oct 2020 09:25:00 -0400 Received: from mslow2.mail.gandi.net ([217.70.178.242]:37736 "EHLO mslow2.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726113AbgJDNY7 (ORCPT ); Sun, 4 Oct 2020 09:24:59 -0400 Received: from relay11.mail.gandi.net (unknown [217.70.178.231]) by mslow2.mail.gandi.net (Postfix) with ESMTP id B88AB3A2565; Sun, 4 Oct 2020 13:23:44 +0000 (UTC) Received: from [192.168.0.28] (lns-bzn-39-82-255-60-242.adsl.proxad.net [82.255.60.242]) (Authenticated sender: hadess@hadess.net) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 57B03100002; Sun, 4 Oct 2020 13:23:18 +0000 (UTC) Message-ID: <457d516913ebf5b73d2b250516f3d9e9c59fdfe9.camel@hadess.net> Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating whitelist" From: Bastien Nocera To: Greg Kroah-Hartman Cc: Marcel Holtmann , Johan Hedberg , Sathish Narsimman , "David S. Miller" , Jakub Kicinski , linux-bluetooth , "open list:NETWORKING [GENERAL]" , linux-kernel@vger.kernel.org Date: Sun, 04 Oct 2020 15:23:18 +0200 In-Reply-To: <20201004131844.GA185109@kroah.com> References: <20201003135449.GA2691@kroah.com> <20201003160713.GA1512229@kroah.com> <20201004105124.GA2429@kroah.com> <04e0af8618f95a4483f5a72ba90d4f8b1d9094bd.camel@hadess.net> <20201004131844.GA185109@kroah.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.0 (3.38.0-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote: > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote: > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote: > > > > Hi Greg, > > > > > > > > > > > This reverts commit > > > > > > > 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2 > > > > > > > as it > > > > > > > breaks all bluetooth connections on my machine. > > > > > > > > > > > > > > Cc: Marcel Holtmann > > > > > > > Cc: Sathish Narsimman > > > > > > > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list > > > > > > > when > > > > > > > updating whitelist") > > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > > > > > > > > > --- > > > > > > > net/bluetooth/hci_request.c | 41 ++---------------------- > > > > > > > ---- > > > > > > > --------- > > > > > > > 1 file changed, 2 insertions(+), 39 deletions(-) > > > > > > > > > > > > > > This has been bugging me for since 5.9-rc1, when all > > > > > > > bluetooth devices > > > > > > > stopped working on my desktop system.  I finally got the > > > > > > > time > > > > > > > to do > > > > > > > bisection today, and it came down to this patch.  > > > > > > > Reverting > > > > > > > it on top of > > > > > > > 5.9-rc7 restored bluetooth devices and now my input > > > > > > > devices > > > > > > > properly > > > > > > > work. > > > > > > > > > > > > > > As it's almost 5.9-final, any chance this can be merged > > > > > > > now > > > > > > > to fix the > > > > > > > issue? > > > > > > > > > > > > can you be specific what breaks since our guys and I also > > > > > > think > > > > > > the > > > > > > ChromeOS guys have been testing these series of patches > > > > > > heavily. > > > > > > > > > > My bluetooth trackball does not connect at all.  With this > > > > > reverted, it > > > > > all "just works". > > > > > > > > > > Same I think for a Bluetooth headset, can check that again if > > > > > you > > > > > really > > > > > need me to, but the trackball is reliable here. > > > > > > > > > > > When you run btmon does it indicate any errors? > > > > > > > > > > How do I run it and where are the errors displayed? > > > > > > > > you can do btmon -w trace.log and just let it run like tcdpump. > > > > > > Ok, attached. > > > > > > The device is not connecting, and then I open the gnome bluetooth > > > dialog > > > and it scans for devices in the area, but does not connect to my > > > existing devices at all. > > > > > > Any ideas? > > > > Use bluetoothctl instead, the Bluetooth Settings from GNOME also > > run a > > discovery the whole time the panel is opened, and this breaks a > > fair > > number of poor quality adapters. This is worked-around in the most > > recent version, but using bluetoothctl is a better debugging option > > in > > all cases. > > Ok, but how do I use that tool?  How do I shut down the gnome > bluetooth > stuff? You close the settings window... > I need newbie steps here please for what to run and what to show you. bluetoothctl connect "bluetooth address" eg. bluetoothctl connect "12:34:56:78:90"