From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF24C433FE for ; Sun, 6 Dec 2020 16:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D1B52313E for ; Sun, 6 Dec 2020 16:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727440AbgLFQcx (ORCPT ); Sun, 6 Dec 2020 11:32:53 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:23155 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726948AbgLFQcw (ORCPT ); Sun, 6 Dec 2020 11:32:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607272285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CMF+CoVSS643Fc17KXhh3rGOJ/yHoZk4DoSGgm33ivA=; b=bxhG7CFMs5KdaS6D9qhnwD5Zv8nlND6o3W9XDMqgnoVyfkkPMJY7qXH2/MO9551nhdLetn z+LFBx3p8PXnFhhQN8TYT39//Ejb0yRzSkTXJSxLKkpqSNv0kPrEjNypsPHqUrNTXR8KiJ mBRi9LToYztnxskIaOc87EW+/52IKTo= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-458-v4vRW0svOS-cVlCLHC-W0w-1; Sun, 06 Dec 2020 11:31:22 -0500 X-MC-Unique: v4vRW0svOS-cVlCLHC-W0w-1 Received: by mail-qt1-f200.google.com with SMTP id z8so9054855qti.17 for ; Sun, 06 Dec 2020 08:31:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CMF+CoVSS643Fc17KXhh3rGOJ/yHoZk4DoSGgm33ivA=; b=T+ES0XrO+EXz7NSdv/0e8PrtKZqj48KWxqxERrQYTm1QMJnxD3MftT9PrQh8/kT5ko JceKeaBSkJTwPVE4fy1wiDsVqjySwz/jZLW1iNYa0gHqTPz6e72gnp2N/dQK+aol5rU3 DDyfIUA1d9T2FrHrQCKYQSvk0jrmMX0k/92vcVb8RDlcdpgO7HBO7WPneFuMDjldXKyj q6FzH1oWtJRH+BOXFhXceAva1pzGL+360h5h2/Tb5ip4h4QR6Hyonpga0d3v+fpggEW5 Vk0YB+l0JyFhwAAIeZGoxqmRkR7Z0pju9HMwHhwNLz2dqMGIXRnaK/s0S9Ww9S/nu+l8 qPvQ== X-Gm-Message-State: AOAM531Q/ZJz6EqCUrX8K60Dnmb/DpKNKl2nKvQ1QtXDHZZmFoFdGL5r /vS+4DkDNuM/drLuYTJrpVKZHcovS/28EEJ0f+qiRJ5nHMcRxS3L2X9ZruJcVCUKZtXoIGUYaFb qtUDzcVECtW/167sgJeEpDwIq X-Received: by 2002:ac8:bc7:: with SMTP id p7mr19756347qti.91.1607272282315; Sun, 06 Dec 2020 08:31:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRjzb3ETLrTBxkdDegvZLQf2Fn3hwR6fns803HxOqkK73W88fwCB9NZ01f3lD4Rew17E3XSQ== X-Received: by 2002:ac8:bc7:: with SMTP id p7mr19756331qti.91.1607272282050; Sun, 06 Dec 2020 08:31:22 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id l10sm10618585qti.37.2020.12.06.08.31.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 08:31:21 -0800 (PST) Subject: Re: [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview To: Sonal Santan , linux-kernel@vger.kernel.org Cc: Sonal Santan , linux-fpga@vger.kernel.org, maxz@xilinx.com, lizhih@xilinx.com, michal.simek@xilinx.com, stefanos@xilinx.com, devicetree@vger.kernel.org References: <20201129000040.24777-1-sonals@xilinx.com> From: Tom Rix Message-ID: <457f9fad-f108-26de-3cdb-b367a4782ef2@redhat.com> Date: Sun, 6 Dec 2020 08:31:19 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201129000040.24777-1-sonals@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/20 4:00 PM, Sonal Santan wrote: > Hello, > > This patch series adds management physical function driver for Xilinx Alveo PCIe > accelerator cards, https://www.xilinx.com/products/boards-and-kits/alveo.html > This driver is part of Xilinx Runtime (XRT) open source stack. A few general things. Use scripts/get_maintainer.pl to find who a patch should go to, i should have been on the cc line. Each patch should at a minimum pass scripts/checkpatch.pl, none do. Looking broadly at the files, there are competing names xrt or alveo. It seems like xrt is the dfl equivalent, so maybe drivers/fpga/alveo should be drivers/fpga/xrt There are a lot of files with unnecessary prefixes ex/ fpga/alveo/include/xrt-ucs.h could just be fpga/alveo/include/ucs.h individual subdev's may not belong in the fpga subsystem. I think it would be better to submit these one at a time as is done for dfl. So this will not block getting the basics done, in the next revision, can you leave the subdev's out ?   Because of the checkpatch.pl failures, I will wait for the next revision. Tom