From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8700A21CA13 for ; Thu, 9 Jan 2025 14:40:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736433610; cv=none; b=T9nUovuxMYciAeGIJgRqHYItyY+8/uiJRM6IZsmP0U93N7taPgkRiCgz0kb49QwgUYWOw9nyHpjBdx9Si3/Unm5R76FmoWAeD9bcUSgiHkmKrEF/KmYlk4HSoGPdDCWN0YCFMy1fBC1mVvhlPt5w8/y8EDSGwbSdrwFGVJRG0xE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736433610; c=relaxed/simple; bh=57FTeGrbj4/podiX7S/gMB+vwImrGIspTKSt9+wbhLI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WliYtCpXt8fgkuParMIqKz17S1zhsBmX32UBuO4UvXtJ1VS91cN8PfTzpWg/duAyjV3EUT1UJGc3EbcqZr+wVbpCgUibwsSm54CsAOkUehMkFBBMN1gXYCDcWtO3HWCAic8Uv/dB5Tvpi7zfmnqTJQFHHsXvaKaYkBkFv5LgyCE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hX9q8xYC; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hX9q8xYC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736433607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=FPLN3ol35vhvCJyQOqbvMWAeS4G+dQ6ohScaUF6a8JM=; b=hX9q8xYCdFUrsU/KYgra67yL9Fu3Xq9gU5vOaHJquxJKbxPaqQQjhlUSRczHtJmptHJvA/ 39Ua/egXjTn4J5Dlz+yfbOLdEc43rQNOo1ObC6axdvBteOKEezfly4OxLUkavuj2O+lMKa I/M3gDo5bmwm0Rmz5+94tc+fHI2yaa4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-gdWgWYCyOfm880LjBwzmCA-1; Thu, 09 Jan 2025 09:40:06 -0500 X-MC-Unique: gdWgWYCyOfm880LjBwzmCA-1 X-Mimecast-MFC-AGG-ID: gdWgWYCyOfm880LjBwzmCA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4359206e1e4so8329025e9.2 for ; Thu, 09 Jan 2025 06:40:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736433605; x=1737038405; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=FPLN3ol35vhvCJyQOqbvMWAeS4G+dQ6ohScaUF6a8JM=; b=utnTBRHP73n6lClnb8HzPqRpDzRC9T255xHA5cKv0OU+l2j4i9pbNFQgZo7cgdxgDJ MJeNSKxHXMUxndoxg8pRHLUkM37ik0ozlP6/8ATZD8dAqTtGk6dHkiHS8IlwVb3iwNeZ mH1oPwQVh6sg+Zh9mDAdGUgOZAu7zrbQ8zGBDDyoZT3VS45n3KA9atAs5avk3Um+u6s3 2BfRzezbSMuLucwSAlKsGMwrwKCpUrNPr8RmhYhhTJVJncjxdq1K3ROHNt+nMb9XHExy 2SNDV3mIbuJIdnvy9hBNpJKFopJYSycqNrO7FZk4VJrVqgYF/TvVYyD30DimuRKyPrBo kn4g== X-Forwarded-Encrypted: i=1; AJvYcCVsB07ONiP4tmWEcfewtRh4oXBVZPGEjOTCIiLiyQrWMYimQu3un8iv1h3g6lhqC7beJhb8kVC116FyxCw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxju3/uwCjBR2ZCDau/ANOemFhKhFMqEJz6hUa7SUkSFIVeHYXu znvJiowFJP+lPFQIft1HjyMroYTytdm0aphdHOy7y5fgZ/X96bw9WNIzby7E8Tc3lzwyOSuE9a0 VGTX1leX3eQdiSdS5ihfZW9XlimKpFpMeLQTTlx90nCljKzdijwI2tmQz9YWu7v8QGMBqHQ== X-Gm-Gg: ASbGncu2aDt65NuQcYj9teCgZ7+DwET9YdZtg0K7QsiEaI9knGGCaHMBcvb/xliqGtX 9Y5uWC+USpAcD9cxRSTM5bZpZ4iA7IJoRU2dABT749hN0Ylob0NX76sJlRSP8aOxwdXB9cxi/Es Fdu4EB3etsMOp308WwypZ9106nNPnV4PVo1op7NOM5fgXNhwHAc8BP86qGn8f97sWJKSYJdrVUT 1seRQVkWgUHIikQUhj/yU/o0yrFVCahmCgxAijEIs0FClqT4xeeqIo5GzpE0ZmIm/qNmFUsC6jR MgMKStqDlgs4JBZGrkM/E/N4diO3cdfv2kJrPiUmsRvV8Cx5A/v3yT+zlumecHxPaQnm6iONiRw 2UaIpHg== X-Received: by 2002:a05:600c:3b91:b0:434:f131:1e71 with SMTP id 5b1f17b1804b1-436e26970b1mr67650355e9.8.1736433604849; Thu, 09 Jan 2025 06:40:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHAcBZv8ZD+8HSPY2vdK6lwpEczdASP0XeGpqUdSwNYYiIqy74BD+BNR4hBS4NHD7Z0xqk44w== X-Received: by 2002:a05:600c:3b91:b0:434:f131:1e71 with SMTP id 5b1f17b1804b1-436e26970b1mr67649995e9.8.1736433604380; Thu, 09 Jan 2025 06:40:04 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:800:d383:9661:5934:2cfa? (p200300cbc72e0800d383966159342cfa.dip0.t-ipconnect.de. [2003:cb:c72e:800:d383:9661:5934:2cfa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9e37d7fsm22808905e9.32.2025.01.09.06.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jan 2025 06:40:03 -0800 (PST) Message-ID: <45806c9f-b9cc-4917-ae93-98cabf08bf2e@redhat.com> Date: Thu, 9 Jan 2025 15:40:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory.c: Add return NUMA_NO_NODE in numa_migrate_check() when folio_nid() and numa_node_id() are the same. To: Donet Tom , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Ritesh Harjani , Baolin Wang , "Aneesh Kumar K . V" , Matthew Wilcox , Zi Yan , Muchun Song References: <20250109064632.898260-1-donettom@linux.ibm.com> <1a384b0d-0548-4340-a664-dffe8fe4cbdc@linux.ibm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1a384b0d-0548-4340-a664-dffe8fe4cbdc@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 09.01.25 15:29, Donet Tom wrote: > > On 1/9/25 18:43, David Hildenbrand wrote: >> On 09.01.25 07:46, Donet Tom wrote: >>> If the folio_nid() and numa_node_id() are the same, it indicates >>> that the folio is already on the same node as the process. In >>> this case, there's no need to migrate the pages. >>> >>> This patch adds return NUMA_NO_NODE in numa_migrate_check() when >>> the folio_nid() and numa_node_id() match, preventing the function >>> from executing the remaining code unnecessarily. >>> >>> Signed-off-by: Donet Tom >>> --- >>>   mm/memory.c | 1 + >>>   1 file changed, 1 insertion(+) >>> >>> diff --git a/mm/memory.c b/mm/memory.c >>> index 398c031be9ba..dfd89ff7f639 100644 >>> --- a/mm/memory.c >>> +++ b/mm/memory.c >>> @@ -5509,6 +5509,7 @@ int numa_migrate_check(struct folio *folio, >>> struct vm_fault *vmf, >>>       if (folio_nid(folio) == numa_node_id()) { >>>           count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); >>>           *flags |= TNF_FAULT_LOCAL; >>> +        return NUMA_NO_NODE; >> >> Doesn't this just mean that it is a local fault, but not necessarily >> that we don't want to migrate that folio? >> >> mpol_misplaced states: "check whether current folio node is valid in >> policy" >> >> Could we have a different policy set that does not indicate the local >> node as the target node? >> >> Note how mpol_misplaced() obtains the target node to the do >> >> >> int curnid = folio_nid(folio); >> ... >> int polnid = NUMA_NO_NODE; >> int ret = NUMA_NO_NODE >> >> ... detect polnid >> >> if (curnid != polnid) >>     ret = polnid; >> ... >> return ret; >> >> >> So mpol_misplaced() will return "NUMA_NO_NODE" if already on the >> correct target node. > > Thank you, David. I understood my patch is wrong. > > I have a small question: Page access latency is lower when the folio is > on the same NUMA > node as the process. However, if the policy node is set to a different > NUMA node and the > MPOL_F_MORON flag is not set, we migrate the page to the policy node, > thereby increasing > access latency.  Could this have an impact on performance? What benefits > do we gain from this? I have to admit, that I have not much idea about the details here (especially, how MORON comes into play here), so what I write below might be wrong :) Consider the following example: making use of memory on CPU-less NUMA nodes (e.g., CXL, NVDIMM, whatsoever). In that case, access latency might be higher, but maybe that's exactly what someone wants to achieve here (e.g., placing cold data). Maybe page demotion can come into play here as well. But the MPOL_F_MORON is slightly confusing me. -- Cheers, David / dhildenb