From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793109422; b=vtrfcJVx8Dhx3Bl4MfBiL1n/TzLpvTf9ikg8ChW780yNUDglIvZ5krrABmsBAnho63VL SGFitys9W7OZf/CQaH/VAPK2gt0Xdqb+v4mm0GwNhfp9pB639VjlruBFhGLc2lf22Oluq lUWeaTAgNVSfYeaCT8/UrlXSslcQM13BRbrRaL0gyWxaAKK485Q+AhhsOXCIlKdg0OrYW bWpfrGxr5lawZ6iPuCGB4rmkcWGqm87eHOqFUdIeZD09QwS5JfkmKN/NWUS3YVGbPJ3JM OmM3VVs6lhJH16AkqV4se+/kmN+MXJHjMKIf/Vyg7BDKR5kbgRV6k9nboUnLVdaIIew== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793109422; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=eGxUCtRGlKme+ehFGQNa/Gef806lpWSevfACq5r6dV8=; b=3TDw477qhoaWOgfOQAT/IdOCMyy31x4vkMJI1gru2BkgJqgmm33ohO8PYQHu/k29iNY0 2wTGfQUUy/5ta0zEE1DN454F1ojxVzFd8jTGippjPIG4jn4VYZuxJwfSHb1q5V4RtqcRb HHCUvAZeSZ9xV9YMBJ/Fo40M7nS0eupC/z+UUl5lMh679Gf74LqKyDhPOlXV8iF6DpUdg Ez2ed6aKWe4Vel3gawEgMAgMSIaUzJv5/xSls9EahsScarTguWwT8oPqXp0hcngerw538 UY3kvOQk6/gQ5YDC+YjWpkk1agcg2GTNcznVOc5SvPW0JreoC49sZAUyMUKs0hKj+pw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=SBzDW7w9; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=el72giF+; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC4E6606A31B for ; Tue, 27 Oct 2026 13:57:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org EC4E6606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=SBzDW7w9; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=el72giF+ Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69RDoN7W2359172 for ; Tue, 27 Oct 2026 13:57:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eGxUCtRGlKme+ehFGQNa/Gef806lpWSevfACq5r6dV8=; b=SBzDW7w9EPZSc9IB 65tzcXMcjsf2Y6rKkD3TdMnxWYF+J6N3keLNG+NmBNiu/oY/dmhWQCY1GjwjFZCo KbRx0abceszlduC5i32dgjkQGUo6JQNEiqOmtpkSviCB78WdDnJesmeYeQ+dOvva sdXya2OhgNTXkgo0MiPPXmlZH70cjrSOMW67w8MqNW/GjDVbB2ZDI/eyxWMjIxy/ WKJKi3jShDyC+yQ6wiXw3W5AO/mK94zUcBLF5lHT5P4xkfPkm5YVS6I/DaAIDWjY 8qYgz4EHz6Y8SrVWXq3YSVyY9UOdS0DDf/izbkAKpuCHeyplpb+l9enEah9Dwp2D 4WtHlg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hjfavu65u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Oct 2026 13:57:00 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-9196b477c4cso24736996d6.0 for ; Tue, 27 Oct 2026 06:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1793109420; x=1793714220; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eGxUCtRGlKme+ehFGQNa/Gef806lpWSevfACq5r6dV8=; b=el72giF+gGAKLL7v3838X0LfcF7z93zg9MawtBE9dkPpw9mu2Gf340godP48k5y2O9 v9SSAfJThBWNR9aGLYnYJJE7K7WpolzdzOC7n/0DJDwGwUlJ3f5rdhRrcpOcdsaJaBNd jKHOsiI8dViFZp+QNa0rS3pbU7moPuxj9Qmqm31xUjDpB1uIQWrRA/oigsUhUZofUsNQ awYioGuii+TU4niggEpPbwkO8ABunuu21zPRwigvQNx3sCML34rrApKj0DufV2T0OeE5 8DJH5YRccLqktXHmlKdGjtHIMu1BSex1DdShIJ/4IXRL6xbhhxN6D7JWQgA3QZ/z62Zl WixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793109420; x=1793714220; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eGxUCtRGlKme+ehFGQNa/Gef806lpWSevfACq5r6dV8=; b=o5mJ9tg5p9yOAkE3mK6Q89EszMcouINr0omDmbRTy69GfUcEDSb9s6srxLzJpZiws0 s1sYJtND1oFLNVZOIR0Vnu/Uxs7XKP4ZNPzkLjorvd7fgqziKJX7NQpSn80C8soFFQcz +FbRxdemU7grDfpKqA5k74mOmxaXidla0JYakxaXLXQ0q5+knFw4L4n0efS+fVoyvRbA pLt5b+JTYEKDyei7fx148qTDQ9iemFBfR8cCD1SxLcsuaxaIg7CNxL/8ZSvtIDNG436R NjA+vHlV84DR37VPAg7acVU0A38oa+gLpEj9aE4KtMcKmmB2jYJI94XnGAptEz0XnIIk wn4g== X-Forwarded-Encrypted: i=1; AKwUvBzgk+ERXfPQirTZMOzczkuPGQVKxMkMsziWqPNPq28GmLSH01MId5uZBvxOlifF0C9QK4CITYtzF8cT02U=@vger.kernel.org X-Gm-Message-State: AFq9FYIIStrLalgqERjCieT6LWC01GeSheVBRQeZ0pVShji82hLBqJ21 v42ULNqaV+YW9ICYonfo05qW5vKCUojfpcPzJGAtiW47VyxGgjq/AeRaDzLEPlUOI8aIHMvdwZy bd/oTN64HAN5TZ5BX2DJGxKCycZct688l8P1PyyqieahPsbrNZAjs9u8AAXGVthzLzRM= X-Gm-Gg: AYBFou2wJOrCfvVAAawPToQJUM8pLllSivr8BgSxIBUfaiW4RvrmPaKte/FRNa7EWbR 4KO++Wc0YEBr08Ji6jv6jWNGGTaLmwxRabxCGP0d9rpgfsIfAjbhhFOpzistwHHGii6Df7fC1ck TI/cySJb+r6jUGIcIZBMWV20TVs+Gqq35fn8AhKN3f2P/oEQx6oYqPpddLyj1gP2Z4kQj1lLD3a yfkRQt2M7c1M1VfhI3gC9XgHnZZ2ElI00RJfOHM/xZde3PzJ1B+f6W6b6Sm8sDHj6CNhbGmGSX4 lVPPqjV1PjVtCUe7LIQT6eCTMlvDO3COrYylf7Td/hwgE36u3e3SnThzAIeOESVcPb2yVAILxMo MRwToQxatuBBqTIMfbdwLHtzR+w== X-Received: by 2002:a05:6214:2622:b0:919:5896:e93b with SMTP id 6a1803df08f44-91c6d30d225mr47556456d6.19.1793109419833; Tue, 27 Oct 2026 06:56:59 -0700 (PDT) X-Received: by 2002:a05:6214:2622:b0:919:5896:e93b with SMTP id 6a1803df08f44-91c6d30d225mr47555996d6.19.1793109419252; Tue, 27 Oct 2026 06:56:59 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 6a1803df08f44-91c6158e404sm58349196d6.10.2026.10.27.06.56.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2026 06:56:58 -0700 (PDT) Message-ID: <45815874-941c-4e63-85ba-e93fca6b2b70@oss.qualcomm.com> Date: Tue, 27 Oct 2026 13:56:56 +0000 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: qcom: qdsp6: fix device_node leak when parsing "iommus" phandle To: Selby Mashiki , Srinivas Kandagatla , Liam Girdwood , Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261025190340.449613-1-mashikiselby@gmail.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20261025190340.449613-1-mashikiselby@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: MMHlUlBk676NcObqFURzpT1F4usQ23Wo X-Proofpoint-Spam-Info: AW1haW4tMjYxMDI3MDA1NSBTYWx0ZWRfX4cpLuIhlJHjA cKiGGfps6eBA1rtDUCKaAu8yA3pQgHRntltm9bYUZJ9t/VnXm+Jeooq5HaDrI4pQ3/r2rSPSZAo pncAFi1XkQmFgzah3AMNheCYedxWalQ= X-Authority-Analysis: v=2.4 cv=EIeTQFZC c=1 sm=1 tr=0 ts=6ae0adac cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=wKGBcDPARhIGGqfS-jYA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: MMHlUlBk676NcObqFURzpT1F4usQ23Wo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDI3MDA1NSBTYWx0ZWRfX3K71zf7s0lfA VxSjBOugCQ7LQ+90ZrEPDsT9Dk/3wRv4qlmwvzwi/XEwTqyBtm1zlgtqtqtE1G/0K77iqzFJ2xE QrezH/XMXUK0hc9/ux942g6gBV7I3BU1VEuy/fReDmWITadIvqSQcrfx1bk7H/pKBWpPsCU+RhT mVrsXCmBS9gzPJPQbSVbErpy+dwGtLWoVcVbAw/pS9hJXaVdx6uCVnssrJyCwr35FrH4g/RLyMj uohb2tWOplz8u7+6Csczs7k+Rsupr0FVdBCBw48iEcrhRcujpFjiCviDdEoPTRarZR+nHq+Ycht 77tOQNhtg0ozlIbLpuj3yc2kJC0SGeBdNBPOhyMHZwI6P/HqSJVlfk636sDxWLAskAOIz4JwD9c bw2XMI5YGpCL4swqyNRTM+eTzaaTKbn+D7lKK6iPzQKmiFiJSw8hg9k4rFR6fccWhaNKVRc3n9N QirKyhvkQYRmcMxQ3hg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-10-27_03,2026-10-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 suspectscore=0 spamscore=0 phishscore=0 bulkscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610270055 On 10/25/26 7:03 PM, Selby Mashiki wrote: > q6asm_dai_probe(), q6apm_dai_probe(), and q6usb_component_probe() call > of_parse_phandle_with_fixed_args() to parse the "iommus" property and > extract the stream ID from args.args[0], but never release the reference > acquired on args.np. > > Call of_node_put(args.np) after reading args.args[0] in all three probe > functions. > > Fixes: 2a9e92d371db ("ASoC: qdsp6: q6asm: Add q6asm dai driver") > Fixes: 9b4fe0f1cd79 ("ASoC: qdsp6: audioreach: add q6apm-dai support") > Fixes: 72b0b8b29980 ("ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6") > Signed-off-by: Selby Mashiki > --- Thanks for the patch, LGTM Reviewed-by: Srinivas Kandagatla --srini > sound/soc/qcom/qdsp6/q6apm-dai.c | 6 ++++-- > sound/soc/qcom/qdsp6/q6asm-dai.c | 6 ++++-- > sound/soc/qcom/qdsp6/q6usb.c | 4 +++- > 3 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c > index bf1f872a0..49bd0582d 100644 > --- a/sound/soc/qcom/qdsp6/q6apm-dai.c > +++ b/sound/soc/qcom/qdsp6/q6apm-dai.c > @@ -1030,10 +1030,12 @@ static int q6apm_dai_probe(struct platform_device *pdev) > return -ENOMEM; > > rc = of_parse_phandle_with_fixed_args(node, "iommus", 1, 0, &args); > - if (rc < 0) > + if (rc < 0) { > pdata->sid = -1; > - else > + } else { > pdata->sid = args.args[0] & SID_MASK_DEFAULT; > + of_node_put(args.np); > + } > > dev_set_drvdata(dev, pdata); > > diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c > index 4f09fdd40..f09856ee4 100644 > --- a/sound/soc/qcom/qdsp6/q6asm-dai.c > +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c > @@ -1309,10 +1309,12 @@ static int q6asm_dai_probe(struct platform_device *pdev) > return -ENOMEM; > > rc = of_parse_phandle_with_fixed_args(node, "iommus", 1, 0, &args); > - if (rc < 0) > + if (rc < 0) { > pdata->sid = -1; > - else > + } else { > pdata->sid = args.args[0] & SID_MASK_DEFAULT; > + of_node_put(args.np); > + } > > dev_set_drvdata(dev, pdata); > > diff --git a/sound/soc/qcom/qdsp6/q6usb.c b/sound/soc/qcom/qdsp6/q6usb.c > index 6381b289c..5888bc41a 100644 > --- a/sound/soc/qcom/qdsp6/q6usb.c > +++ b/sound/soc/qcom/qdsp6/q6usb.c > @@ -382,8 +382,10 @@ static int q6usb_dai_dev_probe(struct platform_device *pdev) > } > > ret = of_parse_phandle_with_fixed_args(node, "iommus", 1, 0, &args); > - if (!ret) > + if (!ret) { > data->priv.sid = args.args[0] & Q6_USB_SID_MASK; > + of_node_put(args.np); > + } > > ret = devm_mutex_init(dev, &data->mutex); > if (ret < 0)