From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4BB02FFDFB for ; Tue, 18 Nov 2025 20:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763498680; cv=none; b=fy6nVF5THwFieEWiH91JIroP7bIaBMWR+0IUQ5lG71G2Mg/LYleAQammPbDZFJpOd1UJxQKA9BccPb0hGTvh8iKKz3T/nqxw9lmqfGz5mfYvUXHuNMJVT5RUIhRZGY01U1uVUBQAzyNriGXaP1bSDlBehIFc2k9AEc2itlhUHLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763498680; c=relaxed/simple; bh=K9fDY6NMyJz2tMJaejTPM0fHnQQgqyXhWuXx9OSlsjU=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=DCZ5+fkqOHEB+6xfAqaUJAKHCMeYiYa8FlJLtKM6N9KMszlvkfc6RrlkYQyhkLKmsnZPIo5LZyI6orV2PdEISrD4zH5mU8ox86HkUMgwPWn53EfJH/WRVNoAGCm3bMYEFegP9Dl9D3d25XAHhv0v0Bm0kk4JTV6k31SlHk8AUmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KXbYeAe6; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KXbYeAe6" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7b9a98b751eso4490621b3a.1 for ; Tue, 18 Nov 2025 12:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763498677; x=1764103477; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K9fDY6NMyJz2tMJaejTPM0fHnQQgqyXhWuXx9OSlsjU=; b=KXbYeAe6WCoJtBDqjIw+zOxrbJCa2f78RId0at1ZpN4oMqgxO66bR903Ej+6UFXk6H lKMIvkOFDuNHIORkRzB7Z05Gm6a+1rur8QKDSWXWa/iWBNPYYjmKcB3OlYZOiE2tTPWu 332Lkf/XbPlaj+cRzVEQi7NRFaT0msCgGzs6WxhJ9br6rC7gRRPiQBVCfr1XpkvRRcxG o/TctE22/H+W+I0CJORLxJmQ6CI0zxP0+MsQEXXZQCE9ae7UkWZdPSb898CobPtD1/lb wTxzmVJwsfk8PpLENJZaEY+ssUgsL0v81xclrJgo/BAJocTqR0q7QuVPzfmHqOCuIi7h AmNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763498677; x=1764103477; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K9fDY6NMyJz2tMJaejTPM0fHnQQgqyXhWuXx9OSlsjU=; b=KF3Qq80gVY389IsUTwBlnfWHJdBTBDanxeMOewbD/YME49K7IukMO+J1VnThJH9tDe AphxsNDtXSsnUJF3vLYugH41J9uPdVIZc9r99p3OugPHeYakIrt0MR+xJrNR6b37MVE6 K5d4fL4+lLMcekM944EbpFPCibKazWGC6ueHv1/evK7FSSXaIFL+rjYm9oo1eyhBkxKm 62LNnnjpk7XmHgh41PVtsEusgDSqglB19QZALFaDyxy7ycurWUXjqtAZ+jP125eWF2vS hkuFY5spPRj/XtpryOsa3GcBwecM/bj+qUgLovowEg7wP1iI8FK1+SID2icXtTSXOFD5 8n1Q== X-Forwarded-Encrypted: i=1; AJvYcCVz9DJmkv9ZS2ar94qbjZj41a0F/XBzYzaeFTstKgek3yZIFFJ0aWRjlmFQ5hszgtpkaj6SLkZ4G5ngJ4o=@vger.kernel.org X-Gm-Message-State: AOJu0YzzikzfV7LenCjdK1krZwu9Fe5s1XX7uDtYs/GjL5glQP5Kpb0p 7jGwgerCotYQs/SfqNpPB6UrKuvT8ViGqPn2MWxSnHpqXMiTXJ1Za9Oc X-Gm-Gg: ASbGnctvzsH0P49RzAz3WrFLBRNBRClz0+JqD4Kq4zpZbmJKjFG6JZxcJSbwXvL8GE7 hVJdS9JfO8li/zTc3SJ6zS5YOx9OKlKNXKExNgdegjnrHMJwvB4RTlQRywSTbQfciuRldH2AT1F dSQr5901TUMCe4bZvfhx+t18mzVRPGeOq9SKIqGpzWG8/yYAaNpR8aH20du5EIwjYJM3xdxsUfG 8RLkve7DDIEUaR29f3B6WqGCT5vjRK63aUtMEIaRenBVQ/AQ/7acCi4kh06ZqISMWgx6O1OYkW1 8KJ91jn8IltyLC9KuI873VIHUbIhfwAZohAg0JmQ48xbQCJ61gQ2vRqBapH8Ah6CaC28daCT+QH H3QdcHnFrpiQYvdC5w5QTOIJhg7egFWOWqJzEeQ/ECkh8EPaS0MXx4W2aSZ0DmpnsCT0jAlzHP0 iP++mi0gew00NEY8tOfZSLXMZOzWU3iLZgG06DTHu7g1N83/gQyKURhm1y+EsTtHJRM5c3 X-Google-Smtp-Source: AGHT+IH6NXrQRTAgMf2HddEUXn+z5kCzkV+fHB+mI/O4pw1ibW1tSK7SJqGLrmjc/rmo/4swJL7fzQ== X-Received: by 2002:a05:7022:4414:b0:11b:c0db:a5ea with SMTP id a92af1059eb24-11bc0dba69fmr5632646c88.26.1763498676692; Tue, 18 Nov 2025 12:44:36 -0800 (PST) Received: from smtpclient.apple (c-24-5-244-16.hsd1.ca.comcast.net. [24.5.244.16]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2a49d9ead79sm79567854eec.1.2025.11.18.12.44.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Nov 2025 12:44:35 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.200.81.1.6\)) Subject: Re: [PATCH] scsi: qla2xxx: Fix improper freeing of purex item From: himanshu Madhani In-Reply-To: <20251113151246.762510-1-zilin@seu.edu.cn> Date: Tue, 18 Nov 2025 12:44:24 -0800 Cc: njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, "James.Bottomley@hansenpartnership.com" , martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn Content-Transfer-Encoding: quoted-printable Message-Id: <45878638-8A5A-46E0-9223-BDDAD0C89362@gmail.com> References: <20251113151246.762510-1-zilin@seu.edu.cn> To: Zilin Guan X-Mailer: Apple Mail (2.3864.200.81.1.6) > On Nov 13, 2025, at 7:12=E2=80=AFAM, Zilin Guan = wrote: >=20 > In qla2xxx_process_purls_iocb(), an item is allocated via > qla27xx_copy_multiple_pkt(), which internally calls > qla24xx_alloc_purex_item(). >=20 > The qla24xx_alloc_purex_item() function may return a pre-allocated = item > from a per-adapter pool for small allocations, instead of dynamically > allocating memory with kzalloc(). >=20 > An error handling path in qla2xxx_process_purls_iocb() incorrectly = uses > kfree() to release the item. If the item was from the pre-allocated = pool, > calling kfree() on it is a bug that can lead to memory corruption. >=20 > Fix this by using the correct deallocation function, > qla24xx_free_purex_item(), which properly handles both dynamically > allocated and pre-allocated items. >=20 > Fixes: 875386b988578 ("scsi: qla2xxx: Add Unsolicited LS Request and = Response Support for NVMe") > Signed-off-by: Zilin Guan > --- > drivers/scsi/qla2xxx/qla_nvme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/scsi/qla2xxx/qla_nvme.c = b/drivers/scsi/qla2xxx/qla_nvme.c > index 316594aa40cc..42eb65a62f1f 100644 > --- a/drivers/scsi/qla2xxx/qla_nvme.c > +++ b/drivers/scsi/qla2xxx/qla_nvme.c > @@ -1292,7 +1292,7 @@ void qla2xxx_process_purls_iocb(void **pkt, = struct rsp_que **rsp) > a.reason =3D FCNVME_RJT_RC_LOGIC; > a.explanation =3D FCNVME_RJT_EXP_NONE; > xmt_reject =3D true; > - kfree(item); > + qla24xx_free_purex_item(item); > goto out; > } >=20 > --=20 > 2.34.1 >=20 >=20 Looks Good.=20 Reviewed-by: Himanshu Madhani >=