From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013027.outbound.protection.outlook.com [40.93.196.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E06141D88A4 for ; Fri, 27 Mar 2026 16:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.27 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774628314; cv=fail; b=mOgnvClH/PCqgQNcFYOPmgClPaDppvmCVzx962+471azsSAGXYX1OVI4SOkfNq7B3+VwplPb42CzBI+J2evkvXD9LHzK+uPhxaYj/+UWVyu2JsHvmmDovpWwvGhV6b26kmEchRg567R14cX38IXH5nEKf3QFgNPfh+D6GbwTl1s= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774628314; c=relaxed/simple; bh=4Fl+pADMFQDjz2zMDhQ5NJDJQ/uAhwanShMMzSRoQmc=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=a0BlJcPMfGHi/IY6mzwf4bu8VCxdi36sBhaVBWisJ4jqeZku6W51YVxCLUFwDLxoai6miGvngBsmm4BrCPko/GFmxxInx5CVNHUW4r30gzYbC7h1EXcyROxlcnzJVQFI35Cqmwz/YnO4Q+87a8A57SUByztvkpunhCMgDgRVIcc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=3CslR3r+; arc=fail smtp.client-ip=40.93.196.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="3CslR3r+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ssbdpIuUdTJcou94dQdbSRAB0s/5w/iZHCoqoWygFIqlscMpVydHKnZv5gAvwvgDOkk7buBK5XorfaLbZCx7DYf7eJKJE8Z8eGEeVztg11POzjw7R15+/at4yJTlRJ3IN4o6eDAX38q6ECn08sfwzdXLqhiCaebx+vkB8BU4qcoCTP9+D/MBStfRZKnCDegmFjiylEPTZCax7zARILso+9dkZHRTQMQ75c8eNe2ITRUPhBFCmUSKfUMgQzIFvb3vPi3TktqGlwhXIgR703Rj8DlsogmZYw4acmD6CITofn5mkStRl+1xzBX5KF07xCoPv8TeFVMqwav9MhdWWuiIkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FWUmKViNDvKEQDjYDqQ8Ug/dQOfxPB2efHo9r+1djhU=; b=KaLPWM8CAn8f9h+/E5NXMRI3XGkVSsucxArxhMNgZOrzEA7GhlMEFndvnQljCn0SkGb5/zfXFW/XmK7auvrr6aWyeZEmevPlfbf5/sEYB/Z3gVpIjptxCmCSyvsfEejm6VauLzTs1RPYINw3oyzmRz8ni14ZVmi9mIhd0YyysixTMd/BwxtEcHUk0YsadU61d/FCvoVLBsa8yDmFd/Z8WVvZ9KoWycHILP6AnOsoAA9zr+5d8mxKmDsWmOSZewMe5g9x5qtC3z8A8HsYfngEV8pHguYGPpSt1+eOg7vD0TL+15GhUsAcejt7jaZsoc6WrhEfI45GLmf2raazTIKv+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FWUmKViNDvKEQDjYDqQ8Ug/dQOfxPB2efHo9r+1djhU=; b=3CslR3r+mpWd/bNThAa84SHT0qq/bF+DDDNPuvKaD1UH+wP+n9OJnWl7Wfz8KF17frqhBNbSwUFERpCMK7UPhRb0NxeZqOV5M0lYl1QKQv8Am//QlJrHb3ARGQEFYRnKwUWnRyUz5R2Wbe+TSQVZIFj6oc8QP4Cgt3VVEWI0LGk= Received: from SN7PR04CA0073.namprd04.prod.outlook.com (2603:10b6:806:121::18) by DS0PR12MB7947.namprd12.prod.outlook.com (2603:10b6:8:150::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.8; Fri, 27 Mar 2026 16:18:24 +0000 Received: from SN1PEPF00036F3F.namprd05.prod.outlook.com (2603:10b6:806:121:cafe::a1) by SN7PR04CA0073.outlook.office365.com (2603:10b6:806:121::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9745.22 via Frontend Transport; Fri, 27 Mar 2026 16:18:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by SN1PEPF00036F3F.mail.protection.outlook.com (10.167.248.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Fri, 27 Mar 2026 16:18:23 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 27 Mar 2026 11:18:21 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 27 Mar 2026 11:18:21 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Fri, 27 Mar 2026 11:18:18 -0500 Message-ID: <458b21f7-6640-450c-889c-d05c6b0d801e@amd.com> Date: Fri, 27 Mar 2026 21:48:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/fair: Use sched_energy_enabled() To: Vincent Guittot , , , , , , , , , References: <20260327132013.2800517-1-vincent.guittot@linaro.org> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260327132013.2800517-1-vincent.guittot@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F3F:EE_|DS0PR12MB7947:EE_ X-MS-Office365-Filtering-Correlation-Id: cca03ad1-6c4c-4468-eb35-08de8c1c785d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|82310400026|36860700016|56012099003|22082099003|18002099003|921020; X-Microsoft-Antispam-Message-Info: NfLx2CURK/pj4Pyh/XcujFMincJzDDBY8E0FCXFR7BqPD3c87omETL56uzaSUZNRBv4/njrx6TJIqtPQmsG3NGCE5i4JmRcFRFr160KVqPSnyag1dLCRP7PDUAlMG6pmwG6A0mrh6zin0APPA+BxqXxYOFonJDLBQPFU8/Q2N4ODc2zJ+v+nCQnnlmtJl0z+SaDCIjQqNGctOdmGtH3Y/e0LysWkk17xIjYvFcNV6BHoYPZ08whrgi1L34df/wyyUa4RmM30k6sA8wmCFfFD2M6UJM51uHUCsQPqYzsWWxmgM2N3U+986JJ3gqmPWRZtWtONCNUyS4zdkZu/weEBp2/pCzfuI/PL5XlzUQzdRMowlQHSWje/YKfF7T4u+FPlQE3k0kJzHLIgCN6S3sHZ4IeID32jVYQ9bBLNlKS/hCK62eO4xJSGY56Xp7ii4a0A2RyjKSmNSeWMSVmEnWB9VzZ7PjwlkOaxhPdEYq4MmmAeRHIreeUae4dKUoiVefNlYQFsyzxOVfzaaYJ8pk6jjAeJYQ7oD4kLSHQMrolqaonQ5USPHXTIItneBnuW3dTjPsHj7g1hotgJ9pdlpa7krzJKF9L81ZC7I4w0gHRoR95UfhBJm3Skbniw8h/fYYl13U+xt/c+lxQ8Fu407/cCwDk6u+8ECLvRzpQFmQJArhkAS1vS5vnE6XBL2NvdVYBhh9eG21rzQTTYjnK0lNxjtO4q8F9LL+7vS+O628YrIRP8gCFRPapuYk7TYfMjEVbAfWLcewwYy9YA5BDBI4m0Yqg92O3qbtcV4fO7Tjz+KWjcZEsjkRjVGmLr9QfiFeEO X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(82310400026)(36860700016)(56012099003)(22082099003)(18002099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Zacb5rmDoWF7BW+cVLvuclzdK3npatS15gBYJBJi6CU4jV0SJCXCSuMFi4+O2ZaXD3RiSWg1XPKNHZzPzLknCF+FpAqTezYjfOEHB3mmY7Murrq1CN7k0avk0/54XZwF3Cv3AKPUQGtx6chsFHqQ5YjRwNQM+WGFNA5j0Rmm3emanV738ACms/C1vpi+EYRVezp0LtvNUcfvj9nvj+U3GtmjtsHrBnvO93/6eIeeWkY2ShaYQaLtZ5i0P0S0sfWoPnT0Wc29ZRp/YWqVZ1IDhuTy6pYJ+aPu7z1EOhnRMgEsm4SZY+R5vo/ZTHJa0MZjxoMSh+iyLDftfP+1TozuJBpDD2jhrfE/Q0mP8Jfiv8LbtUTNs/7w/oyhvZUqPnslxWPSEgTlj+KFKWsyz2Z4lkMem6C2FIZ2TvYUE0GdH9h0IxMrd51J4wgklbSbosxh X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2026 16:18:23.8954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cca03ad1-6c4c-4468-eb35-08de8c1c785d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F3F.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7947 Hello Vincent, On 3/27/2026 6:50 PM, Vincent Guittot wrote: > Use helper sched_energy_enabled() everywhere we want to test if EAS is > enabled instead of mixing sched_energy_enabled() and direct call to > static_branch_unlikely(). > > No functional change > > Signed-off-by: Vincent Guittot Feel free to include: Reviewed-by: K Prateek Nayak Tested-by: K Prateek Nayak > --- > kernel/sched/topology.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 43150591914b..5847b83d9d55 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -273,7 +273,7 @@ void rebuild_sched_domains_energy(void) > static int sched_energy_aware_handler(const struct ctl_table *table, int write, > void *buffer, size_t *lenp, loff_t *ppos) > { > - int ret, state; > + int ret; > > if (write && !capable(CAP_SYS_ADMIN)) > return -EPERM; > @@ -289,8 +289,7 @@ static int sched_energy_aware_handler(const struct ctl_table *table, int write, > > ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); > if (!ret && write) { > - state = static_branch_unlikely(&sched_energy_present); > - if (state != sysctl_sched_energy_aware) > + if (sysctl_sched_energy_aware != sched_energy_enabled()) Quick tangential question: Since "sysctl_sched_energy_aware" is initialized to "1", if build_perf_domains() returns false at boot, sysctl_sched_energy_aware and sched_energy_enabled() will go out of sync and reading "/proc/sys/kernel/sched_energy_aware" will still show "1" despite EAS being disabled. Is that okay? Some sysctls like numa_balancing will show 0 if disabled (by user or due to lack of NUMA) reflecting the real state of system. Should sched_energy_aware do the same? > rebuild_sched_domains_energy(); > } > -- Thanks and Regards, Prateek