From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FE9269CE1 for ; Thu, 25 Dec 2025 02:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766630658; cv=none; b=KrylcWhINtWUOqmDQOn86Eky2CQWp+NKlLEVcyYtPM5mo5JHyKhtlHAzHSydl8gpziwmhyd633xZVWDSkZ3VF/5d3X7eSjhwUUXI6QA8ZQ7Gr9bfnxkWb8jrYlqN3TPtARvuefs1Y4+rOvwa/hAIF/AkQH910+HZtzFLJA/F0Zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766630658; c=relaxed/simple; bh=zS1KKOKOimDEO1kclG+LiZcn7RPLfxuDBOk9W6qZU/s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hKmPriVKUQzMesGeEdkudPLshrAD0GzP4SW7kuVH1j3M7l00ZnLQ9DGiunhVAvyUzmqvJiGw/gePlzZ8pTzCs/CIQuZuVpmJVXvhTc0hXQP/u6H9Tobfcd07lfusOy97D4IQjEwaPVPkE+OW1Py2WvwPGni2O0OEy3x66Pijx3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GSo9+3zi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bKchsVz6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GSo9+3zi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bKchsVz6" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BOMs5kS634940 for ; Thu, 25 Dec 2025 02:44:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Q1wb5xT+3SX74fD7XcHG6ZfgZRlhTQTgEASipYKevpc=; b=GSo9+3ziG69nWN3J PGYWDiUG4XC3VhmlIhFw7qQsaCaSSnq+GogB3MRRVFhpoDx8y+KXsrmq0ayG/MdU AfypdBGk2LQecm6wRbzrRJSoTbQncRDZWfKklKsa1nMs3nDiDJg2myMItgSlqPu6 jYPgk2WmtFWrlzIOtJqnArYyCDmxO5DnWBf43q3p17e5N5oZTXhZlE/sj7/j+LyV ctH3ZZ2HfuU2tiDjVaZuw9TVLDiNZYqIlwEU4LB/sOSbBWSndi6K6dMdAqpQ48wZ eSZgwg7SvEvrcftjGwO1yoC2CV8JShzKjiSvxA5iGS7nGr8IP3SKsaC/4cIiyJwN RPvjyA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b8kywgr01-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Dec 2025 02:44:15 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29f177f4d02so142429275ad.2 for ; Wed, 24 Dec 2025 18:44:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766630655; x=1767235455; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q1wb5xT+3SX74fD7XcHG6ZfgZRlhTQTgEASipYKevpc=; b=bKchsVz6Psi1yK8LGobpNgwyC/YtPwuXow2m2bAouE91bN/slUnTIOn2NPcy9zsJw+ uFAyS4YLEEpdq+SqBPO5x23SNSsgT28nKRzApDSRvdaWjoI6M/z8JfmRoDnb0LaTc8Wu eJajnPAfNk0b7HG7l/JgAX+rR9pPYjhUry1Vpsu40tYSDBO8efWcrQgXIBPoAF1H62S7 TDIdUjtUpVqVM6aA4BnQz0BxF2r+yc1hTVY8pY4bD/ynuOYjssn9unPRrfj7FMXRKpcA Wx+4lhRIYkCgt5yb5gfwm+21+hGod0rRkFcho5cyl+uOjAp2E0/O9dQjb1ZLaP1WsTli G8/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766630655; x=1767235455; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q1wb5xT+3SX74fD7XcHG6ZfgZRlhTQTgEASipYKevpc=; b=VZ890s66mHdcPiTaTqF05kvG+JT9GGpHe3ODDy+UoVJhAp1zfm8I7AeorSgfnQbVCI Z0glBTX5QWhOFa07H88SIoP27fx/zSOZalJuCKiXoTnIxvMCERTLfvHMo8sm2X465Au2 MUxWAsB2bqKMsrEGE+BAgMsam28EV4ev6bjYq9B2YATmtAw9dlDL7K1CJapnIFazGMIt YIsxFCA4W0uqw0lDgIBSk8ASNJ2aONlFUDWm6/P+7fT51DAm6JgTdhW7pB4LbBhibTm/ VTMerjALr8XEUeKbyTi1sYrTvMhue4TYGmzsvLbnVU6zLQ+HD6K0c7V6ThfyWljOXRQ3 rKfA== X-Gm-Message-State: AOJu0YxnUOvmRCriOSCUTCpQVxaUhY1x76vp1aqn8utoklST5zwN9O0q 6cSCTXIz75eU+6dECMKMYYf0fxTn4+4mNkJH2fXJZPgzqMES2xMJwBCswvhN+GhBOMx+s945PG6 Fr/F1/D5tjaDHL4fCwP4VMOtpk8OVSf2pTMR6is3TCuTrBjJ+tG7xc44lilr7MD2YmHg= X-Gm-Gg: AY/fxX4tYJ3hkon4nW3yH0quLkC5Mh75OXbmGQAAIurtrW6d9BtYRpCfwHnQcTpoFRD v7XZqBxSBRU+ZbArm0SaPr+VG8EMS2eU5rPMtC9GgWCyU+7TtFCn4RhSwzSHOqm2JVgAnbtoKDd CLKwzdfcG6i8G4eMVwHvhnaXhbo7iYTWpFgbSLPXXKJ0CeARl0J7uV7/F3KGvEnMUQLIr4PK2D5 hoehJt2klmNbwTjerVDSuJIvhxb5L67tCFoqHC3iKONm/spOWxoIqREsY4ueSru6cwTKEleu8hs 3r1ogFTvG/X7sVkpOQbShbUtGzklN65Mmab2fL8O+mIUSLD5Cay7GU7VqpdHKkaWP4OJ2opUNY2 X4MtF6zo5yiLhuYsScX7OWKG+I98RqtOuuOXQDV6MMWuVWo0QRvhTRHYqL5Dd/HquwI1ky+qbhK E= X-Received: by 2002:a17:903:3b86:b0:2a1:1f28:d7ee with SMTP id d9443c01a7336-2a2f293e0d0mr191947115ad.57.1766630654634; Wed, 24 Dec 2025 18:44:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IF3Kz2Egs+ye+uWCT6V6dCDuaQ2pGQyY+N+0McTP3jCXraZVMNAL2nLC2nrTjuFo6zvZiagfw== X-Received: by 2002:a17:903:3b86:b0:2a1:1f28:d7ee with SMTP id d9443c01a7336-2a2f293e0d0mr191946755ad.57.1766630654094; Wed, 24 Dec 2025 18:44:14 -0800 (PST) Received: from [10.133.33.250] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3c74490sm166275095ad.5.2025.12.24.18.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Dec 2025 18:44:13 -0800 (PST) Message-ID: <458b3404-ca67-43fe-8610-f33c875b2de1@oss.qualcomm.com> Date: Thu, 25 Dec 2025 10:44:07 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/7] qcom-tgu: Add TGU driver To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20251219065902.2296896-1-songwei.chai@oss.qualcomm.com> <20251219065902.2296896-3-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20251219065902.2296896-3-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI1MDAyMyBTYWx0ZWRfXwx06glbH7+lY r9QMJ2Taso3KfV8PAZnrE1pdCNxxIVR3UIfO4DeOOlwSdM6E8VXY0UTxmBc3poz+IU3oO46VxI1 cNmh4eb6947OQaYf/fiIpzmCy0a2Sp7MUPnDepclP7kKVuS7MyXku19i/Egz/4KAew+TOWRh4hP n59+Eahw9PIHfMtBOqZ1afbDBTyJpz8b/1YURajcJLD7x+cQ8u8KImAgB99NRpRbuZ5OY8992pJ ru1guht4NjP28qpZe4xWPcrTjMidBjQiRPrqODIqlOPIAjz6PKGtYoH3W7Qdex08/oskl9TpHrX InC3wtr907IpNMlL8vCUTmKY36SHGL/TJ9o2q8mDp7IpdX5+mSKQPbEXIE8E5Pv0pCduyrkhzFr 11JVp17JD6CBzEpUT3ZAx1gP6L/wU84ZnCS/IJToG5ca6dnIDqjdH0VrEbF32GAuzbIkJt7G1Oc xxrX14F9HOtqtnMKyYA== X-Proofpoint-GUID: 5QPfwy1ixCknFPhURYo7lMScMvlo_E2c X-Authority-Analysis: v=2.4 cv=MKVtWcZl c=1 sm=1 tr=0 ts=694ca4ff cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=RlaAdA2wXV2HMp-xn2gA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 5QPfwy1ixCknFPhURYo7lMScMvlo_E2c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_04,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512250023 On 12/19/2025 2:58 PM, Songwei Chai wrote: > Add driver to support device TGU (Trigger Generation Unit). > TGU is a Data Engine which can be utilized to sense a plurality of > signals and create a trigger into the CTI or generate interrupts to > processors. Add probe/enable/disable functions for tgu. > > Signed-off-by: Songwei Chai > --- > .../ABI/testing/sysfs-bus-amba-devices-tgu | 9 + > drivers/Makefile | 1 + > drivers/hwtracing/Kconfig | 2 + > drivers/hwtracing/qcom/Kconfig | 18 ++ > drivers/hwtracing/qcom/Makefile | 3 + > drivers/hwtracing/qcom/tgu.c | 178 ++++++++++++++++++ > drivers/hwtracing/qcom/tgu.h | 51 +++++ > 7 files changed, 262 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > create mode 100644 drivers/hwtracing/qcom/Kconfig > create mode 100644 drivers/hwtracing/qcom/Makefile > create mode 100644 drivers/hwtracing/qcom/tgu.c > create mode 100644 drivers/hwtracing/qcom/tgu.h > > diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > new file mode 100644 > index 000000000000..24dcdf1d70cc > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu > @@ -0,0 +1,9 @@ > +What: /sys/bus/amba/devices//enable_tgu > +Date: December 2025 > +KernelVersion 6.19 > +Contact: Jinlong Mao , Songwei Chai > +Description: > + (RW) Set/Get the enable/disable status of TGU > + Accepts only one of the 2 values - 0 or 1. > + 0 : disable TGU. > + 1 : enable TGU. > diff --git a/drivers/Makefile b/drivers/Makefile > index ccc05f1eae3e..9608a3debb1f 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -177,6 +177,7 @@ obj-$(CONFIG_RAS) += ras/ > obj-$(CONFIG_USB4) += thunderbolt/ > obj-$(CONFIG_CORESIGHT) += hwtracing/coresight/ > obj-y += hwtracing/intel_th/ > +obj-y += hwtracing/qcom/ > obj-$(CONFIG_STM) += hwtracing/stm/ > obj-$(CONFIG_HISI_PTT) += hwtracing/ptt/ > obj-y += android/ > diff --git a/drivers/hwtracing/Kconfig b/drivers/hwtracing/Kconfig > index 911ee977103c..8a640218eed8 100644 > --- a/drivers/hwtracing/Kconfig > +++ b/drivers/hwtracing/Kconfig > @@ -7,4 +7,6 @@ source "drivers/hwtracing/intel_th/Kconfig" > > source "drivers/hwtracing/ptt/Kconfig" > > +source "drivers/hwtracing/qcom/Kconfig" > + > endmenu > diff --git a/drivers/hwtracing/qcom/Kconfig b/drivers/hwtracing/qcom/Kconfig > new file mode 100644 > index 000000000000..d6f6d4b0f28e > --- /dev/null > +++ b/drivers/hwtracing/qcom/Kconfig > @@ -0,0 +1,18 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +# > +# QCOM specific hwtracing drivers > +# > +menu "Qualcomm specific hwtracing drivers" > + > +config QCOM_TGU > + tristate "QCOM Trigger Generation Unit driver" TGU is working as the helper device of the TPDM, can we say: select CORESIGHT_TPDM > + help > + This driver provides support for Trigger Generation Unit that is > + used to detect patterns or sequences on a given set of signals. > + TGU is used to monitor a particular bus within a given region to > + detect illegal transaction sequences or slave responses. It is also > + used to monitor a data stream to detect protocol violations and to > + provide a trigger point for centering data around a specific event > + within the trace data buffer. > + > +endmenu > diff --git a/drivers/hwtracing/qcom/Makefile b/drivers/hwtracing/qcom/Makefile > new file mode 100644 > index 000000000000..5a0a868c1ea0 > --- /dev/null > +++ b/drivers/hwtracing/qcom/Makefile > @@ -0,0 +1,3 @@ > +# SPDX-License-Identifier: GPL-2.0 > + > +obj-$(CONFIG_QCOM_TGU) += tgu.o > diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c > new file mode 100644 > index 000000000000..dbd1acbd2fa5 > --- /dev/null > +++ b/drivers/hwtracing/qcom/tgu.c > @@ -0,0 +1,178 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved. Please update the copyright. Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. same for other new created files. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "tgu.h" > + > +static void tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) > +{ > + TGU_UNLOCK(drvdata->base); > + /* Enable TGU to program the triggers */ > + writel(1, drvdata->base + TGU_CONTROL); > + TGU_LOCK(drvdata->base); > +} > + > +static int tgu_enable(struct device *dev) > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + > + guard(spinlock)(&drvdata->lock); > + if (drvdata->enable) > + return -EBUSY; > + > + tgu_write_all_hw_regs(drvdata); > + drvdata->enable = true; > + > + return 0; > +} > + > +static int tgu_disable(struct device *dev) void is better as the return value always 0? > +{ > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + > + guard(spinlock)(&drvdata->lock); > + if (drvdata->enable) { > + TGU_UNLOCK(drvdata->base); > + writel(0, drvdata->base + TGU_CONTROL); > + TGU_LOCK(drvdata->base); > + > + drvdata->enable = false; > + } > + return 0; > +} > + > +static ssize_t enable_tgu_show(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + bool enabled; > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + > + guard(spinlock)(&drvdata->lock); > + enabled = drvdata->enable; > + > + return sysfs_emit(buf, "%d\n", enabled); Remove enabled with below: return sysfs_emit(buf, "%d\n", (int)drvdata->enable); It may suffer a warning during compile without cast? > +} > + > +/* enable_tgu_store - Configure Trace and Gating Unit (TGU) triggers. */ > +static ssize_t enable_tgu_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, > + size_t size) > +{ > + int ret = 0; > + unsigned long val; Prefer inverse christmas tree order > + > + ret = kstrtoul(buf, 0, &val); > + if (ret) > + return ret; if (kstrtoul(buf, 0, &val) return -EINVAL; > + > + if (val) { > + ret = pm_runtime_resume_and_get(dev); > + if (ret) > + return ret; > + ret = tgu_enable(dev); > + if (ret) > + pm_runtime_put(dev); if (ret) { pm_runtime_put(dev); return ret; } > + } else { > + ret = tgu_disable(dev); the return value here is 0, we can just ignore it, see previous comment. > + pm_runtime_put(dev); > + } > + > + if (ret) > + return ret; Remove if here. > + return size; > +} > +static DEVICE_ATTR_RW(enable_tgu); > + > +static struct attribute *tgu_common_attrs[] = { > + &dev_attr_enable_tgu.attr, > + NULL, > +}; > + > +static const struct attribute_group tgu_common_grp = { > + .attrs = tgu_common_attrs, > + NULL, > +}; > + > +static const struct attribute_group *tgu_attr_groups[] = { > + &tgu_common_grp, > + NULL, > +}; > + > +static int tgu_probe(struct amba_device *adev, const struct amba_id *id) > +{ > + struct device *dev = &adev->dev; > + struct tgu_drvdata *drvdata; > + int ret; > + > + drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > + if (!drvdata) > + return -ENOMEM; > + > + drvdata->dev = &adev->dev; > + dev_set_drvdata(dev, drvdata); > + > + drvdata->base = devm_ioremap_resource(dev, &adev->res); > + if (IS_ERR(drvdata->base)) > + return PTR_ERR(drvdata->base); > + > + spin_lock_init(&drvdata->lock); > + > + ret = sysfs_create_groups(&dev->kobj, tgu_attr_groups); > + if (ret) { > + dev_err(dev, "failed to create sysfs groups: %d\n", ret); > + return ret; > + } > + > + drvdata->enable = false; default false, no need. > + > + pm_runtime_put(&adev->dev); > + return 0; > +} > + > +static void tgu_remove(struct amba_device *adev) > +{ > + struct device *dev = &adev->dev; > + > + sysfs_remove_groups(&dev->kobj, tgu_attr_groups); > + > + tgu_disable(dev); > + dev_set_drvdata(dev, NULL); no need. remove will release the allocated memory. > +} > + > +static const struct amba_id tgu_ids[] = { > + { > + .id = 0x000f0e00, > + .mask = 0x000fffff, > + }, > + { 0, 0, NULL }, > +}; > + > +MODULE_DEVICE_TABLE(amba, tgu_ids); > + > +static struct amba_driver tgu_driver = { > + .drv = { > + .name = "qcom-tgu", > + .suppress_bind_attrs = true, > + }, > + .probe = tgu_probe, > + .remove = tgu_remove, > + .id_table = tgu_ids, > +}; > + > +module_amba_driver(tgu_driver); > + > +MODULE_AUTHOR("Songwei Chai "); > +MODULE_AUTHOR("Jinlong Mao "); > +MODULE_DESCRIPTION("Qualcomm Trigger Generation Unit driver"); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h > new file mode 100644 > index 000000000000..abc732f91dfc > --- /dev/null > +++ b/drivers/hwtracing/qcom/tgu.h > @@ -0,0 +1,51 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved. Please update the copyright. Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +#ifndef _QCOM_TGU_H > +#define _QCOM_TGU_H > + > +/* Register addresses */ > +#define TGU_CONTROL 0x0000 #define TGU_CONTROL 0 Thanks, Jie > +#define TGU_LAR 0xfb0 > +#define TGU_UNLOCK_OFFSET 0xc5acce55 > + > +static inline void TGU_LOCK(void __iomem *addr) > +{ > + do { > + /* Wait for things to settle */ > + mb(); > + writel_relaxed(0x0, addr + TGU_LAR); > + } while (0); > +} > + > +static inline void TGU_UNLOCK(void __iomem *addr) > +{ > + do { > + writel_relaxed(TGU_UNLOCK_OFFSET, addr + TGU_LAR); > + /* Make sure everyone has seen this */ > + mb(); > + } while (0); > +} > + > +/** > + * struct tgu_drvdata - Data structure for a TGU (Trigger Generator Unit) > + * @base: Memory-mapped base address of the TGU device > + * @dev: Pointer to the associated device structure > + * @lock: Spinlock for handling concurrent access > + * @enable: Flag indicating whether the TGU device is enabled > + * > + * This structure defines the data associated with a TGU device, > + * including its base address, device pointers, clock, spinlock for > + * synchronization, trigger data pointers, maximum limits for various > + * trigger-related parameters, and enable status. > + */ > +struct tgu_drvdata { > + void __iomem *base; > + struct device *dev; > + spinlock_t lock; > + bool enable; > +}; > + > +#endif