Re: [PATCH v2] drm/rockchip: rk3066_hdmi: convert to devm_drm_bridge_alloc() API

["Heiko Stübner" <heiko@sntech.de>]

Hi Johan,

Am Donnerstag, 3. September 2026, 22:44:57 Mitteleuropäische Sommerzeit schrieb Johan Jonker:
> On 9/3/26 17:12, Heiko Stübner wrote:
> > Am Montag, 24. August 2026, 12:21:19 Mitteleuropäische Sommerzeit schrieb Johan Jonker via B4 Relay:
> >> From: Hüseyin BIYIK <boogiepop@gmx.com>
> >>
> >> The function devm_drm_bridge_alloc() is the new API for allocating DRM bridges.
> >> This conversion was missed during the initial conversion of all bridges to
> >> the new API.
> >>
> >> Signed-off-by: Hüseyin BIYIK <boogiepop@gmx.com>
> >> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> >> ---
> >>  drivers/gpu/drm/rockchip/rk3066_hdmi.c | 8 ++++----
> >>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> >> index f28d6a883e09..39c65ee07caa 100644
> >> --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> >> +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> >> @@ -703,7 +703,6 @@ rk3066_hdmi_register(struct drm_device *drm, struct rk3066_hdmi *hdmi)
> >>  			 DRM_MODE_ENCODER_TMDS, NULL);
> >>  
> 
> >>  	hdmi->bridge.driver_private = hdmi;
> 
> Can this be removed?
> See link/comment below.

that is what I meant. bridge.container holds the same information and
bridge.private_data is not used in the rk3066_hdmi driver at all.

So if some future function needs to access the struct rk3066_hdmi it can
do so via the container field.


> and hdmi->bridge.funcs are redundant by this change?
> 
> Not redundant, just funcs are attached in a common function __devm_drm_bridge_alloc()

that's exactly wat I meant. As they are attached already in the common
function, there is no need to do it _again_ in rk3066_hdmi_register()

> 
> Please advise what changes are needed?
> RK3066_hdmi is broken since somewhere 2025-05.

So both should be dropped.

Heiko