mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: linux-renesas-soc@vger.kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2 6/6] clk: renesas: r9a06g032: Disable the watchdog reset sources when halting
Date: Mon, 14 Feb 2022 07:34:50 -0800	[thread overview]
Message-ID: <4595fbfe-da0b-1b1a-2478-6d537012a2bf@roeck-us.net> (raw)
In-Reply-To: <CAMuHMdUCT-qwhN53mRnAUox2pqw+Y5-7Gw5EbC+-HCF054kkgQ@mail.gmail.com>

On 2/14/22 02:45, Geert Uytterhoeven wrote:
> Hi Jean-Jacques,
> 
> CC watchdog people, who only received some patches.
> 
> On Tue, Feb 8, 2022 at 7:35 PM Jean-Jacques Hiblot
> <jjhiblot@traphandler.com> wrote:
>> The watchdog reset sources must be disabled when the system is halted.
>> Otherwise the watchdogs will trigger a reset if they have been armed.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> 
> Thanks for your patch!
> 
> [inserting changelog]
> 
> | Changes v1 -> v2:
> | * Modified the clock driver to not enable the watchdog reset sources.
> |   On other renesas platforms, those bits are by the bootloader. The
> |   watchdog reset sources are still disabled when the platform is halted
> |   to prevent a watchdog reset.
> 
> I still have my doubts about this part. So on halt, you override the
> policy configured by the boot loader, which means the watchdog is no
> longer triggered on halt.
> 
>>From a system perspective, the system can be in five states:
>    1. Running,
>    2. Crashed/lock-ed up,
>    3. Halt,
>    4. Reboot,
>    5. Poweroff.
> 
> Now, from a policy perspective, what is the difference between a
> system that crashes or locks up, and a system that halts?
> I.e. should the system reboot on halt, or not?
> 
> I think halting a system where the watchdog has been activated makes
> no sense, and the user either wants to explicitly reboot the system, or
> power it off, but never halt it.  So I think this patch is not needed.
> 
> Watchdog people: what is your opinion?

In my understanding the shutdown code is always executed, ie also for
restarts and poweroff. Disabling the watchdog in that situation is not
always desirable, though sometimes necessary depending on the hardware.
Disabling it through the backdoor (instead of calling watchdog_stop_on_reboot)
seems odd, though.

Guenter

> Thanks!
> 
>> --- a/drivers/clk/renesas/r9a06g032-clocks.c
>> +++ b/drivers/clk/renesas/r9a06g032-clocks.c
>> @@ -129,6 +129,11 @@ enum { K_GATE = 0, K_FFC, K_DIV, K_BITSEL, K_DUALGATE };
>>
>>   #define R9A06G032_CLOCK_COUNT          (R9A06G032_UART_GROUP_34567 + 1)
>>
>> +#define R9A06G032_SYSCTRL_REG_RSTEN            0x120
>> +#define WDA7RST1       BIT(2)
>> +#define WDA7RST0       BIT(1)
>> +#define MRESET         BIT(0)
>> +
>>   static const struct r9a06g032_clkdesc r9a06g032_clocks[] = {
>>          D_ROOT(CLKOUT, "clkout", 25, 1),
>>          D_ROOT(CLK_PLL_USB, "clk_pll_usb", 12, 10),
>> @@ -893,6 +898,19 @@ static void r9a06g032_clocks_del_clk_provider(void *data)
>>          of_clk_del_provider(data);
>>   }
>>
>> +static void r9a06g032_reset_sources(struct r9a06g032_priv *clocks,
>> +                       uint32_t mask, uint32_t value)
>> +{
>> +       uint32_t rsten;
>> +       unsigned long flags;
>> +
>> +       spin_lock_irqsave(&clocks->lock, flags);
>> +       rsten = readl(clocks->reg);
>> +       rsten = (rsten & ~mask) | (value & mask);
>> +       writel(rsten, clocks->reg + R9A06G032_SYSCTRL_REG_RSTEN);
>> +       spin_unlock_irqrestore(&clocks->lock, flags);
>> +}
>> +
>>   static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
>>   {
>>          struct device *dev = &pdev->dev;
>> @@ -910,6 +928,8 @@ static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
>>          if (!clocks || !clks)
>>                  return -ENOMEM;
>>
>> +       platform_set_drvdata(pdev, clocks);
>> +
>>          spin_lock_init(&clocks->lock);
>>
>>          clocks->data.clks = clks;
>> @@ -963,9 +983,18 @@ static int __init r9a06g032_clocks_probe(struct platform_device *pdev)
>>          if (error)
>>                  return error;
>>
>> +
>>          return r9a06g032_add_clk_domain(dev);
>>   }
>>
>> +static void r9a06g032_clocks_shutdown(struct platform_device *pdev)
>> +{
>> +       struct r9a06g032_priv *clocks = platform_get_drvdata(pdev);
>> +
>> +       /* Disable the watchdog reset sources */
>> +       r9a06g032_reset_sources(clocks, WDA7RST0 | WDA7RST1, 0);
>> +}
>> +
>>   static const struct of_device_id r9a06g032_match[] = {
>>          { .compatible = "renesas,r9a06g032-sysctrl" },
>>          { }
>> @@ -976,6 +1005,7 @@ static struct platform_driver r9a06g032_clock_driver = {
>>                  .name   = "renesas,r9a06g032-sysctrl",
>>                  .of_match_table = r9a06g032_match,
>>          },
>> +       .shutdown = r9a06g032_clocks_shutdown,
>>   };
>>
>>   static int __init r9a06g032_clocks_init(void)
> 
> Gr{oetje,eeting}s,
> 
>                          Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds


  reply	other threads:[~2022-02-14 15:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 18:35 [PATCH v2 0/6] ARM: r9a06g032: add support for the watchdogs Jean-Jacques Hiblot
2022-02-08 18:35 ` [PATCH v2 1/6] dt-bindings: clock: r9a06g032: Add the definition of the the watchdog clock Jean-Jacques Hiblot
2022-02-11 16:45   ` Rob Herring
2022-02-08 18:35 ` [PATCH v2 2/6] dt-bindings: watchdog: renesas,wdt: Add support for RZ/N1 Jean-Jacques Hiblot
2022-02-09  8:32   ` Geert Uytterhoeven
2022-02-11 16:45   ` Rob Herring
2022-02-08 18:35 ` [PATCH v2 3/6] ARM: dts: r9a06g032: Add the watchdog nodes Jean-Jacques Hiblot
2022-02-09  8:33   ` Geert Uytterhoeven
2022-02-08 18:35 ` [PATCH v2 4/6] ARM: dts: r9a06g032-rzn1d400-db: Enable watchdog0 with a 60s timeout Jean-Jacques Hiblot
2022-02-09  8:33   ` Geert Uytterhoeven
2022-02-08 18:35 ` [PATCH v2 5/6] watchdog: Add Renesas RZ/N1 Watchdog driver Jean-Jacques Hiblot
2022-02-09  8:28   ` Geert Uytterhoeven
2022-02-09 18:21     ` Jean-Jacques Hiblot
2022-02-08 18:35 ` [PATCH v2 6/6] clk: renesas: r9a06g032: Disable the watchdog reset sources when halting Jean-Jacques Hiblot
2022-02-14 10:45   ` Geert Uytterhoeven
2022-02-14 15:34     ` Guenter Roeck [this message]
2022-02-21  9:13       ` Jean-Jacques Hiblot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4595fbfe-da0b-1b1a-2478-6d537012a2bf@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=geert@linux-m68k.org \
    --cc=jjhiblot@traphandler.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®