From: Damien Le Moal <dlemoal@kernel.org>
To: Inochi Amaoto <inochiama@gmail.com>,
Hans de Goede <hansg@kernel.org>,
Niklas Cassel <cassel@kernel.org>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Minas Harutyunyan <hminas@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Vinod Koul <vkoul@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Damon Ding <damon.ding@rock-chips.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org,
linux-phy@lists.infradead.org, Yixun Lan <dlan@gentoo.org>,
Longbin Li <looong.bin@gmail.com>
Subject: Re: [PATCH] phy: core: Use EOPNOTSUPP for disabled blob return value
Date: Tue, 29 Sep 2026 15:30:16 +0200 [thread overview]
Message-ID: <45963e29-f896-4e67-87ee-ac90131773e2@kernel.org> (raw)
In-Reply-To: <20260929084739.467082-1-inochiama@gmail.com>
On 2026/09/29 10:47, Inochi Amaoto wrote:
> Currently, the phy subsystem uses ENOSYS for dummy blob functions,
> it does not reflect the function state correctly. As kernel already
s/function state/hardware capability ?
s/As kernel/As the kernel
> has EOPNOTSUPP for disabled blob function, replace ENOSYS with
What is "blob function" ? Are you talking about all the phy_xxx() functions?
> EOPNOTSUPP for a clear return value. Also adapt the return value
> changed in the following affect file:
s/affect/affected
> - ata/libahci_platform.c
> - drm/bridge/analogix/analogix_dp_core.c
> - usb/dwc2/platform.c
> - usb/dwc3/core.c
>
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
The ata bits looks OK, but this still feels like a lot of churn for no
functional change since the error is an internal one that is not exposed to the
user, as far as I can tell. The code in many places also uses -ENODEV, so the
error returned does not seem to be consistent anyway.
--
Damien Le Moal
Western Digital Research
prev parent reply other threads:[~2026-09-29 13:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 8:47 Inochi Amaoto
2026-09-29 13:30 ` Damien Le Moal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45963e29-f896-4e67-87ee-ac90131773e2@kernel.org \
--to=dlemoal@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=cassel@kernel.org \
--cc=damon.ding@rock-chips.com \
--cc=dlan@gentoo.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=heiko@sntech.de \
--cc=hminas@synopsys.com \
--cc=inochiama@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mani@kernel.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®