From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0886BC5ACB3 for ; Tue, 21 Nov 2023 07:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbjKUH3r (ORCPT ); Tue, 21 Nov 2023 02:29:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229534AbjKUH3o (ORCPT ); Tue, 21 Nov 2023 02:29:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6839FC8 for ; Mon, 20 Nov 2023 23:29:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 208BAC433CA; Tue, 21 Nov 2023 07:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700551780; bh=iN2vy0G2QoY8JrojPMvjhZH+VwMN+5+iL06Cyoh3i6Y=; h=In-Reply-To:References:Date:From:To:Cc:Subject:From; b=juPN3fvLFhkMXE7swdscPFUoJTQpjOdIKJ6+jcN7edckVjdj7qX8yZ8OvzeHJUsbI TEUZLdyuJokywmmn/YCRBkoqCf+MA2afrLLumDnDpNGGtLiscT7wswjJnvVkDVEeMD WD8ncb5+ZgKCpCYBjvID/QLFedjFL+xocD3YcefeoIrol9dznOMD6MdOr3HVmiO1Wa lSBnUVRha0DVOdwU7JHWsmM1J9SyIrpgMHnQwsviQjw6dQAATrQLuwTuSa/9i9AMfc VofDp/0+Vxexz5tge6DpI77EZJNQ9KRetHgO0KkFP7Z7rvU5mkjWDEKLw5IQPDjpny zhFNLsxt7xnFA== Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id 1AC3F27C0054; Tue, 21 Nov 2023 02:29:38 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Tue, 21 Nov 2023 02:29:38 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudegkedguddtkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugeskhgvrhhnvghlrdhorhhgqeenucggtf frrghtthgvrhhnpedvveeigfetudegveeiledvgfevuedvgfetgeefieeijeejffeggeeh udegtdevheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrrhhnugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidquddvkeehudej tddvgedqvdekjedttddvieegqdgrrhhnugeppehkvghrnhgvlhdrohhrghesrghrnhgusg druggv X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id D5AA1B60089; Tue, 21 Nov 2023 02:29:36 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: <45997863-d817-48c7-ad46-8b47f5e0ce61@app.fastmail.com> In-Reply-To: <20231120215945.52027-4-pstanner@redhat.com> References: <20231120215945.52027-2-pstanner@redhat.com> <20231120215945.52027-4-pstanner@redhat.com> Date: Tue, 21 Nov 2023 08:29:15 +0100 From: "Arnd Bergmann" To: "Philipp Stanner" , "Bjorn Helgaas" , "Andrew Morton" , "Randy Dunlap" , "Jason Gunthorpe" , "Eric Auger" , "Kent Overstreet" , "Niklas Schnelle" , "Neil Brown" , "John Sanpe" , "Dave Jiang" , "Yury Norov" , "Kees Cook" , "Masami Hiramatsu" , "David Gow" , "Herbert Xu" , "Thomas Gleixner" , "wuqiang.matt" , "Jason Baron" , "Ben Dooks" , "Danilo Krummrich" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 2/4] lib: move pci-specific devres code to drivers/pci/ Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 20, 2023, at 22:59, Philipp Stanner wrote: > The pcim_*() functions in lib/devres.c are guarded by an #ifdef > CONFIG_PCI and, thus, don't belong to this file. They are only ever used > for pci and not generic infrastructure. > > Move all pcim_*() functions in lib/devres.c to drivers/pci/devres.c > > Suggested-by: Danilo Krummrich > Signed-off-by: Philipp Stanner > --- > drivers/pci/Makefile | 2 +- > drivers/pci/devres.c | 207 ++++++++++++++++++++++++++++++++++++++++++ > lib/devres.c | 208 +------------------------------------------ Since you are moving the pci_iomap() code into drivers/pci/ already, I'd suggest merging this one into the same file and keep the two halves of this interface together. Arnd