From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Danish Prakash <contact@danishpraka.sh>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Carl Vanderlip <quic_carlv@quicinc.com>,
Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@quicinc.com>,
Oded Gabbay <ogabbay@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"open list:QUALCOMM CLOUD AI (QAIC) DRIVER"
<linux-arm-msm@vger.kernel.org>,
"open list:QUALCOMM CLOUD AI (QAIC) DRIVER"
<dri-devel@lists.freedesktop.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation/accel/qaic: Fix typo
Date: Tue, 4 Jun 2024 09:36:45 -0600 [thread overview]
Message-ID: <459ef672-82c8-abcd-5c7a-5c1b4db7e1e3@quicinc.com> (raw)
In-Reply-To: <20240601145216.32232-1-contact@danishpraka.sh>
For future reference, since this is the second revision of this change,
the subject should have "[PATCH v2]".
On 6/1/2024 8:51 AM, Danish Prakash wrote:
> Fixed a typo in the docs where 'phsyical' > was corrected to 'physical'.
Commit text should be in the present simple tense. You currently are
using past tense here. "Fixed" -> "Fix", etc.
> Signed-off-by: Danish Prakash <contact@danishpraka.sh>
> ---
Since this is a single change and not a series, you should have a change
log here which identifies what is different in this revision.
> Documentation/accel/qaic/qaic.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/accel/qaic/qaic.rst b/Documentation/accel/qaic/qaic.rst
> index efb7771273bb..628bf2f7a416 100644
> --- a/Documentation/accel/qaic/qaic.rst
> +++ b/Documentation/accel/qaic/qaic.rst
> @@ -93,7 +93,7 @@ commands (does not impact QAIC).
> uAPI
> ====
>
> -QAIC creates an accel device per phsyical PCIe device. This accel device exists
> +QAIC creates an accel device per physical PCIe device. This accel device exists
> for as long as the PCIe device is known to Linux.
>
> The PCIe device may not be in the state to accept requests from userspace at
prev parent reply other threads:[~2024-06-04 15:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 6:09 [PATCH] Documentation/accel/qaic: Fix typo 'phsyical' Danish Prakash
2024-05-31 14:20 ` Shuah Khan
2024-05-31 21:05 ` Jeffrey Hugo
2024-06-01 14:51 ` [PATCH] Documentation/accel/qaic: Fix typo Danish Prakash
2024-06-04 15:36 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459ef672-82c8-abcd-5c7a-5c1b4db7e1e3@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=contact@danishpraka.sh \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_carlv@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®