Russell King wrote: > On Sat, Jan 06, 2007 at 01:17:25PM -0800, David Brownell wrote: > >> On Saturday 06 January 2007 9:17 am, Woody Suwalski wrote: >> >>>>> There are PPC, M68K, SPARC, and other boards that could also >>>>> use this; ARMs tend to integrate some other RTC on-chip. ... >>>>> >>>> Let me put that differently. That should be done as a separate >>>> patch, adding (a) that platform_device, and maybe platform_data >>>> if it's got additional alarm registers, and (b) Kconfig support >>>> to let that work. I'd call it a "patch #4 of 3". ;) >>>> ... >>>> >>> I will try to play with the new code on Monday on ARM... >>> >> Thanks. Could you describe your ARM board? None of mine have an >> RTC using this register API. Does it support system sleep states >> (/sys/power/state) with a wakeup-capable (enable_irq_wake) RTC irq? >> > > Woody will be using a Netwinder (he's part of the original development > team.) So no sleep states and therefore no wakeup. > > There's various other ARM-based systems using the PC RTC, but none of > them have sleep or wakeup abilities afaik. > > I think that Russell is correct - the RTC is just part of a Winbond multifunction chip. It has no special wake-up or alarm hooks (as far as I remember). As to the patch: applied to 2.6.20-rc4, both on PC and ARM, commented out "EXPERIMENTAL"... To build your new patch for ARM I have modified the line "depends on RTC_CLASS && (X86_PC || ACPI || ARM)"... On Netwinder ARM - can not build (see: rtc_build.log) OK, changed the include/asm/rtc.h to look like i386 == include asm-generic/rtc.h Still does not build - see rtc_build2.log Could you please check what other defs are missing on ARM? Thanks, Woody BTW. Current RTC is broken same way on Shark ARM as it is on Netwinder ARM: >>> As for the RTC patch, it does work on the shark, and is needed. <<< So is there a reason to have RTC build blocked on all ARM?