mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiaoning Ding <dingxn@cse.ohio-state.edu>
To: linux-kernel@vger.kernel.org
Subject: a bug in AS scheduler?
Date: Tue, 27 Feb 2007 23:22:39 -0500	[thread overview]
Message-ID: <45E5038F.1090200@cse.ohio-state.edu> (raw)

Hi,

I am reading the source code AS scheduler in 2.6.18(as-ioscheduler.c).
In function as_close_req, variable delay is in millisecond, while
ad->antic_expire is in jiffies. Doesn't the comparison of delay and
ad->antic_expire make any problem?
The related source code is quoted blow:

	if (ad->antic_status == ANTIC_OFF || !ad->ioc_finished)
		delay = 0;
	else
		delay = ((jiffies - ad->antic_start) * 1000) / HZ;

	if (delay == 0)
		delta = 8192;
	else if (delay <= 20 && delay <= ad->antic_expire)
		delta = 8192 << delay;
	else
		return 1;


Xiaoning

             reply	other threads:[~2007-02-28  4:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-28  4:22 Xiaoning Ding [this message]
2007-02-28 12:10 ` Jens Axboe
2007-02-28 13:25   ` Benoit Boissinot
2007-02-28 13:34     ` Jens Axboe
2007-02-28 15:33       ` Xiaoning Ding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E5038F.1090200@cse.ohio-state.edu \
    --to=dingxn@cse.ohio-state.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®