From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] bcm43xx: do not rebuild when kernel version changes
Date: Sat, 03 Mar 2007 15:03:57 -0600 [thread overview]
Message-ID: <45E9E2BD.9070106@lwfinger.net> (raw)
In-Reply-To: <200703032121.43136.mb@bu3sch.de>
Michael Buesch wrote:
> On Saturday 03 March 2007 20:03, Sam Ravnborg wrote:
>> Replacing use of UTS_RELEASE with utsname()->release
>> avoids that this module is rebuild each
>> time the kernel version changes.
>>
>> Compile tested only.
>
> I vote to get rid of the whole bcm43xx_ethtool.c file, as it's useless.
> It will vanish with the advent of d80211, anyway.
> Larry?
Is bcm43xx_ethtool.c really useless? If so, I vote to remove it. I have never tried to use ethtool
on bcm43xx. Similarly, it isn't very often that I recompile the kernel when bcm43xx hasn't changed
and would not have noticed the bug that Sam reported.
Larry
next prev parent reply other threads:[~2007-03-03 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-03 19:03 Sam Ravnborg
2007-03-03 20:21 ` Michael Buesch
2007-03-03 21:03 ` Larry Finger [this message]
2007-03-03 21:10 ` Michael Buesch
2007-03-03 21:13 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E9E2BD.9070106@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®