From: Gerd Hoffmann <kraxel@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Andrew Morton <akpm@linux-foundation.org>,
benh@kernel.crashing.org
Subject: Re: [patch] Fixes and cleanups for earlyprintk aka boot console.
Date: Mon, 05 Mar 2007 08:38:26 +0100 [thread overview]
Message-ID: <45EBC8F2.4040501@suse.de> (raw)
In-Reply-To: <17899.39250.247475.777798@cargo.ozlabs.ibm.com>
Paul Mackerras wrote:
> Gerd Hoffmann writes:
>
>> This patch fixes the console selection code to *not* consider a boot
>> console a full-featured one, so the first non-boot console registering
>> will become the default console instead. This way the unregister call
>> for the boot console in the register_console() function actually
>> triggers and the handover from the boot console to the real console
>> device works smoothly. Added a printk for the handover, so you know
>> which console device the output goes to when the boot console stops
>> printing messages.
>
> You have removed functionality that is useful for debugging, that 3
> architectures had, namely a way to keep using the early boot console
> and not replace it with a console that comes later, using a kernel
> command line option. Perhaps you could provide a way to do that in
> your patch.
--verbose please. I don't think I broke that.
I've seen code for that in i386/x86_64 and one of the other archs (via
earlyprintk=foo,keep). The code clears now the CON_BOOT flag in case
keep is present, which has the wanted effect: The earlyprintk console
will not be replaced.
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
prev parent reply other threads:[~2007-03-05 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 11:35 Gerd Hoffmann
2007-03-02 7:46 ` Andrew Morton
2007-03-02 9:52 ` Gerd Hoffmann
2007-03-02 16:06 ` Jeremy Fitzhardinge
2007-03-02 16:38 ` Gerd Hoffmann
2007-03-05 4:15 ` Paul Mackerras
2007-03-05 7:38 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EBC8F2.4040501@suse.de \
--to=kraxel@suse.de \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome