From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42E5F332EC8 for ; Thu, 4 Jun 2026 07:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780559483; cv=none; b=TrKsF+4LIVlpRDBqNGnqHi/G9MTwxGPldadSDlwypCjcrzStYJkEfkMZhT2A8DdHjUMZDLAuJ2v6jwkUfxabQMmAPreRCu80quW8FmMfnV2+xJ2E0ZcgShy3FkAJvfhVl7p6EKdkLtpXsUOb7Xigxz+XLzw/UyLqB+y/tw63h/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780559483; c=relaxed/simple; bh=Vg3dVR9nzBP0uAttxrjhLoikT3SaSfGSYBSYBXWRYEU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jq6TIrMV5fn25HghfUQwDokRBrghAmDjv8mXUyPdtCY7huTvh2AC1pV2a4/ZB7tRFx54tJ1CmegasD7PA1RWHgCyT0TV1PGJ+wrHZOcNYEKNIMsc1D9egsfwHgAo+MMR6w2txgaV9zbdLPQCUQYqjgbtkelzjCiPHRT6lZ5gnq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=h/njGAtP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h/njGAtP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 890AE1F00893; Thu, 4 Jun 2026 07:51:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780559481; bh=STdJsShTwrcQu68JTDiYWJbDJbUTK2P0C0qpNo8rJfQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=h/njGAtPD4eLlNpkOJxfNRxrXoG+ubeTccX+H5+jlxnY+5YdTJx5bt1WouNori5xO biTxxN03XAGITLX4hbpSLort9NoQtd7hAAv9R76N7ypnowpJ1SEP3SZX/GDuxQxyja t9whIGNCt961CQdU5Zs0Nizgk3sMMXlvv6lusEuMijNdSC4Ke2iwCSbDtiw/hkkSv0 tgvvojfNZTPj5nkh+Q+4ZzMus2oczaFMKH2ZT5FvrSLEMiUdO7t9k+Mu8udKisLAct YB9A5mkPqEb1gTcYYuq1RlYx7q03iANszD7VPJfKiRIgGKJ9mpoLpSgGTEs1MZCCvA Fo9ENo1z2l+pg== Message-ID: <45a049b3-6c60-4254-ae7e-3ca2b1f1a15f@kernel.org> Date: Thu, 4 Jun 2026 09:51:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFT] powerpc/8xx: implement get_direction() in cpm1 To: Bartosz Golaszewski , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Linus Walleij , Dmitry Torokhov Cc: brgl@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260603-powerpc-8xx-cpm1-get-dir-v1-1-2ae1c9a5b992@oss.qualcomm.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260603-powerpc-8xx-cpm1-get-dir-v1-1-2ae1c9a5b992@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 03/06/2026 à 10:26, Bartosz Golaszewski a écrit : > The lack of get_direction() callbacks in this driver causes GPIOLIB to > emit a warning. Implement them for 16- and 32-bit variants. > > Reported-by: Christophe Leroy > Closes: https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F63487206f6e5a93eaf9f41784317fe99d394312f.1780399750.git.chleroy%40kernel.org%2F&data=05%7C02%7Cchristophe.leroy%40csgroup.eu%7C67d2207e02454f2ecf0008dec149d67c%7C8b87af7d86474dc78df45f69a2011bb5%7C0%7C0%7C639160720043016747%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=k6%2FENNl94WS7QvRdhhmx8VvDyZKMNW8sAlKEq3AtQe4%3D&reserved=0 > Fixes: ec2cceadfae7 ("gpiolib: normalize the return value of gc->get() on behalf of buggy drivers") > Signed-off-by: Bartosz Golaszewski Reviewed-by: Christophe Leroy (CS GROUP) Tested-by: Christophe Leroy (CS GROUP) > --- > Hi Christophe, please test if this works for you to silence the warning > from GPIO core. Hi Bartosz, yes it does, many thanks for the fix. By the way, wouldn't it also make sense to update the following comment in include/linux/gpio/driver.h to change from 'recommended' to 'mandatory' ? * @get_direction: returns direction for signal "offset", 0=out, 1=in, * (same as GPIO_LINE_DIRECTION_OUT / GPIO_LINE_DIRECTION_IN), * or negative error. It is recommended to always implement this * function, even on input-only or output-only gpio chips. > --- > arch/powerpc/platforms/8xx/cpm1.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/powerpc/platforms/8xx/cpm1.c b/arch/powerpc/platforms/8xx/cpm1.c > index f00734f0590cf7c7382f808dce27373d9ff3d8bc..b31376bf6778802a7f6b6b499066846b6b1f61e9 100644 > --- a/arch/powerpc/platforms/8xx/cpm1.c > +++ b/arch/powerpc/platforms/8xx/cpm1.c > @@ -472,6 +472,18 @@ static int cpm1_gpio16_dir_in(struct gpio_chip *gc, unsigned int gpio) > return 0; > } > > +static int cpm1_gpio16_get_direction(struct gpio_chip *gc, unsigned int gpio) > +{ > + struct cpm1_gpio16_chip *cpm1_gc = gpiochip_get_data(gc); > + struct cpm_ioport16 __iomem *iop = cpm1_gc->regs; > + u16 pin_mask = 1 << (15 - gpio); > + > + if (in_be16(&iop->dir) & pin_mask) > + return GPIO_LINE_DIRECTION_OUT; > + > + return GPIO_LINE_DIRECTION_IN; > +} > + > int cpm1_gpiochip_add16(struct device *dev) > { > struct device_node *np = dev->of_node; > @@ -498,6 +510,7 @@ int cpm1_gpiochip_add16(struct device *dev) > gc->ngpio = 16; > gc->direction_input = cpm1_gpio16_dir_in; > gc->direction_output = cpm1_gpio16_dir_out; > + gc->get_direction = cpm1_gpio16_get_direction; > gc->get = cpm1_gpio16_get; > gc->set = cpm1_gpio16_set; > gc->to_irq = cpm1_gpio16_to_irq; > @@ -604,6 +617,18 @@ static int cpm1_gpio32_dir_in(struct gpio_chip *gc, unsigned int gpio) > return 0; > } > > +static int cpm1_gpio32_get_direction(struct gpio_chip *gc, unsigned int gpio) > +{ > + struct cpm1_gpio32_chip *cpm1_gc = gpiochip_get_data(gc); > + struct cpm_ioport32b __iomem *iop = cpm1_gc->regs; > + u32 pin_mask = 1 << (31 - gpio); > + > + if (in_be32(&iop->dir) & pin_mask) > + return GPIO_LINE_DIRECTION_OUT; > + > + return GPIO_LINE_DIRECTION_IN; > +} > + > int cpm1_gpiochip_add32(struct device *dev) > { > struct device_node *np = dev->of_node; > @@ -621,6 +646,7 @@ int cpm1_gpiochip_add32(struct device *dev) > gc->ngpio = 32; > gc->direction_input = cpm1_gpio32_dir_in; > gc->direction_output = cpm1_gpio32_dir_out; > + gc->get_direction = cpm1_gpio32_get_direction; > gc->get = cpm1_gpio32_get; > gc->set = cpm1_gpio32_set; > gc->parent = dev; > > --- > base-commit: b7bee4ca5688e30ca50fbc87b1b8f7eed7006c17 > change-id: 20260603-powerpc-8xx-cpm1-get-dir-698cefe92647 > > Best regards,