From: Ben Gardner <gardner.ben@gmail.com>
To: linux-kernel@vger.kernel.org,
Andres Salomon <dilinger@collabora.co.uk>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Ben Gardner <gardner.ben@gmail.com>,
Andres Salomon <dilinger@collabora.co.uk>,
Andrew Morton <akpm@linux-foundation.org>,
David Brownell <dbrownell@users.sourceforge.net>,
Jani Nikula <ext-jani.1.nikula@nokia.com>
Subject: [PATCH 3/3] OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input
Date: Fri, 26 Feb 2010 17:26:26 -0600 [thread overview]
Message-ID: <45a4e62ae577ae6cabce7e243e675b5e7d994ec2.1267225701.git.gardner.ben@gmail.com> (raw)
In-Reply-To: <cover.1267225701.git.gardner.ben@gmail.com>
In-Reply-To: <cover.1267225701.git.gardner.ben@gmail.com>
We need to read back the value written to the GPIO pin to control the
MIC input enable.
Use gpio_set_direction() to set the GPIO in bidirectional mode.
Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
CC: Andres Salomon <dilinger@collabora.co.uk>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: David Brownell <dbrownell@users.sourceforge.net>
CC: Jani Nikula <ext-jani.1.nikula@nokia.com>
---
sound/pci/cs5535audio/cs5535audio_olpc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/cs5535audio/cs5535audio_olpc.c b/sound/pci/cs5535audio/cs5535audio_olpc.c
index 50da49b..0c80e67 100644
--- a/sound/pci/cs5535audio/cs5535audio_olpc.c
+++ b/sound/pci/cs5535audio/cs5535audio_olpc.c
@@ -156,7 +156,7 @@ int __devinit olpc_quirks(struct snd_card *card, struct snd_ac97 *ac97)
printk(KERN_ERR DRV_NAME ": unable to allocate MIC GPIO\n");
return -EIO;
}
- gpio_direction_output(OLPC_GPIO_MIC_AC, 0);
+ gpio_set_direction(OLPC_GPIO_MIC_AC, 3, 0);
/* drop the original AD1888 HPF control */
memset(&elem, 0, sizeof(elem));
--
1.7.0
next prev parent reply other threads:[~2010-02-26 23:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 23:26 [PATCH 0/3] gpio: add gpio_set_direction Ben Gardner
2010-02-26 23:26 ` [PATCH 1/3] gpiolib: add gpio_set_direction() Ben Gardner
2010-02-26 23:39 ` Andres Salomon
2010-02-27 5:11 ` Ben Gardner
2010-02-27 7:02 ` David Brownell
2010-02-27 10:26 ` Mark Brown
2010-02-27 16:24 ` David Brownell
2010-02-27 17:20 ` Mark Brown
2010-02-27 17:51 ` David Brownell
2010-03-01 10:35 ` Mark Brown
2010-02-27 18:36 ` Ben Gardner
2010-02-27 19:23 ` David Brownell
2010-02-27 18:36 ` [PATCH] cs5535-gpio: change input/output enable to match gpiolib expectations Ben Gardner
2010-02-27 18:40 ` Ben Gardner
2010-02-27 18:56 ` [PATCH v2] " Ben Gardner
2010-02-27 19:18 ` David Brownell
2010-02-26 23:26 ` [PATCH 2/3] cs5535-gpio: Use set_direction Ben Gardner
2010-02-27 7:04 ` David Brownell
2010-02-27 18:18 ` Ben Gardner
2010-02-26 23:26 ` Ben Gardner [this message]
2010-02-27 7:14 ` [PATCH 3/3] OLPC: ALSA: fix cs5535audio's MIC GPIO to enable input David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45a4e62ae577ae6cabce7e243e675b5e7d994ec2.1267225701.git.gardner.ben@gmail.com \
--to=gardner.ben@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dilinger@collabora.co.uk \
--cc=ext-jani.1.nikula@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®