From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4828414D70E for ; Tue, 17 Dec 2024 07:20:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734420049; cv=none; b=uG/fUNJ51tbL+aHy3LU7HBB4RlIw1eMdOzqRfTuTy5et+SqcB38sIhIiqwRWE4YzFcLgmUNzZCiHqAFZBG4FiJsz95iUNvNM7glXDRG1RcnxRaW3z0mTVzNYL1ofZDv5x8D4kpkOqVZOsLHIkMwkuAmiXV/Ec/VHvBxHLu6+n4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734420049; c=relaxed/simple; bh=cXwasypA7mo/HGt2OB/7lQNaok+kG+zU85E5bsHXHuA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sYmm8mu0qNQreoAoZX4l92J5UaTRZS2tDAnOLQ4YyRo9QK1GqTU4DCXq3EM7pU8cL/vyQ+yMuE3JIJliegPujKz5+as+Ek6o69gioGuu2BFolWZaTd7T81aPtEg1OU6nxYMaXp/0MN86F5Sntu8r+py3ZpjcxbvyqB2hAvHT9So= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lNHFApmS; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lNHFApmS" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4361b6f9faeso30463485e9.1 for ; Mon, 16 Dec 2024 23:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734420044; x=1735024844; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kwvB7uBpEMwnL4s+j9WaUS+8KTpcKQVS4QfB1gDHcEA=; b=lNHFApmSTlIhRpHK96Ys5/O98LBcF0xd9PXDDWpEZ6vRWYRM1fNfhNaFz2ze1fQPvx 2nK8pFywb0v8XopzW719wZ65eU8hpIv24e4Uc3/1VmDFDvAqk7Ptfu+QcUaoyIAP1G7D a9Mzv5sGp4g6LdLwIsBhD0SF8klgEecaR01EyVXAInLuTJQdHxT2b/lmluh54gvUmEgq H6QUr5wKsz6LvlAg+S90hshgDiw8INnBe5z6L+vwVoW4k0/SmOvwduEAx+pYothBMK7H kQkKVQUW35nSx7yHl6Ql5ySazUGgowwfRmyKLQv8pwpf8yGd5H1LmX2uWhja1J33m+Tt eXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734420044; x=1735024844; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kwvB7uBpEMwnL4s+j9WaUS+8KTpcKQVS4QfB1gDHcEA=; b=prNfSFwLSRZ1/7TlR0vLvzy5n781P4DbycaeBHAJ2sRWDdVlt414bkL6sZlf1AJs2b /V2CF67E/yIcaBwlUMF0ZAZe9zIhENit7xeYiTgxLuupKfWKRp86BjR2ZcF0JVNu9TRg OoSgnIoWxdBnm9VJo0KUZT4lP85B+XlsaxrCPHGEmEX+eC0c78DULScPZ9di4kDH1U8K cFf7K2etiOGfgzix2FJcAGRMDXw0liXUUNRKo2/VOIhzwhhw+DWCi1neGvA03LpJIiwv hngCIna7HNutzFH9Hdj+t8ucBoh65nKIHfGsqf7Juo3sEDl/zHjkXu6I81zetA5bHC1l ElAg== X-Forwarded-Encrypted: i=1; AJvYcCVvN8ADvK40U7RU9+pF1vD0vygivlf5Z2mSb7jibQpi1zRZI9TrZuvw0q/DLtHfysFSCuWuw/Kr4KgzxiE=@vger.kernel.org X-Gm-Message-State: AOJu0YxSYfaQRrINQ1utmXt1H0NU5gOf+3ezcEuDfwTvVUXOvVFbn6AC 6a0Teyd4rPN1fuoEwWRX0dl3oOa+UUUNFixg7Yxwy3lfi8kej30FV0vdUCWK5/g= X-Gm-Gg: ASbGncvSqjlDnzWD0V3Nck7AuZ37VH/ANbk5H1YRrv9kTuCqdZVbG1l9TQE6D9M9fdz WgRrun4115VWyrwXoXNvyZLRtJk09Sx8n3olsUWe1jSZZedqhwVq6EqdsRTQPMCbp8VCixFUhwD Vsxbn3U7pQuFAbt/KWvkixcr96GGxBmjB1n5mY4Ia4+i3B2ZHlagyDYs7TkP5Cv3X+JwURe4OSb ApWGYpVjV4vIFh9JdEbN7WY6JXtdCNn5nxrfUsD6Kd5kGD1S9wzSUqXmdM05xcl X-Google-Smtp-Source: AGHT+IF9HA/1SKKgvXJjtH52nkzbyQi6zojEXUgurj4MP9uhS4GfNABlmxHlIXgDW1wjDEC3z9sBhw== X-Received: by 2002:a05:600c:1583:b0:434:e892:1033 with SMTP id 5b1f17b1804b1-4364812a08cmr15865095e9.2.1734420044507; Mon, 16 Dec 2024 23:20:44 -0800 (PST) Received: from [192.168.0.14] ([188.26.61.92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-388c801637esm10236598f8f.28.2024.12.16.23.20.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 23:20:44 -0800 (PST) Message-ID: <45a54924-226e-4a94-b1ae-b0f1f703f854@linaro.org> Date: Tue, 17 Dec 2024 07:20:42 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] arm64: dts: exynos: gs101: add ACPM protocol node To: William McVicker Cc: Peter Griffin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, kernel-team@android.com, daniel.lezcano@linaro.org, vincent.guittot@linaro.org, ulf.hansson@linaro.org, arnd@arndb.de References: <20241212-b4-acpm-v4-upstream-dts-v2-0-91b7a6f6d0b0@linaro.org> <20241212-b4-acpm-v4-upstream-dts-v2-3-91b7a6f6d0b0@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/16/24 6:54 PM, William McVicker wrote: > Hi Tudor, Hi, William! > > On 12/12/2024, Tudor Ambarus wrote: >> Add the ACPM protocol node. ACPM protocol provides interface for all >> the client drivers making use of the features offered by the >> Active Power Management (APM) module. >> >> Signed-off-by: Tudor Ambarus >> --- >> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> index 04561e15b96c..8c3f07371912 100644 >> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> @@ -277,6 +277,28 @@ apm_sram: sram@2039000 { >> ranges = <0x0 0x0 0x2039000 0x40000>; >> }; >> >> + firmware { >> + acpm_ipc: power-management { >> + compatible = "google,gs101-acpm-ipc"; >> + mboxes = <&ap2apm_mailbox 0 0 >> + &ap2apm_mailbox 0 1 >> + &ap2apm_mailbox 0 2 >> + &ap2apm_mailbox 0 3 >> + &ap2apm_mailbox 0 4 >> + &ap2apm_mailbox 0 5 >> + &ap2apm_mailbox 0 6 >> + &ap2apm_mailbox 0 7 >> + &ap2apm_mailbox 0 8 >> + &ap2apm_mailbox 0 9 >> + &ap2apm_mailbox 0 10 >> + &ap2apm_mailbox 0 11 >> + &ap2apm_mailbox 0 12 >> + &ap2apm_mailbox 0 13 >> + &ap2apm_mailbox 0 14>; >> + shmem = <&apm_sram>; >> + }; >> + }; > > You mentioned in the previous patch that "GS101 has 14 mailbox controllers", Right, I got the number from the GS101 memory map. > but here you have 15 mailboxes. I looked at the downstream driver and see the Here we have a single mailbox controller, ap2apm_mailbox, with 15 channels. > number of mailboxes is defined by the ACPM framework (firmware) which is read s/mailboxes/mailbox channels that ACPM uses/ > from SRAM initdata. Dumping that, I see there are 15 ACPM channels. Have you Correct. > looked into into extracting the data from the initdata SRAM address? > Yes, that's the reason why I defined the 15 channels from above for the ap2apm_mailbox controller. Cheers, ta