From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 322FAC433FE for ; Mon, 24 Jan 2022 09:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiAXJn4 (ORCPT ); Mon, 24 Jan 2022 04:43:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48232 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbiAXJny (ORCPT ); Mon, 24 Jan 2022 04:43:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643017434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5whi9gy34EzBT6oRXdsnI40HJtniV5XtISLyrn/RpLs=; b=Uhir02p3Liv9ZFaF036aDLpUA/HqakbGy7K74p5zlJmGoJ4WJo1S9JVXWq5rrOa3uEADta IxFBgSqUMtFkCWYv1CWQ1AX1ZpYydZXDDNZvWHgnVUo8pKmJHttVPA2vlz1ocst1CIH/4B 147Inm313vqOPZIpvl1Evw0D8ai5mhI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-26-XOep8lhpO_KTgrHmxeJ4Ow-1; Mon, 24 Jan 2022 04:43:52 -0500 X-MC-Unique: XOep8lhpO_KTgrHmxeJ4Ow-1 Received: by mail-ej1-f69.google.com with SMTP id b12-20020a17090630cc00b006a7190bdfbaso1854114ejb.18 for ; Mon, 24 Jan 2022 01:43:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=5whi9gy34EzBT6oRXdsnI40HJtniV5XtISLyrn/RpLs=; b=vgnnCNsD2MfyoUv1GwhmyRgFZH73woz5Se1A+jRILqXlEQRaRV1OKWEoBwy/UmNmSW A6GiapOAnOb0xkYb86K/VJylLXrvImmiCfrHTerbFEXdqKVyn6isA+t7nuu+GeutE+ZM zeXrGwuJ31rxmQZt5HMlmLYZpzAIa06CcN2wqjheeVR/xNM+sxY2IL6xbNURvwvXwTOp ZNnKLUx129imxSpIYx/8Wvcva7sCKcbIq/tUfa2HeJ/o1PlaAqcNpFdnkk3mNLhCcJyE U9P83nXXj079TEx7ijjcrP67mz6dgVK5ys6qZPdlCIZQrgihYl/XkudDD92Dx2iK7gWB Uzkw== X-Gm-Message-State: AOAM533hOJ48NDpc9aeAcj2zzrY3a5uSddeSdbXcN22oOQNf8i3QXb7F R+A1ja51lPPntXp2w2+Wm+zZ74YlvJWnrgQRN2yCSMVXCkJBeyyMGcKfEYTRBu2yGnzfkr3EaPO GokJPzpvO6q7YMsOKk8d4yw8j X-Received: by 2002:a05:6402:354f:: with SMTP id f15mr4093525edd.212.1643017431606; Mon, 24 Jan 2022 01:43:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrbHSLz/9hTpbyF7mWrMWTzXf6TYNvdE6O7WNdnYuPlfpzw9OQ+RpHcZ9j93eeAVLsA5Sprw== X-Received: by 2002:a05:6402:354f:: with SMTP id f15mr4093514edd.212.1643017431429; Mon, 24 Jan 2022 01:43:51 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.googlemail.com with ESMTPSA id j20sm4606280eje.81.2022.01.24.01.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jan 2022 01:43:50 -0800 (PST) Message-ID: <45a6395e-63f3-12b2-e6d1-52ccf00272e7@redhat.com> Date: Mon, 24 Jan 2022 10:43:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] gvisor: add some missing definitions to vmx.h Content-Language: en-US To: Ayush Ranjan , Thomas Gleixner Cc: Ben Gardon , Jim Mattson , Andrei Vagin , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Davidson References: <20220123195337.509882-1-ayushranjan@google.com> From: Paolo Bonzini In-Reply-To: <20220123195337.509882-1-ayushranjan@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/23/22 20:53, Ayush Ranjan wrote: > From: Michael Davidson > > gvisor needs definitions for some additional secondary exec controls. > > Tested: builds > Signed-off-by: Ayush Ranjan > Signed-off-by: Michael Davidson Incorrect order of the Signed-off-by header (author goes first, submitter goes last). > --- > arch/x86/include/asm/vmx.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h > index c77ad687cdf7..df40dc568eb9 100644 > --- a/arch/x86/include/asm/vmx.h > +++ b/arch/x86/include/asm/vmx.h > @@ -67,6 +67,7 @@ > #define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING) > #define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING) > #define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING) > +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE) > #define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX) > #define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES) > #define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC) I'm not sure why gvisor would care about an internal Linux header. gvisor should only use arch/x86/include/uapi headers. Paolo