Re:Re: [PATCH] net: macb: rate limit netdev error info print in the data path

[taozj888 <taozj888@163.com>]

Hi Theo: 

Thank you very much for your kindly reply.

For all your concerns in this mail thread and [0][1], I try to give my answers here
and hope it does not miss anything:


1. Yes, I missed the prefix [PATCH net], I will add it in my next commit; I would like to send it again as the 1st version
since I missed this needed part [PATCH net];


2. For the To/Cc list, I will use `git send-email --cc-cmd=scripts/get_maintainer.pl` as you indicated;


3. This whole patch is  NOT LLM generated, it's really a bug hit in practice, the "PHYT0036:00" 
device name is the real name that showed in our console output, I can't just imagine or made this name and it's really of out of my imagination.
 I think it may be related to a vendor with some of the PCI addr but I think it may not be polite to say it directly. 
Actually hallucinating a kernel log even a kernel patch is out of my knowledge, if you know to how and 
wish to tell me, I think it should be really interesting!


4. Why it bothered the booting process? 
In the booting process, the MACB driver received a large number of jumbo pkts that the driver can't see 
the RX_EOF  flag in the ctrl since the length of the pkt is larger than the current MTU. Those jumbo packets are 
sent by other network cards in our machine box and they are legal and used to collect information for all other cards/blades So netdev_err() 
prints a lot of error information in the console and occupied the full bandwidth of console, but other booting processes
also want to show some information in the console, and they have to wait util the whole error print of "not whole frame pointed by descriptor"
finished, so the system is delayed to be ready to the user.

5. For the severity tag and should this carry a Fixes tag and name the intended tree,  please give out a clear indication from your experiences for what I described above. I really have not too much knowledge about that.

Thanks,

Zijin Tao


At 2026-09-24 17:02:03, "Théo Lebrun" <theo.lebrun@bootlin.com> wrote:
>Hello Zijin,
>
>You missed part of my recent feedback [0][1]. Copy paste:
>
> - Also you are missing the prefix [PATCH net] or [PATCH net-next].
>   Read up about this here (and read the full page):
>   https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> - Also your To/Cc list is weird, make sure to use
>   scripts/get_maintainer.pl (or use b4 for patch
>   management which uses it automatically).
>
>In addition, make sure to read the "submitting patches" guide [2].
>You missed:
> - replying to all review points one by one using interleaved [4]
> - V2 in subject [3]
> - write up a changelog [4]
>
>Also this one is less well known, but the net subsystem (and many others
>nowadays) expect people to reply to Sashiko review emails to say
>whether they agree or disagree. Especially if they disagree. You can
>mostly skip over the pre-existing issues which don't relate to your
>series.
>
>For example Sashiko says you don't cover some log netdev_err() calls.
>You can reply explaining why only the ones you touched are important to
>deal with.
>
>--
>
>And I see just now I have in my inbox an email from you asking how to do
>it properly. Good! But it doesn't show up on lore, I'm not sure why.
>
>Replying to it here:
>
> - Don't send the same patch but slightly modified. Maintainers need to
>   know the latest version. New version means V2/V3/etc, even if
>   changes are tiny (like a typo fix in commit message).
>
> - Don't put V1 for the first revision. I think that's git-format-patch
>   default behavior.
>
> - Using git-format-patch looks something like:
>
>   ⟩ git format-patch -1 998b159fdd78 --subject-prefix="PATCH net" -v2
>   v2-0001-net-macb-take-bp-lock-around-NCR-read-modify-writ.patch
>
>   ⟩ grep ^Subject v2-0001-net-macb-take-bp-lock-around-NCR-read-modify-writ.patch
>   Subject: [PATCH net v2] net: macb: take bp->lock around NCR read-modify-writes
>
>   ⟩ scripts/get_maintainer.pl v2-0001-*.patch
>   "Théo Lebrun" <theo.lebrun@bootlin.com> (maintainer:ATMEL MACB ETHERNET DRIVER)
>   Conor Dooley <conor.dooley@microchip.com> (reviewer:ATMEL MACB ETHERNET DRIVER)
>   Andrew Lunn <andrew+netdev@lunn.ch> (maintainer:NETWORKING DRIVERS)
>   ...
>
>   I think most people call scripts/get_maintainer.pl and write the
>   git send-email --to/--cc flags by hand. I've been using b4 for a few
>   years now so I don't really know the usual git format-patch workflow.
>
>   Or you can use `git send-email --cc-cmd=scripts/get_maintainer.pl`.
>
>[0]: https://lore.kernel.org/all/DLKVCOXTNGVZ.3CC6KFXDIFJ3X@bootlin.com/
>[1]: https://lore.kernel.org/all/DLKVEXS7X14N.XLLMBDDX6ZJW@bootlin.com/
>[2]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>[3]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#subject-line
>[4]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#respond-to-review-comments
>
>Thanks,
>
>--
>Théo Lebrun, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com