From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010034.outbound.protection.outlook.com [52.101.46.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33B1C21D5AF for ; Thu, 18 Jun 2026 04:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.34 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781755782; cv=fail; b=J2ih1yC+iHIG5fHb4jj3QqTi71ZfW475TqVdqOOrIxzPWGf6LGgL5OI3lCt+DLRU/UrevBmfd5+i3zRaAvFstPVnl0NTnBsI67GzxdR3boF6SwNrR3Xz3Eg76tX+Nv4Voltyj91W6SESNkWdnP2OejWzgxoVAvTp11UZQQcyTOg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781755782; c=relaxed/simple; bh=DCKjrEGfTvIeVDPr9JmBEKKlRskOCbI6cMGX9e4Jgmc=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=G/FJoEhIqqqakF5hjuyRz2EfiIF210RPaKvDXvXA+2Wu5y4IqPM8DkzoskUTWm7zyFxEa/0hRyJ5qj1ZzrFWC8iwGJt/Ll6xTozdGgxistqzM3CZ3dVpoLPvU76/ZtpOCbJLwFvqfp4ph8mjgLPgKxub5/zkrViEKNNjkA7YIwY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=YOxBjDTX; arc=fail smtp.client-ip=52.101.46.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="YOxBjDTX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tj0x0jNzyhUwyIzU6McgQwn23e7yJ74ISiZjXTirMfTKY/FDN8fKchUXIIk8qJa3mQJ8ccYW+K4FuXWw+zBbO621uLfcxiSltmi2ofB/bDcUlRIgYDo07myF4Zw9L7NLXIrNz68tmHQhD0RbdZ+dT6fT8yHZVIkMdsb60nvoydPwGxYY+z8Mt7ZIIqlswGsN1xNkyKovgaxFy9krNATn7rmO3ux8nXap22mr33Mc3Xw0rzcVQuJThl2mZU+BMFhau03eKbeBpxKpXIVuvVDEVaenEWf/owujCeGCOLNUyd2gOd0s76YsRKFvJUK9eqzvEH2ZHLt7QlqEnagEiMyYTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kEtMInkWJgztagP/C+7lA/inWGB77sJNPrbimVLmy30=; b=ON/8jC6kC9u0+ocarVa7k0K70g0kr81T32rhkzWWpZWiEACc8TPm2luMT+tBfb9zVwgPGR1496XQ3JGDFlZ8Z3FW63TbDI0O0VBmmia8iwe6Nuz578iUVj8o5qX3V56z6Qi6sX0/WNVtETpp7syaHm9OcdUCvirJRd9ejX++RXL2L3WqNsfFxEuPfw1u3+GbEg1X3MESI/AZ95h4HHJVDud7fuSzK5KqGRJctWruesCdWSsnWBqLMEg+JJe6pytWSokSDKtGqBzwB6wDSY1hPakg71hmzUDNigsqkQueYVa6aZJxRLZk2cWyAz9nuuw7y2EEoLqx+ZbDFFpXjRT72A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kEtMInkWJgztagP/C+7lA/inWGB77sJNPrbimVLmy30=; b=YOxBjDTXZqkyEHjE6YfrYrfURvQsSXZ+9Lz6+h0gUp4F27X4ksY2wpdCM88UG89vC4PaY1vLmtQ2t195tI9G+FdHO+/x7LDWAak7yqPV6DYZEHeilScwnQjmyU4irdLlDalkL57Pk+GtKbxeJR2s+aZXQl3o2psuymyi7Gaz6/8= Received: from PH8P223CA0017.NAMP223.PROD.OUTLOOK.COM (2603:10b6:510:2db::9) by CH3PR12MB8851.namprd12.prod.outlook.com (2603:10b6:610:180::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.11; Thu, 18 Jun 2026 04:09:34 +0000 Received: from CY4PEPF0000FCBF.namprd03.prod.outlook.com (2603:10b6:510:2db:cafe::3a) by PH8P223CA0017.outlook.office365.com (2603:10b6:510:2db::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.139.12 via Frontend Transport; Thu, 18 Jun 2026 04:09:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000FCBF.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.8 via Frontend Transport; Thu, 18 Jun 2026 04:09:33 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 17 Jun 2026 23:09:32 -0500 Received: from satlexmb07.amd.com (10.181.42.216) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 17 Jun 2026 21:09:32 -0700 Received: from [10.136.46.240] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Wed, 17 Jun 2026 23:09:24 -0500 Message-ID: <45ad6ca0-0ce9-4b32-9660-3d4afffca607@amd.com> Date: Thu, 18 Jun 2026 09:39:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 10/20] sched/core: Push current task from non preferred CPU To: Shrikanth Hegde , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , , References: <20260617174139.155540-1-sshegde@linux.ibm.com> <20260617174139.155540-11-sshegde@linux.ibm.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260617174139.155540-11-sshegde@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCBF:EE_|CH3PR12MB8851:EE_ X-MS-Office365-Filtering-Correlation-Id: 4082d409-6b35-4fcc-2563-08deccef6780 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|36860700016|1800799024|82310400026|56012099006|11063799006|22082099003|18002099003|4143699003; X-Microsoft-Antispam-Message-Info: a4tArfy6qNu1Q9nXz5qW8a8dFddclstkt2jHMcoTlB8hdpo0dIoRO7R+M/xXPw9E8lCl5KgTqs5tNlOt56CsALkTlthPIqBqpzaPXbFkCm7G6t+R6NmZaeSP2GqEKu4qaQqFH8B26S+Mk5Ljb82zSK7tz9HkDjBxGhCNO0BPQdor87A3jKvKCR3G4lcg3e0k2wYzq4ODEoEKmJ6hA+dZ9O1iFzAsVlFHfjN5BmaCkh3mwYQkAbhJoas3HYXcIC8/wkNEZOfw5xqqJmWtUn/msTZAO73D+PPGpofVuEiayKVWUr1L6qGBze3ZZw31ixxFxIshtdIqf3jMS2/cr73IQ9vhfBdemFZ9RM7tMUVY8xSPotKlW0nRi5VYYsMbwyKAjIIRHv8vIt1rQvfqJQBRUDANBZgqT8iV2rci6no5MCmjbQ7eEHp4BwXV1QqvRFim0ZGqTZ7lHM7lDFMMFQzn261mtDg1GJsGZVCfW4/ciQVZNicHILqnlCEYagq/7NcU+uMXnwCSCVATbDkpbD8bneeK3Vh/hDVj75Jju6hLVabDhUsj2lhWsHYjIrougy25UnxQFayU1Upq35vzzDdrmFIK0hwDOpQk7FUsYYDrcZtXDQ38e0NuOD5pmjiImp/9mQBTO7w9aUqIarczA3eK9JeP5KGpHLB/8jPUmV+0oRg11x5soEI/rS7IsI77rHA0S5fSr909oLc6y4gkmVy0mXqwaWggdKv08Kx3j7FrUMM= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(36860700016)(1800799024)(82310400026)(56012099006)(11063799006)(22082099003)(18002099003)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: nNcaOcuV90vt5vV4lew+GItdF6excAfLuU/aLyqfLYGGQF6qZYa7jMUTWAi1eEvD3FtJImG/8i/UhHjFY/rpWoyZWr8f/Fn/dCxAMHHJ4AE4gPmYZcYSc5yPqFC730thgU3WZOe4H6sHble+DOJQwuHebLQuefgI3VFSYYI6aToDIze051SdJPG/M0nZUCB/nNZeuQhv/ihC39I14nrfDnQxtKqUf054ejFHJA1VwsrhsEK2kgxRUOrlWmrf0GcJuP8UpLyKIivExLf8vfermRKCNMVOBJ/n7sGVLqUtaGz9shAOCA5/eIAW6j0UbaUfFQobIrUS93P7LwRifmcHBKXY1dgnCRpakxTd1P+Dq+4P4qDJaQRzh9ggW25kVyaDgUPqj/xFyYqrkxSggSARBXuSvW1ufH/VULGzB56eJGueySpk54v6YHCMxX4Hzy+W X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2026 04:09:33.7997 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4082d409-6b35-4fcc-2563-08deccef6780 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCBF.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8851 Hello Shrikanth, On 6/17/2026 11:11 PM, Shrikanth Hegde wrote: > +static int sched_non_preferred_cpu_push_stop(void *arg) > +{ > + struct task_struct *p = arg; > + struct rq *rq = this_rq(); > + struct rq_flags rf; > + int cpu; > + > + /* sanity check */ > + if (cpu_preferred(rq->cpu)) > + return 0; I think this early return path should also clear "push_task_work_done" indicator, otherwise, we will fail to schedule the stopper on this CPU next time. Also, we may need to add a context_unsafe_alias(rq) call here to keep the context analysis bits happy similar to migration_cpu_stop(). > + > + raw_spin_lock_irq(&p->pi_lock); > + rq_lock(rq, &rf); > + rq->push_task_work_done = 0; > + > + update_rq_clock(rq); > + > + if (task_rq(p) == rq && task_on_rq_queued(p)) { > + cpu = select_fallback_rq(rq->cpu, p); Do we need a task_has_preferred_cpus() sanity check here? If the affinity changed before the stopper grabbed the p->pi_lock, and there are no preferred CPUs to run on anymore, might as well keep the task here instead of migrating it away. > + rq = __migrate_task(rq, &rf, p, cpu); > + } > + > + rq_unlock(rq, &rf); > + raw_spin_unlock_irq(&p->pi_lock); > + put_task_struct(p); > + > + return 0; > +} -- Thanks and Regards, Prateek