From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CED79EE8012 for ; Fri, 8 Sep 2023 15:15:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244360AbjIHPPf (ORCPT ); Fri, 8 Sep 2023 11:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243466AbjIHPPe (ORCPT ); Fri, 8 Sep 2023 11:15:34 -0400 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 803981BFF for ; Fri, 8 Sep 2023 08:15:25 -0700 (PDT) Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 388FDKDC003908; Fri, 8 Sep 2023 10:15:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= PODMain02222019; bh=Nl/uBp4wjE95CikGacqAFgHKmdDa16tkvVJ9n7LfcNo=; b= DOY3LmVvKFRD376j4OBtqCUqawGgi35gQJplpiku6k7SzL9WWlIlgCLzxA37aV0C Dmj+cNjtDd8K4i9E8uq1FGhRnrffJckGcQ493bAeHBrCxePRZg9DsriAK2Ef00s+ yw39tzxw8qIQD8Fi8xhNmImdbZgrzaLC3/gdPZjkVR3GmiChcHOg2f0jdSJ0zKob FhOKwpJPEbhixCmvXD3SqSS4kXICwdKct/RrI9PZADtBd//ONpZ7AJUfG65rpND+ 4mLjHROtFIuhACqEmRwhufjv5zMD0stkpWacelyc9RwSUbRfrWkmHvJR+AFU8Fnf k7rNex03Hw7mRSMNJMn8EA== Received: from ediex02.ad.cirrus.com ([84.19.233.68]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 3t04h1g47u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 08 Sep 2023 10:15:07 -0500 (CDT) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Fri, 8 Sep 2023 16:15:05 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Fri, 8 Sep 2023 16:15:05 +0100 Received: from [141.131.78.121] (unknown [141.131.78.121]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 477D646B; Fri, 8 Sep 2023 15:15:03 +0000 (UTC) Message-ID: <45aef3e9-b6ee-ba26-32ac-ea72f41d1dcb@opensource.cirrus.com> Date: Fri, 8 Sep 2023 10:15:02 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 04/11] ASoC: cs35l41: Fix broken shared boost activation Content-Language: en-US To: Cristian Ciocaltea , James Schulman , David Rhodes , "Richard Fitzgerald" , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , "Mark Brown" , Stefan Binding , Charles Keepax , Vitaly Rodionov CC: , , , References: <20230907171010.1447274-1-cristian.ciocaltea@collabora.com> <20230907171010.1447274-5-cristian.ciocaltea@collabora.com> From: "Rhodes, David" In-Reply-To: <20230907171010.1447274-5-cristian.ciocaltea@collabora.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: b6SePw-5IJcI2he5GkY83X12Y3AsL7Qp X-Proofpoint-GUID: b6SePw-5IJcI2he5GkY83X12Y3AsL7Qp X-Proofpoint-Spam-Reason: safe Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/23 12:10 PM, Cristian Ciocaltea wrote: > Enabling the active/passive shared boosts requires setting SYNC_EN, but > *not* before receiving the PLL Lock signal. > > Solve the issue by setting the SYNC_EN bit in PWR_CTRL3 register right > after receiving the PLL Lock interrupt. > > Additionally, drop the unnecessary writes to PWR_CTRL1 register, part of > the original mdsync_up_seq, which would have toggled GLOBAL_EN with > unwanted consequences on PLL locking behavior. > > Fixes: f5030564938b ("ALSA: cs35l41: Add shared boost feature") > Signed-off-by: Cristian Ciocaltea > --- Looks good. If it's convenient to revise again, I think you could slim down the comment section by simply stating that 'PLL Lock requires the audio clocks to be active' (which is why it is not triggered until after snd_pcm_start). Reviewed-by: David Rhodes Thanks, David