From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010066.outbound.protection.outlook.com [52.101.61.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 998E82F12DA for ; Wed, 25 Mar 2026 18:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.61.66 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464386; cv=fail; b=I1KT+4eb3SLC0tazDK/S0eznla7Z89+j73heVdTDwrEaKr9eXEPloizhmKNNSu4qvsTovJbXZe8DbVW1B/QxR3lPl4ITNvARo4FfFUGkN1Eb3PsBP8l/eGlQ2G/2Y/kpUCfMm5XikYF8eVN2LR2Y8ZnfTkid29jGI+lhASWtGdk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774464386; c=relaxed/simple; bh=7L/8ibTA6oIubHskwpr0aOrckVvReULSSz7/dPkBkhQ=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IDffMYUrentbsb0vwRIO8/PuzOnfyJ/8VQn96YRcUhh4P+OJ9T38Yh4E3tKbLidKMyvqod1OOu+aBJ+tYaQVouhl/gGtuK1qN1AMqajUNwXhMXMF9moroKuJsUEhcrS/e7MhIvp2t2U1N0uX4V+TDNcNJjzzaAfdTJL+kx6vmn0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=GdfpSDhg; arc=fail smtp.client-ip=52.101.61.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="GdfpSDhg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BXZelXaZ4KrvmbwkInFJf6eyrYnVdBRQkrDp07VEB1YP+QnUNgGkVqoa/QAr/chwodZ0iXHCGKN35MzLoIIQUh1SCUwB3r9o7CK0aOY44WPClqok8zfrc4qmPMx2xsrWuXhz3ryF3C0Id1c94CBPI4oayZolmMQK8SJexqAGcl4V2Z98XvqBm7IHdaT6vNWpIaanEG+90B1FJIA9DHQ8XS8JCpcTx95q48WykJ61RmOk4IBPKI3Gnit/isbuI645fVw122xxdaPlmBFnBoPEdeedaSCUPhcYUpa2gTdr/CKS2EI2TBGcKYjOqjhaRHFe8l9svpgkdN/haWs+poxCig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=toA0A9BEpHVAgD8Y3AnVEOvDpaWh6NTLUD2L4DGLsWM=; b=SvgKiqGlbab0WIGIUbDDufDaXSM2DBHucjfziwvGjpQcyX7wwnx24otKqXSv7tVmzxfLm0Dk2pvwLg6Sx6iskL0g+HbkywuAtRJT6gq6Yg3gKqMWBdBl06keT1KLAlpOZD6Lom12LCF/CZwlGaMy2y/rbxrKuHpIlDSq/L60ZYxcXaPR5Ss3QR5kJbgXf+XcQZZNMFFUYh49VGkazaSF5v3lqZ2GniCDFfYDAZhyZh2CIiIzje32U+gqLxT0RUp83KLjbJHRnkKDMB1XBToz1TSuUf1k9rVgD5GQ+Rzfk2akL6QLKYkAK+zyXgJXqnPkAVEaAyFp++RUIyZVGGyMtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=toA0A9BEpHVAgD8Y3AnVEOvDpaWh6NTLUD2L4DGLsWM=; b=GdfpSDhgDVhNOdahlcl0rFMJBGWdonNEYD8MdZ6FfAqtwuL6nRsUKuPm26eSQQIYYEmfR9WXs6XGmFvuXMP2bqfu21wm61Olq+Hj7gAFBYNKOqitj7uiVw2pOSqcJRyqIzIkCtjf5T/dkQBgi3p0/93bhzVNZsYUiazRnGx8uqI= Received: from BY3PR04CA0023.namprd04.prod.outlook.com (2603:10b6:a03:217::28) by MN0PR12MB6248.namprd12.prod.outlook.com (2603:10b6:208:3c0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Wed, 25 Mar 2026 18:46:16 +0000 Received: from SJ1PEPF000026C7.namprd04.prod.outlook.com (2603:10b6:a03:217:cafe::63) by BY3PR04CA0023.outlook.office365.com (2603:10b6:a03:217::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9723.31 via Frontend Transport; Wed, 25 Mar 2026 18:46:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by SJ1PEPF000026C7.mail.protection.outlook.com (10.167.244.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.21 via Frontend Transport; Wed, 25 Mar 2026 18:46:16 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 25 Mar 2026 13:46:13 -0500 Received: from [172.19.71.207] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Wed, 25 Mar 2026 13:46:13 -0500 Message-ID: <45bc86ee-cc0f-2b99-f876-9e8861be365e@amd.com> Date: Wed, 25 Mar 2026 11:46:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V1] accel/amdxdna: Add per-process BO memory usage query support Content-Language: en-US To: Mario Limonciello , , , , CC: Max Zhen , , References: <20260324163159.2425461-1-lizhi.hou@amd.com> <1e573513-b281-4ae3-9140-7a87ee9dab08@amd.com> From: Lizhi Hou In-Reply-To: <1e573513-b281-4ae3-9140-7a87ee9dab08@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C7:EE_|MN0PR12MB6248:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a62ea30-97b3-4a75-89a7-08de8a9ecbea X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700016|82310400026|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: dzDjBNUusz9JMstq0rqEKuagBYiwTCBTOevlu8DQ/2rs6rYSgHeJrHSP0naJ4ez/8/1k6YYSfR80Ju2+80vp5It3b0zBRN4LgX8P/eFR7ChlAQ6r+Cq+cYrpO6Sc9VwJ7Ubr/QcOxZuMEFgiC3+wYqmdqt8nDL9az693cLnsfLOJiyuw4qWw3Tcey6L0DR7f4YN6xG82R0mWm5g0F43n5VbIuds6GjioEx7gu0NAkNSKREnY7MXFCgKKBsMbc7etau3H/rVd29i1Amod2Z7M8k3mBTrmJUQnV/Uzh78UywWvZIY0GlhS4sOFDgBlKRPeVfC+Q16YlP/yUDy0wBM7zr7xBDlhBtTK659fKTjQVaBsEUwjr16w8hDgKTMpEsDEt993uHHDRkwYIfLQu814NZLkax0gLcpinKwFbSCZSHsSny1xAHQj9UPMNsYknCel62Wjx73nN82y2lUZouRhmQuivQ0926upE+0mlb22iUBtK/qTuRd9IlU3a0dzWLLVq0HVthgwqU2MQcJm3zv0nz6sHQ7B08/3quAFhWSjukm0NSKd+gG2XDGt2oVJoY6pJs5aDRoCgyJ6WVqjTh+0Nt4NGOpjZl99Eu6lYh7/GJHpR8kzHgVK+De1BkZAx/6dKL9CR5zDMXrcRigJ47CFZQdwK432CZzKIzLxWjx2hKYX550lauhrbjXzkKjlwq2uvPrflagAufu3V9inf/f8UqFZkeYivg92YGngEJSMkaIoIsfU0p+11uFIYUX/JOiiekTepa3sloZD2AWxyqVjXA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700016)(82310400026)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bujNFmJ2GvgOl4yB++siMn2cg3pFydL5exm3fVPJiO60aIn3TnMDv6Ad8Q5NZiBcrY5w+SMmdIg98iAq9cs0ZnMCb0ow0jL6BLXXxOdJyRIflkaP476mzDIbI5BMHEiRhaKSy+Ry97uEaSSnPamBxkKNMTMpbqkvruTRGIJVr74YSaN8Mp1tGRneHttTFXSuXAbU2nM/rq4yvlLzSMxlZKzWFYQhsHE7ppfGXK6fWEAm7xq8BG8QrSROzYgzwRj/9J/HzVMJr6n0VRyB28+VRWxzvvhOxo3PaEHafBNzHHg9Uxk1K1mWtIjcFAM1k9c58Y2fYQC6O64LPdHyPM5NN8/KJh6e6/fXr8WY3EoxRW50fw8YoR70bmzSAfFbAxjysHF8zi5/n12OKQ39OIfVs8inOmutMzoWwudwk3NtSTr/Iw7pijhGfmv41ciHRmgu X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2026 18:46:16.2420 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a62ea30-97b3-4a75-89a7-08de8a9ecbea X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF000026C7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6248 Applied to drm-misc-next. On 3/24/26 10:01, Mario Limonciello wrote: > > > On 3/24/26 11:31, Lizhi Hou wrote: >> From: Max Zhen >> >> Add support for querying per-process buffer object (BO) memory >> usage through the amdxdna GET_ARRAY UAPI. >> >> Introduce a new query type, DRM_AMDXDNA_BO_USAGE, along with >> struct amdxdna_drm_bo_usage to report BO memory usage statistics, >> including heap, total, and internal usage. >> >> Track BO memory usage on a per-client basis by maintaining counters >> in GEM open/close and heap allocation/free paths. This ensures the >> reported statistics reflect the current memory footprint of each >> process. >> >> Wire the new query into the GET_ARRAY implementation to expose >> the usage information to userspace. >> >> Signed-off-by: Max Zhen >> Reviewed-by: Lizhi Hou >> Signed-off-by: Lizhi Hou > I'm assuming you also have userspace side ready for this too right? > If you have a link handy can you please include it when committing. > > Reviewed-by: Mario Limonciello (AMD) > >> --- >>   drivers/accel/amdxdna/aie2_pci.c        |   4 + >>   drivers/accel/amdxdna/amdxdna_gem.c     | 134 ++++++++++++++++++++++-- >>   drivers/accel/amdxdna/amdxdna_gem.h     |   7 +- >>   drivers/accel/amdxdna/amdxdna_pci_drv.c |   6 +- >>   drivers/accel/amdxdna/amdxdna_pci_drv.h |   4 + >>   include/uapi/drm/amdxdna_accel.h        |  35 +++++++ >>   6 files changed, 177 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/accel/amdxdna/aie2_pci.c >> b/drivers/accel/amdxdna/aie2_pci.c >> index 9e39bfe75971..f1ac4e00bd9f 100644 >> --- a/drivers/accel/amdxdna/aie2_pci.c >> +++ b/drivers/accel/amdxdna/aie2_pci.c >> @@ -865,6 +865,7 @@ static int aie2_hwctx_status_cb(struct >> amdxdna_hwctx *hwctx, void *arg) >>       tmp->command_submissions = hwctx->priv->seq; >>       tmp->command_completions = hwctx->priv->completed; >>       tmp->pasid = hwctx->client->pasid; >> +    tmp->heap_usage = hwctx->client->heap_usage; >>       tmp->priority = hwctx->qos.priority; >>       tmp->gops = hwctx->qos.gops; >>       tmp->fps = hwctx->qos.fps; >> @@ -1148,6 +1149,9 @@ static int aie2_get_array(struct amdxdna_client >> *client, >>       case DRM_AMDXDNA_HW_LAST_ASYNC_ERR: >>           ret = aie2_get_array_async_error(xdna->dev_handle, args); >>           break; >> +    case DRM_AMDXDNA_BO_USAGE: >> +        ret = amdxdna_drm_get_bo_usage(&xdna->ddev, args); >> +        break; >>       default: >>           XDNA_ERR(xdna, "Not supported request parameter %u", >> args->param); >>           ret = -EOPNOTSUPP; >> diff --git a/drivers/accel/amdxdna/amdxdna_gem.c >> b/drivers/accel/amdxdna/amdxdna_gem.c >> index 27712704e42d..238ee244d4a6 100644 >> --- a/drivers/accel/amdxdna/amdxdna_gem.c >> +++ b/drivers/accel/amdxdna/amdxdna_gem.c >> @@ -63,6 +63,8 @@ amdxdna_gem_heap_alloc(struct amdxdna_gem_obj *abo) >>           goto unlock_out; >>       } >>   +    client->heap_usage += mem->size; >> + >>       drm_gem_object_get(to_gobj(heap)); >>     unlock_out: >> @@ -74,16 +76,17 @@ amdxdna_gem_heap_alloc(struct amdxdna_gem_obj *abo) >>   static void >>   amdxdna_gem_heap_free(struct amdxdna_gem_obj *abo) >>   { >> +    struct amdxdna_client *client = abo->client; >>       struct amdxdna_gem_obj *heap; >>   -    mutex_lock(&abo->client->mm_lock); >> +    mutex_lock(&client->mm_lock); >>         drm_mm_remove_node(&abo->mm_node); >> - >> -    heap = abo->client->dev_heap; >> +    client->heap_usage -= abo->mem.size; >> +    heap = client->dev_heap; >>       drm_gem_object_put(to_gobj(heap)); >>   -    mutex_unlock(&abo->client->mm_lock); >> +    mutex_unlock(&client->mm_lock); >>   } >>     static struct amdxdna_gem_obj * >> @@ -102,6 +105,8 @@ amdxdna_gem_create_obj(struct drm_device *dev, >> size_t size) >>       abo->mem.dma_addr = AMDXDNA_INVALID_ADDR; >>       abo->mem.uva = AMDXDNA_INVALID_ADDR; >>       abo->mem.size = size; >> +    abo->open_ref = 0; >> +    abo->internal = false; >>       INIT_LIST_HEAD(&abo->mem.umap_list); >>         return abo; >> @@ -508,13 +513,55 @@ static void amdxdna_imported_obj_free(struct >> amdxdna_gem_obj *abo) >>       kfree(abo); >>   } >>   +static inline bool >> +amdxdna_gem_skip_bo_usage(struct amdxdna_gem_obj *abo) >> +{ >> +    /* Do not count imported BOs since the buffer is not allocated >> by us. */ >> +    if (is_import_bo(abo)) >> +        return true; >> + >> +    /* Already counted as part of HEAP BO */ >> +    if (abo->type == AMDXDNA_BO_DEV) >> +        return true; >> + >> +    return false; >> +} >> + >> +static void >> +amdxdna_gem_add_bo_usage(struct amdxdna_gem_obj *abo) >> +{ >> +    struct amdxdna_client *client = abo->client; >> + >> +    if (amdxdna_gem_skip_bo_usage(abo)) >> +        return; >> + >> +    guard(mutex)(&client->mm_lock); >> + >> +    client->total_bo_usage += abo->mem.size; >> +    if (abo->internal) >> +        client->total_int_bo_usage += abo->mem.size; >> +} >> + >> +static void >> +amdxdna_gem_del_bo_usage(struct amdxdna_gem_obj *abo) >> +{ >> +    struct amdxdna_client *client = abo->client; >> + >> +    if (amdxdna_gem_skip_bo_usage(abo)) >> +        return; >> + >> +    guard(mutex)(&client->mm_lock); >> + >> +    client->total_bo_usage -= abo->mem.size; >> +    if (abo->internal) >> +        client->total_int_bo_usage -= abo->mem.size; >> +} >> + >>   static void amdxdna_gem_obj_free(struct drm_gem_object *gobj) >>   { >>       struct amdxdna_dev *xdna = to_xdna_dev(gobj->dev); >>       struct amdxdna_gem_obj *abo = to_xdna_obj(gobj); >>   -    XDNA_DBG(xdna, "BO type %d xdna_addr 0x%llx", abo->type, >> amdxdna_gem_dev_addr(abo)); >> - >>       amdxdna_hmm_unregister(abo, NULL); >>       flush_workqueue(xdna->notifier_wq); >>   @@ -543,9 +590,13 @@ static int amdxdna_gem_obj_open(struct >> drm_gem_object *gobj, struct drm_file *fi >>       int ret; >>         guard(mutex)(&abo->lock); >> +    abo->open_ref++; >>   -    if (!abo->client) >> +    if (abo->open_ref == 1) { >> +        /* Attached to the client when first opened by it. */ >>           abo->client = filp->driver_priv; >> +        amdxdna_gem_add_bo_usage(abo); >> +    } >>       if (amdxdna_iova_on(xdna)) { >>           ret = amdxdna_iommu_map_bo(xdna, abo); >>           if (ret) >> @@ -555,6 +606,20 @@ static int amdxdna_gem_obj_open(struct >> drm_gem_object *gobj, struct drm_file *fi >>       return 0; >>   } >>   +static void amdxdna_gem_obj_close(struct drm_gem_object *gobj, >> struct drm_file *filp) >> +{ >> +    struct amdxdna_gem_obj *abo = to_xdna_obj(gobj); >> + >> +    guard(mutex)(&abo->lock); >> +    abo->open_ref--; >> + >> +    if (abo->open_ref == 0) { >> +        amdxdna_gem_del_bo_usage(abo); >> +        /* Detach from the client when last closed by it. */ >> +        abo->client = NULL; >> +    } >> +} >> + >>   static int amdxdna_gem_dev_obj_vmap(struct drm_gem_object *obj, >> struct iosys_map *map) >>   { >>       struct amdxdna_gem_obj *abo = to_xdna_obj(obj); >> @@ -575,6 +640,7 @@ static const struct drm_gem_object_funcs >> amdxdna_gem_dev_obj_funcs = { >>   static const struct drm_gem_object_funcs amdxdna_gem_shmem_funcs = { >>       .free = amdxdna_gem_obj_free, >>       .open = amdxdna_gem_obj_open, >> +    .close = amdxdna_gem_obj_close, >>       .print_info = drm_gem_shmem_object_print_info, >>       .pin = drm_gem_shmem_object_pin, >>       .unpin = drm_gem_shmem_object_unpin, >> @@ -708,10 +774,13 @@ amdxdna_drm_create_share_bo(struct drm_device >> *dev, >>       if (IS_ERR(abo)) >>           return ERR_CAST(abo); >>   -    if (args->type == AMDXDNA_BO_DEV_HEAP) >> +    if (args->type == AMDXDNA_BO_DEV_HEAP) { >>           abo->type = AMDXDNA_BO_DEV_HEAP; >> -    else >> +        abo->internal = true; >> +    } else { >>           abo->type = AMDXDNA_BO_SHARE; >> +        abo->internal = args->type == AMDXDNA_BO_CMD; >> +    } >>         return abo; >>   } >> @@ -783,6 +852,11 @@ amdxdna_drm_create_dev_bo(struct drm_device *dev, >>       gobj = to_gobj(abo); >>       gobj->funcs = &amdxdna_gem_dev_obj_funcs; >>       abo->type = AMDXDNA_BO_DEV; >> +    abo->internal = true; >> +    /* >> +     * DEV BOs cannot be alive when client is gone, it's OK to >> +     * always establish the connection. >> +     */ >>       abo->client = client; >>         ret = amdxdna_gem_heap_alloc(abo); >> @@ -826,7 +900,7 @@ int amdxdna_drm_create_bo_ioctl(struct drm_device >> *dev, void *data, struct drm_f >>       if (IS_ERR(abo)) >>           return PTR_ERR(abo); >>   -    /* ready to publish object to userspace */ >> +    /* Ready to publish object to userspace and count for BO usage. */ >>       ret = drm_gem_handle_create(filp, to_gobj(abo), &args->handle); >>       if (ret) { >>           XDNA_ERR(xdna, "Create handle failed"); >> @@ -986,3 +1060,43 @@ int amdxdna_drm_sync_bo_ioctl(struct drm_device >> *dev, >>       drm_gem_object_put(gobj); >>       return ret; >>   } >> + >> +int amdxdna_drm_get_bo_usage(struct drm_device *dev, struct >> amdxdna_drm_get_array *args) >> +{ >> +    size_t min_sz = min(args->element_size, sizeof(struct >> amdxdna_drm_bo_usage)); >> +    char __user *buf = u64_to_user_ptr(args->buffer); >> +    struct amdxdna_dev *xdna = to_xdna_dev(dev); >> +    struct amdxdna_client *tmp_client; >> +    struct amdxdna_drm_bo_usage tmp; >> + >> +    drm_WARN_ON(dev, !mutex_is_locked(&xdna->dev_lock)); >> + >> +    if (args->num_element != 1) >> +        return -EINVAL; >> + >> +    if (copy_from_user(&tmp, buf, min_sz)) >> +        return -EFAULT; >> + >> +    if (!tmp.pid) >> +        return -EINVAL; >> + >> +    tmp.total_usage = 0; >> +    tmp.internal_usage = 0; >> +    tmp.heap_usage = 0; >> + >> +    list_for_each_entry(tmp_client, &xdna->client_list, node) { >> +        if (tmp.pid != tmp_client->pid) >> +            continue; >> + >> +        mutex_lock(&tmp_client->mm_lock); >> +        tmp.total_usage += tmp_client->total_bo_usage; >> +        tmp.internal_usage += tmp_client->total_int_bo_usage; >> +        tmp.heap_usage += tmp_client->heap_usage; >> +        mutex_unlock(&tmp_client->mm_lock); >> +    } >> + >> +    if (copy_to_user(buf, &tmp, min_sz)) >> +        return -EFAULT; >> + >> +    return 0; >> +} >> diff --git a/drivers/accel/amdxdna/amdxdna_gem.h >> b/drivers/accel/amdxdna/amdxdna_gem.h >> index a77d9344f8a4..4fc48a1189d2 100644 >> --- a/drivers/accel/amdxdna/amdxdna_gem.h >> +++ b/drivers/accel/amdxdna/amdxdna_gem.h >> @@ -41,8 +41,9 @@ struct amdxdna_gem_obj { >>       struct amdxdna_client        *client; >>       u8                type; >>       bool                pinned; >> -    struct mutex            lock; /* Protects: pinned, mem.kva */ >> +    struct mutex            lock; /* Protects: pinned, mem.kva, >> open_ref */ >>       struct amdxdna_mem        mem; >> +    int                open_ref; >>         /* Below members are initialized when needed */ >>       struct drm_mm            mm; /* For AMDXDNA_BO_DEV_HEAP */ >> @@ -50,6 +51,9 @@ struct amdxdna_gem_obj { >>       u32                assigned_hwctx; >>       struct dma_buf            *dma_buf; >>       struct dma_buf_attachment    *attach; >> + >> +    /* True, if BO is managed by XRT, not application */ >> +    bool                internal; >>   }; >>     #define to_gobj(obj)    (&(obj)->base.base) >> @@ -98,5 +102,6 @@ void amdxdna_gem_unpin(struct amdxdna_gem_obj *abo); >>   int amdxdna_drm_create_bo_ioctl(struct drm_device *dev, void *data, >> struct drm_file *filp); >>   int amdxdna_drm_get_bo_info_ioctl(struct drm_device *dev, void >> *data, struct drm_file *filp); >>   int amdxdna_drm_sync_bo_ioctl(struct drm_device *dev, void *data, >> struct drm_file *filp); >> +int amdxdna_drm_get_bo_usage(struct drm_device *dev, struct >> amdxdna_drm_get_array *args); >>     #endif /* _AMDXDNA_GEM_H_ */ >> diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.c >> b/drivers/accel/amdxdna/amdxdna_pci_drv.c >> index d83be00daf2b..b50a7d1f8a11 100644 >> --- a/drivers/accel/amdxdna/amdxdna_pci_drv.c >> +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.c >> @@ -36,9 +36,10 @@ MODULE_FIRMWARE("amdnpu/17f0_11/npu_7.sbin"); >>    * 0.5: Support getting telemetry data >>    * 0.6: Support preemption >>    * 0.7: Support getting power and utilization data >> + * 0.8: Support BO usage query >>    */ >>   #define AMDXDNA_DRIVER_MAJOR        0 >> -#define AMDXDNA_DRIVER_MINOR        7 >> +#define AMDXDNA_DRIVER_MINOR        8 >>     /* >>    * Bind the driver base on (vendor_id, device_id) pair and later >> use the >> @@ -120,11 +121,12 @@ static void amdxdna_client_cleanup(struct >> amdxdna_client *client) >>       amdxdna_hwctx_remove_all(client); >>       xa_destroy(&client->hwctx_xa); >>       cleanup_srcu_struct(&client->hwctx_srcu); >> -    mutex_destroy(&client->mm_lock); >>         if (client->dev_heap) >>           drm_gem_object_put(to_gobj(client->dev_heap)); >>   +    mutex_destroy(&client->mm_lock); >> + >>       if (!IS_ERR_OR_NULL(client->sva)) >>           iommu_sva_unbind_device(client->sva); >>       mmdrop(client->mm); >> diff --git a/drivers/accel/amdxdna/amdxdna_pci_drv.h >> b/drivers/accel/amdxdna/amdxdna_pci_drv.h >> index e91d14ae5190..0661749917d6 100644 >> --- a/drivers/accel/amdxdna/amdxdna_pci_drv.h >> +++ b/drivers/accel/amdxdna/amdxdna_pci_drv.h >> @@ -138,6 +138,10 @@ struct amdxdna_client { >>       struct iommu_sva        *sva; >>       int                pasid; >>       struct mm_struct        *mm; >> + >> +    size_t                heap_usage; >> +    size_t                total_bo_usage; >> +    size_t                total_int_bo_usage; >>   }; >>     #define amdxdna_for_each_hwctx(client, hwctx_id, entry)        \ >> diff --git a/include/uapi/drm/amdxdna_accel.h >> b/include/uapi/drm/amdxdna_accel.h >> index bddaaaf945cf..61d3686fa3b1 100644 >> --- a/include/uapi/drm/amdxdna_accel.h >> +++ b/include/uapi/drm/amdxdna_accel.h >> @@ -591,8 +591,37 @@ struct amdxdna_async_error { >>       __u64 ex_err_code; >>   }; >>   +/** >> + * struct amdxdna_drm_bo_usage - all types of BO usage >> + * BOs managed by XRT/SHIM/driver is counted as internal. >> + * Others are counted as external which are managed by applications. >> + * >> + * Among all types of BOs: >> + *   AMDXDNA_BO_DEV_HEAP - is counted for internal. >> + *   AMDXDNA_BO_SHARE    - is counted for external. >> + *   AMDXDNA_BO_CMD      - is counted for internal. >> + *   AMDXDNA_BO_DEV      - is counted by heap_usage only, not internal >> + *                         or external. It does not add to the total >> memory >> + *                         footprint since its mem comes from heap >> which is >> + *                         already counted as internal. >> + */ >> +struct amdxdna_drm_bo_usage { >> +    /** @pid: The ID of the process to query from. */ >> +    __s64 pid; >> +    /** @total_usage: Total BO size used by process. */ >> +    __u64 total_usage; >> +    /** @internal_usage: Total internal BO size used by process. */ >> +    __u64 internal_usage; >> +    /** @heap_usage: Total device BO size used by process. */ >> +    __u64 heap_usage; >> +}; >> + >> +/* >> + * Supported params in struct amdxdna_drm_get_array >> + */ >>   #define DRM_AMDXDNA_HW_CONTEXT_ALL    0 >>   #define DRM_AMDXDNA_HW_LAST_ASYNC_ERR    2 >> +#define DRM_AMDXDNA_BO_USAGE        6 >>     /** >>    * struct amdxdna_drm_get_array - Get information array. >> @@ -605,6 +634,12 @@ struct amdxdna_drm_get_array { >>        * >>        * %DRM_AMDXDNA_HW_CONTEXT_ALL: >>        * Returns all created hardware contexts. >> +     * >> +     * %DRM_AMDXDNA_HW_LAST_ASYNC_ERR: >> +     * Returns last async error. >> +     * >> +     * %DRM_AMDXDNA_BO_USAGE: >> +     * Returns usage of heap/internal/external BOs. >>        */ >>       __u32 param; >>       /** >