From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932294AbdBIS12 (ORCPT ); Thu, 9 Feb 2017 13:27:28 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:36041 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbdBIS1J (ORCPT ); Thu, 9 Feb 2017 13:27:09 -0500 Subject: Re: Sed-opal fixups To: Scott Bauer , David Laight References: <1486660801-5105-1-git-send-email-scott.bauer@intel.com> <063D6719AE5E284EB5DD2968C1650D6DB0281B85@AcuExch.aculab.com> <20170209174526.GA5200@sbauer-Z170X-UD5> CC: "keith.busch@intel.com" , "arnd@arndb.de" , "hch@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "jonathan.derrick@intel.com" From: Jens Axboe Message-ID: <45bcab45-3efa-e817-911a-ec3a0924dc6b@fb.com> Date: Thu, 9 Feb 2017 11:24:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170209174526.GA5200@sbauer-Z170X-UD5> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:4947] X-ClientProxiedBy: DM5PR1601CA0010.namprd16.prod.outlook.com (10.174.111.23) To BN6PR15MB1185.namprd15.prod.outlook.com (10.172.205.139) X-MS-Office365-Filtering-Correlation-Id: 06b3e169-0785-4dfd-e488-08d45118f994 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;3:Ifw826YJohAOku9ZZDUtt27YXCrqBD5Bo+Y/sP5ZVu1Y9Ys5LMHZnATvNMqEx1/SFWbyzddlMMdyuqD15gI7CVtX02pEGTtRzeRPTwVqhZXuwqj4/LWaH9Ji1deWGXdIPt+cBmSgR3JF0JoQoySylRdgyMUBsOyPSmqoUCDZ803uyO1te1R3B40m+Nm68E6AcKexfOq53uSGZDwNpq8yTp3yypDk1GphlB/vLtTzQLDyOR/IicOVyjmg6/ncYThxLhG/eKuaSbP8Mtf8IS6vYg==;25:jwXNVi+cR0FyKrmsjAsfIFcWLX4DfLipNkbn1UKDjNyXAX1oErYutRXyxoDPKQNqmOIy07EvzYO0UHZPLSfnAKEQu/Cbk+rFJyR9ARBu6BRgdH2sy4rdjjEANc9huItfrRb+LlQyulLmAb2Alir2AfQRcz07h+Ti0INMPGv+Bz/z+RXn85SUnAW/Xd2zpH8llZa7VDNYHnp/vUewvzaS0Q8BbYi+KvWY7PR3kImkcf/lIjNZymKAMSi2Wmz1OYbh6PVwPj1HPOS+UxKudghryldpX1xuJzLAYmfVVMauR7CVTgdwRoRFzaduJD+sbPvNQDR8seJqOAECRhe7YhlvIHsGrbXp/IUH69B8FMgpY/HVLPc0jIPNSWIAFpgO1Zikkz5lsR/iR3j5gQ8day0dbDiKZm9QtrIylV5tk2Rl+6R6xUKguf6yfN6eYxc0YhWkl6AoK5fCWp+84+VSDLGWfA== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;31:hFoc3FUtoFn6yyY69vjzT+njK4WeivWdVCrfgfbba2yGIcPCxvK9AAyJ1STVTi+l7ZO6ICI3pYW7AQU1NRnJHXz96WkzvKPEmLgwZOgl9AbXMSQjncLf9h1TBQn5jI5/UMFzRXjCyr9vNp406YGGahGtdvZ/iThQmjQEVrPEQr1wL6Q7xkmKSTLjr1py8QjVxUM/B/eutd2SF9n0mWmmk1/bz/MQIdLFT+qa3WYBgmTeslVQG5wMYMzTr/VKAYRngWANaBFvsY4x+k2cby8bBQ==;20:nwcvMf4f+M9Y5Dp+Hu/H9/H1DGkWjm2ki8II0ZDdvqEclZoufxZAy1FNhtRTrOd0rp9EbjE79VtCotOq7Ll4cvSdIwdOsDxeoeXJxPhEiJLtNgAC1zQGGQw7iDhFDOKIY6uPkhIoOBzZfW3yDLBUHX+eHFkdTqyQI+K7PrJ0D5622V8TrWK6IuLwoh+Dn4eWUf6Ljbv66mfTpkJXSA5nJQ+ggBrROYEXIwJ4HqQ+nsADci8blNV0PGRqOhYsascVt6vED+Ji/YoJYtvz8UF9qfTWJNmU6pTHt1zgnyrVjxgPRUEsjPIf6D1vyGmjXBICvx2ADRev32p7nFjTNAApLNMBvdKQ/gKEMnp+r4U6Sqk12n+Nr3bXl4FPKH1gX0jYcOvx/uSxVj898o4tBK8zDucTYdV4DLW/hRmZ6I6juCQ2uAqnG5crVuuuDB4YlBRUE01GMhIS536mLVSSwWvMelabNUSMnLjpCIfnqgTW6nZzMvduB4qBIpxXBInTbBsN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123558025)(20161123560025)(20161123555025)(6072148);SRVR:BN6PR15MB1185;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1185; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;4:Chs6ieM7672kw53waSmGyX9TIJ4ifZo2z8mbk5iwuR4fac/i7V+YT3aP66TmYqMvagtOPiK4drkIS69wt5vEXITh3il3gYsRV5dlevzDpi8aaD31MUZbD5JHfHDSmK3gXRUAhcdgFTccU5FKU7p5/+M67CjdagZ+hlxvjMXGCV6MNzCNobGRuJpO6YG/zDsgA0NQs5Yg1LSbpm0QSVJ+brfXAYDnBTkRK+7+sFgs7KqEZgUb1QOmEiGA7kfRlo4QUa1uXkenO4xZrHKzPOWyIRFwtJtO/CXHPJ11RpYJbdR7Mlmba9MeDbYH2Tvi4Gz0f97ofjy7/hCQOmVaVKtn2B9Wt5k4Cj0iIMCYoqS+OJEuXwtEs/QJ8A2oT68fHLDNId7m9LHra0ld1f9PfWCg9LYvA+V88ZSDu+CzxH06oKq8edXV0iba3O2mVHWWhkEXEge5/s84VAklvDbCOn3eO/PyKUHTYdasW0hbGlIeR6qoXFDDPO8IXf3jUew2tFy89y1fETsYXYD6UEB5a3LyV2HQWj4WrXrLvd94q0vuxaZZ+T6KVk8eLA6NoTHJ5SVEvO6OGjPa649T1h5IjQODM4rMHkXH/PWDLvHMgx/qhuM= X-Forefront-PRVS: 02135EB356 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(189002)(377454003)(76104003)(199003)(86362001)(92566002)(31696002)(25786008)(305945005)(38730400002)(6246003)(53546003)(229853002)(64126003)(6666003)(2950100002)(5660300001)(50466002)(23746002)(50986999)(7736002)(54356999)(76176999)(65826007)(53936002)(101416001)(6116002)(97736004)(36756003)(31686004)(106356001)(42186005)(4001350100001)(81166006)(81156014)(68736007)(54906002)(83506001)(8676002)(4326007)(105586002)(1706002)(3480700004)(189998001)(2906002)(230700001)(65956001)(6486002)(65806001)(47776003)(33646002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1185;H:[IPv6:2620:10d:c081:1103:93ec:cd5a:c00e:84a3];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN6PR15MB1185;23:ec9rTIMJtMfX43pZDIVEQCSZzao1CjuGE9JC8?= =?Windows-1252?Q?ts8p05xsYb5Fy+6+QeXwIGQiQDLYNTh91zhBMWqBnJLrc7mmLg2QUc9G?= =?Windows-1252?Q?sHn3pg5FJLWc/W1OXc1tlRhOT6FrvrzBjuWO2TNAiOCRaz3P7enfXy5+?= =?Windows-1252?Q?5arg82in4SEWUIvKL9QF4nZ6b6IqDA0+3/h4ZGSpZWEp+xCKp3UUgoRZ?= =?Windows-1252?Q?Row6h27DFymHs9NAOMSPYTIELBuJfo2Z03y/5qbIn7DjgKLemQ3kPb1Y?= =?Windows-1252?Q?aac63lOgCf5VFPhln888Xr705mBXYiudhG+tj7prPxEi8aQJlNiR0t8e?= =?Windows-1252?Q?gBCpVS+mFnmG9mixfukHkUteMjgyZHdCsRpQHvF+a1FGdqaw/+TpnhyQ?= =?Windows-1252?Q?u6Ae3EfO3LQ8VPpRk0YJ4VBR6LIa7ebnHvrB0Ria7BDpMVW2b0X/qju+?= =?Windows-1252?Q?l4sDnq/lFTUeayWjpbLzclmigWU3iCdmlJ/sWo6HrPpvUpHTqyMSEAed?= =?Windows-1252?Q?/bmPss46jIF0Syf7PRbTvcAJaoa8Ki6t4WY50/D+mZzpxRSLRh2wPXr2?= =?Windows-1252?Q?bweFcuOWB7zXQCq9hI+BZqKvM/5rYmjCNDiU3QWhaMEpyqoPygiAw9i3?= =?Windows-1252?Q?im3NdrfnjBwn3qEIV6Li2rbqs4F8SybLP4JAXRTU6FYkRDAJ2j7fxTup?= =?Windows-1252?Q?VaZgpOZb/2647yPIWe4JRyTZUR5P/sTpQnJYb3aH77g173StRcCAErwD?= =?Windows-1252?Q?Tj01cM74fSM9Q7ONef5rB3idMr4qbloHtkPSHf4ktiEO7YQYCBMO8Re7?= =?Windows-1252?Q?gVOlZRWP4d4E87rCqPjYPeQEBki86NhW/jzO2anEyvqVmjshSY5VR0ME?= =?Windows-1252?Q?FrIBU2BLIU4ShZ41TvNmoJ/jC2Y9i1IRjWtQsDKlwSfne0lcvdMciSFx?= =?Windows-1252?Q?4Y6ugv0DFhk6/gqXWP6dzU8cSKO3eZxMvY8GfoVDxdlGVBjYymIO/y0n?= =?Windows-1252?Q?EgvkGltaPnqSEgS/rvp1ftJ4TAYygL/d2brejoKFz+PZdvUpIG2gs5Gh?= =?Windows-1252?Q?si83YAqtodFU2ND13P2Q7z715JnSZR78o0nbh7VLz7a0xMwK/dUnTADm?= =?Windows-1252?Q?WMPyyZp3Yrj5FCRbtk4vpW1SapG7rnvTBehJ91fxL4KjI8hC7kFdefqC?= =?Windows-1252?Q?Wf7pOL/yQEu5+9coVtp3VtO9oh0PX9YfaTxQXGUofOKeLV8M27+TJsz4?= =?Windows-1252?Q?4PNlPSuNT21L49Zqio6hd4U3Hc49owJxoQ9YJAsdmnGttaR80oM0jq7c?= =?Windows-1252?Q?nAIbr8jXngS2rS34Pt63dStJwy+oO29eUBKXXohPktuCytMM9N8NcuzH?= =?Windows-1252?Q?Sxfm64dFmLN9nV6olKSQutI6McfvUgdPdxxOWsPRDhJVKjHV2vGpAJeY?= =?Windows-1252?Q?ziX/VOG61cyANpU0RenQDeniWEGr91BV2m/I5+Baw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;6:Z0qrNpDcYk+cICUXX1knzNAM45MvHpvanQ0eD0ylCCmNQeT/PJm3bc0W9MIXyV25m6R5VC9rUa6mw0bfc5W2TpNagGCJKlvpK9cmE8MzR1tbo0iAP17QpRR+4KVYsQUOrh7+Nup/Musekww1qNTExbMMb0CWvg7tM+C52mNSSYBKx+BcRLb0dnQ9OPt8DfrkQJkiVkoWZ44fkXqP7ueQb81FdaGJ1fycE+AmvUJcF7BpEvJuumgMk61GYwNA31BNhP8/A+gXap452s/+ZvkzT0Ax6hYLad8+OCF5eF35OaauvrpiDxhDVeFDaBpDxTbDSIEz2Pm2Vwsu85mW72gpYQzfu2NOp2120Dfj84kXnP/k73/ul8IAczRZEJxJTRqBxH33dKOHzVa386kZ9bJMZw==;5:H0eflShxO+JFo6E6FHeAeqnBqfnBpHMKQrD8MlnK7pkPwlYKntfYc4IdVZ1pCZHFQDSpF8+1cwK8/x+2wTgXtIjepJ/OfYPje0+wWxINDAFitBRpdy92UAYpT1bK6af/VBi9JASeOqx3G1dW/HFoog==;24:vtJ98VDb4AUX+CNOT2Fs+j19npzMl6anKXvwZeOBm0G31Uk1Dl1tc5zA5CIirwB2TjCWugFcU22TIQD+Ci/36gbRhe8v9/SZonKizEF8SlE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1185;7:cfGA/CLMbs5OabIh5lWGzvqtREcrivbwnvnBkOpsfLsTi4qS1WgaBru2cEBIkr2yNvDtdJmnRly/rq4LF/SIzhbZtO13abpihRk2vzPJ3ds+QXe1tzJVwdlY+vgkRj2p2GnmsHu0mlIWKgVVVTevd9kxkCbbNppXn+NmsOR25jJizRtxNPhtOCr7YuAQKUsPW1qE0wg/joHwof55NdoSDZ5fQH78JcWeoXw/7t4ghwt4qvCo9gU9jvUT3eCZ5S28E3uNiRGBNA5Gw33sCn0ul/aZ7OTZ3U76NIvHXUzsSmaC7KExy28k9m2OwrbXX1QWdvuWEMYm2+mEYhPjTcxEfKJ9UMf2wmRzn6Jw9oylXuJzxxbmqZUZVetn2kFFcgLwuhzxXkoVAMtTEOAQ0w/jwPUWsas+BgX1gr3AYmbs/sSSYC3o7xBSJMQItR6WZltUtA5GIF+G/ey0iJb45t6vuDH72UgENQ9YMxbRL2DeWKh2P4mmNBYifsBtn9oHpE1owMYzs6clQmW43CGXHLdL+g==;20:B1m2zb4+TtbV1pHCmD7GlCxEWXRyssCqMbtJHa5fNQiqPbakgslS1JL0gF/NcibUJUMZejuGw7ybgYIBuhvXm1hFY/QolZJn+A8a6ypyA0KPOINmeX1d9RDHxvOJfazZKQtB9TCF3k3v59DWem+jJJLqnwMka/gwM56+epEIYW8= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2017 18:25:05.5096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1185 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-09_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/2017 10:45 AM, Scott Bauer wrote: > On Thu, Feb 09, 2017 at 05:43:20PM +0000, David Laight wrote: >> From: Scott Bauer >>> Sent: 09 February 2017 17:20 >>> It may be too late to change anyhting in the uapi header. When we >>> switched over to using IOC_SIZE I found a bug where I had switched >>> up a structure in one of the series from v4 to v5 but never changed >>> the structure in the IOW. The structure that was in there was to small >>> so when we kzalloc on it we don't request enough space. It worked before >>> because we were using the cmd strictly as a command #, not using the IOC >>> and friends. >>> >>> If it's too late to modify that IOW, I can work around it by reallocing >>> on the correct size for that command only. I verified the rest of the >>> commands and the structures are the same. >>> >>> Let me know what you think, please. >> >> Maybe define IOC_OPAL_ACTIVATE_LSP_OLD to the incorrect value and >> IOC_OPAL_ACTIVATE_LSP to the correct one. >> But that relies on any users specifying the correct structure. >> I wouldn't guarantee that. > > I think I'm the only userspace user right now, this went in on monday, > so I can can change my tooling easily. I just wasnt sure if there was a > set time where the user ABI cannot be changed. We can still change it, and we definitely should if it improves the interface. It's not a ABI until it's in a released, final kernel. -- Jens Axboe