From: Jiri Slaby <jirislaby@kernel.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kbd@lists.altlinux.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 3/3] VT: Bump font size limitation to 64x128 pixels
Date: Tue, 6 Dec 2022 07:48:37 +0100 [thread overview]
Message-ID: <45c09e48-9e69-2371-70d2-8a0b1e9f4899@kernel.org> (raw)
In-Reply-To: <20221205000807.896278194@ens-lyon.org>
On 05. 12. 22, 1:07, Samuel Thibault wrote:
> This moves 32x32 font size limitation checking down to drivers, so that
> fbcon can allow large fonts.
>
> We still keep a limitation to 64x128 pixels so as to have a simple bounded
> allocation for con_font_get and in the userland kbd tool. That glyph size
> will however be enough to have 128x36 characters on a "16/9 8K display".
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> Index: linux-6.0/drivers/tty/vt/vt.c
> ===================================================================
> --- linux-6.0.orig/drivers/tty/vt/vt.c
> +++ linux-6.0/drivers/tty/vt/vt.c
> @@ -4575,17 +4575,20 @@ void reset_palette(struct vc_data *vc)
...
> -#define max_font_size 65536
> +#define max_font_width 64
> +#define max_font_height 128
> +#define max_font_glyphs 512
> +#define max_font_size (max_font_glyphs*max_font_width*max_font_height)
So this is 64K -> 4M switch. We should likely convert to kvmalloc() too.
regards,
--
js
suse labs
next prev parent reply other threads:[~2022-12-06 6:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 0:07 [patch 0/3] VT: Support >32x32 fonts for hidpi displays Samuel Thibault
2022-12-05 0:07 ` [patch 1/3] VT: Add height parameter to con_font_get/set consw operations Samuel Thibault
2022-12-06 6:40 ` Jiri Slaby
2022-12-06 20:39 ` Samuel Thibault
2022-12-07 7:39 ` Jiri Slaby
2022-12-07 8:21 ` Greg Kroah-Hartman
2022-12-05 0:07 ` [patch 2/3] VT: Add KD_FONT_OP_SET/GET_TALL operations Samuel Thibault
2022-12-05 0:07 ` [patch 3/3] VT: Bump font size limitation to 64x128 pixels Samuel Thibault
2022-12-06 6:48 ` Jiri Slaby [this message]
2022-12-06 20:47 ` Samuel Thibault
2022-12-05 0:09 ` [patch 1/1] font: Leverage KD_FONT_OP_GET/SET_TALL font operations Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45c09e48-9e69-2371-70d2-8a0b1e9f4899@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbd@lists.altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®