mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Larry Homes <larr.homes@gmail.com>
To: andrew hendry <andrew.hendry@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Possible bug in insmod or the kernel?
Date: Mon, 8 Feb 2010 13:13:40 -0500	[thread overview]
Message-ID: <45c77aec1002081013q2b07cb7flbd827a977ed51d4c@mail.gmail.com> (raw)
In-Reply-To: <d45a3acc1002071414q318edea3m38f6d5ddbbd841bc@mail.gmail.com>

No, the problem is not that the quotes are showing. The problem is
that as soon as it sees a space, it assumes the following is the next
parameters name. So for example:

[root@myhost modules]# insmod hello3.ko name="john smith"
insmod: error inserting 'hello3.ko': -1 Unknown symbol in module

[root@myhost modules]# insmod hello3.ko "name=john smith"
insmod: error inserting 'hello3.ko': -1 Unknown symbol in module

In both cases, dmesg shows:

hello3: Unknown parameter `smith'

I looked at the params.c code and it seems like the above should work.

On Sun, Feb 7, 2010 at 5:14 PM, andrew hendry <andrew.hendry@gmail.com> wrote:
> have a look around kernel/params.c
> /* You can use " around spaces, but can't escape ". */
> /* Hyphens and underscores equivalent in parameter names. */
> static char *next_arg(char *args, char **param, char **val)
>
> Your printks are probably showing the single quotes? probably not what
> you want in your name
>
> On Mon, Feb 8, 2010 at 5:56 AM, Larry Homes <larr.homes@gmail.com> wrote:
>> Hello,
>>
>> I am very new to kernel development and I was playing around with
>> making modules. I found I could not retrieve commandline parameters in
>> the module if the parameter has whitespace in it. I thought it was my
>> lack of knowledge that was causing the error (and I still do
>> honestly), but I made a forum post here
>> http://forum.kernelnewbies.org/read.php?17,1354 regarding the issue,
>> and someone suggested it may be a bug and I should post on LKML.
>>
>> The forum post shows example code to demonstrate the issue. I am using
>> archlinux and the latest kernel. I am not sure what other information
>> you need, so feel free to ask for anything.
>>
>>
>> Thanks
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
>

  reply	other threads:[~2010-02-08 18:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-07 18:56 Larry Homes
2010-02-07 22:14 ` andrew hendry
2010-02-08 18:13   ` Larry Homes [this message]
2010-02-08 18:43     ` Nick Bowler
2010-02-08 18:47       ` Larry Homes
2010-02-09  2:23         ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c77aec1002081013q2b07cb7flbd827a977ed51d4c@mail.gmail.com \
    --to=larr.homes@gmail.com \
    --cc=andrew.hendry@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®