From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44BA933507E for ; Sat, 7 Feb 2026 18:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770489790; cv=none; b=QLblRAm8jDe6xhoDRnLe1WmCt66qJ0tPOnBBmEeNoNUg/SqwAyJNz4nsZ91Yge8ytDoUziMjtVjcTSU1T9/yW2e1scSBuFTognmr3hgyrGizrFELRdOWVmEf8alJGi3w5jlLIJ+8daEqei7x5KVKPvsbkmMrFdHrGj/bfI3yXN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770489790; c=relaxed/simple; bh=eobRWPX7V3mhzQ/jJ2aUjX2QqhN/EpRejhH5y6xfzB0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lNj4zV5Hfn8YKRMG+yr6J9JvM3V7yDMcW7cBOW/Yl9n/TnuuXSRzGVjJPcGFhOOosGQ0A/4IcUq6eLgQ5falvQxm6wFsILxIdGUOwJg4+ursImwR7UZmhwa+kaAZ3YA5Ht4k81p91pSwxWSHBJqN3gkefAZMxllL028e4uOLwTg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=J1UF2IPM; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="J1UF2IPM" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7d122733808so694887a34.2 for ; Sat, 07 Feb 2026 10:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1770489789; x=1771094589; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=prJ1YgnM4mOIBKQF9u4CXqDRUwbdBQdcuDtFU8rMz6k=; b=J1UF2IPMwXCnQQDsKsX8Fk/cmOOoSBdnju3x2xy4ffWCbpuEYZS8Zr7gIO6VJgT3A4 TsZM6V1Dg7uEHz26lyhEND8AU4gi7DHN8c3qyufeGrqhWMQkuT3lMRenMcsB3Dwo0as8 a5nn+4OGW+sMUpSMIoGN0ujBh1cVODcmvwnWvfKrAsKagesmUmdPuYGwTDYZj5gOPNix ECS1qhwXvZASFlRFw+JNWV5slGRmfci31tP+6Y8/o10ZRKrNEk5AhP0g/F09/OouJ+8c OsEqk1TNrk0OMqlO9aBMpOV6UrTeiE/346tYLZ9hrAKd1oQ/BPs5q38ONO5MQFMxuNaD gK7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770489789; x=1771094589; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=prJ1YgnM4mOIBKQF9u4CXqDRUwbdBQdcuDtFU8rMz6k=; b=IyDRDdpwQQH2ldcbDf6heJAVWi8suKy0acy9S0cZFnQRZkL2OZN99U0cYabuLM7xQL o2aJME42wKNdLn1YljsKdXodkBg3JmJQngTZNgJ0oBkmsZ59H+4QCRRVc7AADpS3WbBX H/z1Ein9aCCG6DD1jxAnK4aF/UjKRGE/djZRCYkyjxTwKK3WBpDPFHLLYGKEfu7OK3Le m1uJRBr5zugv8EYVMyb5iUQAziZld27EuLL6E/nWG1EIjsLmj7f0vJyw3dErv+pnv3bN xHi+t6YLNPna8+Dpnol2AU+aUYhr1Byx764+GH+AhTPRIyMvsBszVCr1PLiDq9WuS5+G oAoA== X-Forwarded-Encrypted: i=1; AJvYcCU7DvJYPvmoScKlTdCJd9xgittVdUBk/ICkKKHxj5PhMfT6xWaPgudv39vQ8Pw3fQAC1SOv1hSd8UYMfq8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6ouArJD0snCnwWq2dRyz0zbWGcDtpkS2UDyvi0/PE2kR3fenD nU7u6gLYjxye+RgzLN4Ovi6lECg1DVcOHI9wy61YTR4kq/w5W10iWNELGiSLGnVOuoc= X-Gm-Gg: AZuq6aKgH4BCqf7pCX8yhrbRiFBGJHAYjXiMIK8j1cR45tAjcZumEDQ52dS6suEOM1a KbRDwDiRN6EdK8pI5A6Hdwl+cj9VORllHWRaHhO7m7tLGQ1i+l46+wJd8XGhAgZ6WH6VhwHqjd3 waKma0bPHD6o+/xLX+nMGS+HscS2hVxf3TVu1Ng3DAd/wlKhsG7Atx6AkPdyN+Zd5GLG2jPhW/I AqYvdZx1UYccg19jt4OYyAV5qyMUYMzcF1108hlpWjC9d6QPrEdiaeU84fYh1RzwaDQ2+0nx2iq 1styXU43UZxDaANRE4Gg+ILuXQ/4Qmq44hK1fiyrlAcEWTOaj+oiMvxRIluQ/4BOhioTD1bBb8u wTtNVi9e+7CdDCZKmY6ZiF7hG+2We1/yQtuqRy9OQKVjp+5nxcZ+oj1x+odTbQb7VhCe/fj4PxH JdraAl22ASyOkrysLgyVQAH9pAnQEjtLXue5v2HtEjMd3NLuppdulii3SFtA== X-Received: by 2002:a05:6830:3687:b0:7cf:da7d:5041 with SMTP id 46e09a7af769-7d46447f75dmr3415181a34.21.1770489789192; Sat, 07 Feb 2026 10:43:09 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:74a6:843b:f33:21ae? ([2600:8803:e7e4:500:74a6:843b:f33:21ae]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d46470dec3sm4260081a34.9.2026.02.07.10.43.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Feb 2026 10:43:08 -0800 (PST) Message-ID: <45cbf569-6046-46a7-9a76-7411e89af99a@baylibre.com> Date: Sat, 7 Feb 2026 12:43:08 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/5] iio: adc: ad9467: check for backend capabilities To: Tomas Melin , Michael Hennerich , Nuno Sa , Lars-Peter Clausen , Jonathan Cameron , Andy Shevchenko , Olivier Moysan Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260205-b4-ad9467-optional-backend-v6-0-7ca20c40c59a@vaisala.com> <20260205-b4-ad9467-optional-backend-v6-5-7ca20c40c59a@vaisala.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260205-b4-ad9467-optional-backend-v6-5-7ca20c40c59a@vaisala.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/5/26 6:24 AM, Tomas Melin wrote: > Add capability checks for operation with backends that do not necessarily > support full set of features, but are otherwise compatible with the device. > This ensures a fully functional device, but with limited capabilities. > > Signed-off-by: Tomas Melin > --- > drivers/iio/adc/ad9467.c | 67 +++++++++++++++++++++++++++++------------------- > 1 file changed, 41 insertions(+), 26 deletions(-) > > diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c > index 59c3fa3bcc9b..7a3db36121b0 100644 > --- a/drivers/iio/adc/ad9467.c > +++ b/drivers/iio/adc/ad9467.c > @@ -913,7 +913,9 @@ static int __ad9467_update_clock(struct ad9467_state *st, long r_clk) > return ret; > > guard(mutex)(&st->lock); > - return ad9467_calibrate(st); > + if (iio_backend_has_caps(st->back, IIO_BACKEND_CAP_CALIBRATION)) > + return ad9467_calibrate(st); > + return 0; > } > I would appreciate a blank line before and after the if statement if we end up needing a v7.