From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795042803; b=YMlUbal1AFwuZE+NhtVsv3iP+G9cI4mx/1wJ0/NYohTr4+fN2Dcqwj6Ww+SK1ozN6+wo gLtm65ydqr8fVmlOHQnjMJZ9XQKD7uomq30Qy4q/p4aiKpFOvLgEBslmK6erKVdeJx/H5 V1i7nM6zgYIfeAmUOultfx1Z+F75XncGJ4Kdq9XZ+bOAT56X8F2Lxc8ROcdV6CM9YIOd7 k68OLVRQIf9/TamgfinCOXjYs/JNmtyZE+lmtvw3GPanC8I5JfK8XYpD7njiMAeiLj+HG LVP+owpzgAwEW+1an26ZFGEdqBeJQrVXy1PEdoLTj2Z32s0tAq6pHMjCQ8QSEt+BrSg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795042803; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=XAuhA+IU5X7u3tpSaiC00u8UC8LTIZ7zSVpFz6MURNo=; b=EEPUIml0DAjwo6J2U/lF8AMFiria7HwGKGeZut3//xorcpNMgANrDDzvHWDrtw/3cFcE DWZCJqecWA1D6BqjNaejr2JOMFgQkHcFdPUbnNykIpLiGN9ARjcUHosEfNHXANOUFjQRw 4q9WLzqPo4j7rVTG6RX9xF6W1+eLeFUnLX6fYWlrqvTmXvz6IYyu/LFYJvfCFhDNiNF79 M1yyAe/pWP83eVN6sgxAoduNFySbc9UGoF3PO/ot1tsA9yoKyxjC/eHJGtqoU4hVaHHbl ZItL2TYckzHvVbdcKe0bUhNwG3iM7vbvd5hSvh4rv07mbaRPZ2KKke6YT617ZTtKKXA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b="Xes/E2vx"; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD39F606A32C for ; Wed, 18 Nov 2026 23:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Xes/E2vx Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CBFB1F000C7; Wed, 18 Nov 2026 23:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795042803; bh=XAuhA+IU5X7u3tpSaiC00u8UC8LTIZ7zSVpFz6MURNo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Xes/E2vxcQbfPOkatddUiAnb4zYnJ1FeLekD5lDExpx+Ct0bPR8nWagx0C20vj5F6 RPackmRHerVZOMDioK7aUASk82QgYK73h1BebC+5t3H9Owt/FA0ukPT8bCD1z2bl7S vMMSqwxg26fpqR3qaN8iG410fpymMrmXe73bzvzZ2viTkRFblTvVMZ170eoY916KyI gDX0OKdGaqx98mFVRh0Hds+Z8tQlC4ZiwoMYjsycVs9+LvKWkPhewydmx5ttf0QMi5 n5V8MFEf2O1DHcLckSPOLFfqTWa2xI9vh+P6qfhx/AmQ78j7OdAwi8JoEG/TYiM2n2 RORAm6tMpospg== Message-ID: <45ce0b42-d45a-44e3-b300-607989e618c5@kernel.org> Date: Wed, 18 Nov 2026 23:59:57 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/secretmem: Keep locked memory accounting until inode eviction To: "Baek Kyu, Kim" , Andrew Morton , Mike Rapoport , "Lorenzo Stoakes (Arm)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20261030152407.113568-1-pocj8ur4in@gmail.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261030152407.113568-1-pocj8ur4in@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/30/26 16:24, Baek Kyu, Kim wrote: > A secretmem inode can outlive its original file. An O_PATH descriptor > opened through /proc/self/fd keeps the inode and its unevictable folios > alive after the mapping and original descriptor are closed. The file > release path nevertheless drops the locked-memory charge, allowing the > same user to reuse RLIMIT_MEMLOCK while those folios remain allocated. > > Move private-state and locked-memory accounting cleanup to inode eviction, > after truncating the page cache. Keep secretmem_users active over the same > lifetime so that the hibernation guard covers retained secret pages. Let > iput() handle file-creation failures and tolerate an inode with no private > state. > > Fixes: 97d34aa65c29 ("mm/secretmem: properly account locked pages") > Signed-off-by: Baek Kyu, Kim Lorenzo, Mike, this problem seems real to me. Can you take a look? > --- > On an arm64 QEMU guest with an 8 KiB RLIMIT_MEMLOCK, an O_PATH reference > retained two secretmem pages. The baseline dropped the charge to zero and > allowed a further one-page fault; the patch kept both pages charged and > rejected that fault until the last path reference closed. The Image > was built with KASAN and lockdep. Hibernation, other architectures, > and long-running concurrency were not tested. > > mm/secretmem.c | 31 ++++++++++++++++++------------- > 1 file changed, 18 insertions(+), 13 deletions(-) > > diff --git a/mm/secretmem.c b/mm/secretmem.c > index 384f5cfc457f..fa8be360bd2a 100644 > --- a/mm/secretmem.c > +++ b/mm/secretmem.c > @@ -185,18 +185,14 @@ static void secretmem_destroy_inode_priv(struct inode *inode) > { > struct secretmem_inode_state *state = inode->i_private; > > + if (!state) > + return; > + > secretmem_unaccount_all_folios(state); > free_uid(state->user); > kfree(state); > inode->i_private = NULL; > -} > - > -static int secretmem_release(struct inode *inode, struct file *file) > -{ > atomic_dec(&secretmem_users); > - secretmem_destroy_inode_priv(inode); > - > - return 0; > } > > static int secretmem_mmap_prepare(struct vm_area_desc *desc) > @@ -216,7 +212,6 @@ bool vma_is_secretmem(struct vm_area_struct *vma) > } > > static const struct file_operations secretmem_fops = { > - .release = secretmem_release, > .mmap_prepare = secretmem_mmap_prepare, > }; > > @@ -274,6 +269,7 @@ static int secretmem_init_inode_priv(struct inode *inode) > > state->user = get_uid(current_user()); > inode->i_private = state; > + atomic_inc(&secretmem_users); > return 0; > } > > @@ -296,7 +292,7 @@ static struct file *secretmem_file_create(unsigned long flags) > O_RDWR | O_LARGEFILE, &secretmem_fops); > if (IS_ERR(file)) { > err = PTR_ERR(file); > - goto err_free_priv; > + goto err_free_inode; > } > > mapping_set_gfp_mask(inode->i_mapping, GFP_USER); > @@ -309,11 +305,7 @@ static struct file *secretmem_file_create(unsigned long flags) > inode->i_mode |= S_IFREG; > inode->i_size = 0; > > - atomic_inc(&secretmem_users); > - > return file; > -err_free_priv: > - secretmem_destroy_inode_priv(inode); > err_free_inode: > iput(inode); > return ERR_PTR(err); > @@ -335,6 +327,18 @@ SYSCALL_DEFINE1(memfd_secret, unsigned int, flags) > return FD_ADD(flags & O_CLOEXEC, secretmem_file_create(flags)); > } > > +static void secretmem_evict_inode(struct inode *inode) > +{ > + truncate_inode_pages_final(&inode->i_data); > + clear_inode(inode); > + secretmem_destroy_inode_priv(inode); > +} > + > +static const struct super_operations secretmem_super_ops = { > + .statfs = simple_statfs, > + .evict_inode = secretmem_evict_inode, > +}; > + > static int secretmem_init_fs_context(struct fs_context *fc) > { > struct pseudo_fs_context *ctx; > @@ -342,6 +346,7 @@ static int secretmem_init_fs_context(struct fs_context *fc) > ctx = init_pseudo(fc, SECRETMEM_MAGIC); > if (!ctx) > return -ENOMEM; > + ctx->ops = &secretmem_super_ops; > > return 0; > } -- Cheers, David