From: Dexuan Cui <decui@microsoft.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "olaf@aepfle.de" <olaf@aepfle.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jasowang@redhat.com" <jasowang@redhat.com>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"apw@canonical.com" <apw@canonical.com>
Subject: RE: [PATCH] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc
Date: Wed, 12 Aug 2015 15:50:48 +0000 [thread overview]
Message-ID: <45d4a7c9eaef450ab16b76290eb3b0e0@SIXPR30MB031.064d.mgd.msft.net> (raw)
In-Reply-To: <20150812141114.GP5180@mwanda>
> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Wednesday, August 12, 2015 22:11
> To: Dexuan Cui <decui@microsoft.com>
> Cc: olaf@aepfle.de; gregkh@linuxfoundation.org; jasowang@redhat.com;
> driverdev-devel@linuxdriverproject.org; linux-kernel@vger.kernel.org;
> apw@canonical.com
> Subject: Re: [PATCH] Drivers: hv: vmbus: fix init_vp_index() for reloading
> hv_netvsc
>
> On Wed, Aug 12, 2015 at 01:35:07PM +0000, Dexuan Cui wrote:
> > > From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> > > On Wed, Aug 12, 2015 at 12:29:46PM +0000, Dexuan Cui wrote:
> > > > > This fixes the recent commit:
> > > > > Drivers: hv: vmbus: Further improve CPU affiliation logic
> > >
> > > Since you are redoing this anyway, include the git hash so we can look
> > > it up. In fact, just use the Fixes tag.
> > >
> > > dan carpenter
> >
> > Hmm, I didn't read your mail in time and sent out V2 just now... :-)
> >
> > I'm working on the latest linux-next (next-20150810).
> > I didn't add the git hash ID because I think the hash of the patch of the
> > same content can be different in different trees (like Greg's tree and
> > linux-next)?
>
> Sometimes it can change, but mostly it doesn't. In this case it didn't.
>
> The commit hash is based on the tree, the parent, and the content of the
> patch description. If we rebase, add a new signed-off-by or merge
> the patch through a different tree then the hash changes.
>
> regards,
> dan carpenter
Thanks a lot for the explanation, Dan!
I'll remember to add the hash in future.
-- Dexuan
prev parent reply other threads:[~2015-08-12 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 13:48 Dexuan Cui
2015-08-12 12:29 ` Dexuan Cui
2015-08-12 13:05 ` Dan Carpenter
2015-08-12 13:35 ` Dexuan Cui
2015-08-12 14:11 ` Dan Carpenter
2015-08-12 15:50 ` Dexuan Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45d4a7c9eaef450ab16b76290eb3b0e0@SIXPR30MB031.064d.mgd.msft.net \
--to=decui@microsoft.com \
--cc=apw@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®