From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751092AbeAOTMv (ORCPT + 1 other); Mon, 15 Jan 2018 14:12:51 -0500 Received: from merlin.infradead.org ([205.233.59.134]:42740 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbeAOTMs (ORCPT ); Mon, 15 Jan 2018 14:12:48 -0500 Subject: Re: [PATCH] tracing: prevent PROFILE_ALL_BRANCHES when FORTIFY_SOURCE=y To: Steven Rostedt Cc: LKML References: <9199446b-a141-c0c3-9678-a3f9107f2750@infradead.org> <20180115141049.4b15876d@gandalf.local.home> From: Randy Dunlap Message-ID: <45e4c153-a232-d953-9666-858c0436fd74@infradead.org> Date: Mon, 15 Jan 2018 11:12:46 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180115141049.4b15876d@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/15/2018 11:10 AM, Steven Rostedt wrote: > On Mon, 15 Jan 2018 11:07:27 -0800 > Randy Dunlap wrote: > >> From: Randy Dunlap >> >> I regularly get 50 MB - 60 MB files during kernel randconfig builds. >> These large files mostly contain (many repeats of; e.g., 124,594): >> >> In file included from ../include/linux/string.h:6:0, >> from ../include/linux/uuid.h:20, >> from ../include/linux/mod_devicetable.h:13, >> from ../scripts/mod/devicetable-offsets.c:3: >> ../include/linux/compiler.h:64:4: warning: '______f' is static but declared in inline function 'strcpy' which is not static [enabled by default] >> ______f = { \ >> ^ >> ../include/linux/compiler.h:56:23: note: in expansion of macro '__trace_if' >> ^ >> ../include/linux/string.h:425:2: note: in expansion of macro 'if' >> if (p_size == (size_t)-1 && q_size == (size_t)-1) >> ^ >> >> This only happens when CONFIG_FORTIFY_SOURCE=y and >> CONFIG_PROFILE_ALL_BRANCHES=y, so prevent PROFILE_ALL_BRANCHES if >> FORTIFY_SOURCE=y. >> >> Signed-off-by: Randy Dunlap >> Acked-by: Steven Rostedt (VMware) > > I'm actually working on a patch that I need to send to Linus before > 4.15 is released. Want me to add this one too? Or do you have your own > branch to push to mainline with? I don't have any branch to push. Please merge it whenever you think it's appropriate. Thanks. > -- Steve > >> --- >> kernel/trace/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- orig/kernel/trace/Kconfig >> +++ next/kernel/trace/Kconfig >> @@ -355,7 +355,7 @@ config PROFILE_ANNOTATED_BRANCHES >> on if you need to profile the system's use of these macros. >> >> config PROFILE_ALL_BRANCHES >> - bool "Profile all if conditionals" >> + bool "Profile all if conditionals" if !FORTIFY_SOURCE >> select TRACE_BRANCH_PROFILING >> help >> This tracer profiles all branch conditions. Every if () > -- ~Randy