From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDDFC433FE for ; Fri, 5 Nov 2021 10:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 403DC6126A for ; Fri, 5 Nov 2021 10:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233041AbhKEKNR (ORCPT ); Fri, 5 Nov 2021 06:13:17 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:37764 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232907AbhKEKNP (ORCPT ); Fri, 5 Nov 2021 06:13:15 -0400 Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id A26963F4A6 for ; Fri, 5 Nov 2021 10:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636107035; bh=z0tsoUmWOaxgRAp937Z0S11BvmYuYC7jjzjengboIcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o5Z1vjJgSACA4EGoej49Wsnt105zwONo0S4jNqAklTObPsnMYLPwG3oGVt9RJ7BnG F7qTQn2tIct+b+bZiIglAQVLaR912Qqlds+Vm2NN/7f6x3trZfznQr/fknLQgeQcZN H5Sz3/Td1/HoN1+/zzfrbpOqcDCrXuX4v1LyOWPSzQoLgKRVMFGxn1Wr8HrafvwFvT GYC4XLkOUM1WwPT9s54eGpEvxYRkFpQMdq7Lbwr8IBsJ7Ytv3IZxAkIuxuLagfBe38 Dd0+8agkK4/e/s92qIcVYzbYToRAYV8KW6e/goiC4naEZEibHaaTCizdCqyFE9d+Dl BgPjJ8FnaxmIw== Received: by mail-lf1-f72.google.com with SMTP id c13-20020a05651200cd00b004001aab328aso3375268lfp.1 for ; Fri, 05 Nov 2021 03:10:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=z0tsoUmWOaxgRAp937Z0S11BvmYuYC7jjzjengboIcg=; b=NunxoyGqHUsuodkot6iv04DsVqJGtpjGU0qPDnHXBuD2G23ttSg/VKa2o9FTiY1i5h OrQIesqWLn/tMCPyiaD4sktHsU2wvABDwmVVuh27Mfi0UDhkuyU6nnpxbYdvln+7Dsq5 bkdM8R1O3yG6vSixmMMD6JA8VTGxZGZsyox1DkhI4pXCgGHsPsart8QpHWYuaILPOCbj hCkLHucnl54h8YuaXFJiVSHVhnkVkjVozYUo1+pAJcZAfr5okcuYgdHOYPJsRll4SUTu CsI4Cc9I/9PLEYvGfvkLMdG5Jyp4RGi2lJd6mfmWe6hVS9AjoDll1hjCNcuYN2Q+Fpyq VKGQ== X-Gm-Message-State: AOAM5329bQcICVuBfJgwP8NXyBqi2BcFI0Nl1y94AcaEuTMjMwMaqPuV eekcdBqpgasTH3dxqUfW+yxntEMasMYwiFuq3P15jh6we5x6dbtObsW03Pd7Gjxkb5XQBe0fO/V q9Jfudc8xXoQhsFfLDzp0/zz4FksQkfG3pNkEow3wSA== X-Received: by 2002:a05:6512:926:: with SMTP id f6mr52661467lft.495.1636107035097; Fri, 05 Nov 2021 03:10:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8ms6IBqfGRrpRsf+ifN6GlLsj6sLALe5+yrME7rKButQoJ+/xoGsTps2A9xU47zf/OcwOvg== X-Received: by 2002:a05:6512:926:: with SMTP id f6mr52661450lft.495.1636107034918; Fri, 05 Nov 2021 03:10:34 -0700 (PDT) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id k7sm33785lfv.214.2021.11.05.03.10.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 03:10:34 -0700 (PDT) Message-ID: <45e75291-223d-829a-6772-07bde8943dcc@canonical.com> Date: Fri, 5 Nov 2021 11:10:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: nfc: pn533: suspected double free when pn533_fill_fragment_skbs() return value <= 0 Content-Language: en-US To: YE Chengfeng , "davem@davemloft.net" , "wengjianfeng@yulong.com" , "kuba@kernel.org" , "dan.carpenter@oracle.com" Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2021 10:22, YE Chengfeng wrote: > Hi, > > We notice that skb is already freed by dev_kfree_skb in pn533_fill_fragment_skbs, but follow error handler branch #line 2288 and #line 2356, skb is freed again, seems like a double free issue. Would you like to have a look at them? We will provide patch for them after confirmation. > > https://github.com/torvalds/linux/blob/master/drivers/nfc/pn533/pn533.c#L2288 Hi, Indeed it looks like double free. Please send a patch even without confirmation - code is better than just text report. Best regards, Krzysztof