From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap5.colo.codethink.co.uk (imap5.colo.codethink.co.uk [78.40.148.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E54433BB8 for ; Mon, 6 Jul 2026 16:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.40.148.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355907; cv=none; b=BrIjx+/cTe2J/KMX38Itdk0+jeGaoYvWz6FE4bplgQRBCXA1090zJxBihq2bEkv784gRCEO0cEfFnjwlYevW25mfazCwOXyHZYVoeg7xIjHfgARKjFoclrRvJ3Io634bw64LTyfVHGTkxUV2ERj016t5VEsHkE3wtdLA1Ow7zRI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783355907; c=relaxed/simple; bh=h4N4Hi0dWUmwndwNW+AdY27KpiUlv4+aO1/LUnG+LWk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CQWsWcSJ4Ul4pHqFXvy3Pb6v4UXauioS9WXaeZoUZVaR/saKjGsRc70pZnMM4wFI1EYDhhCsutj4O808PyQD/JUnCnonKVweU3+Cr5U4taFgMQf6G4yLZ6oTP1hqWN9Hr8a8TU+Vzoedx7s9PaUg+N0fZSmjI2yIQtysxSFisD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk; spf=pass smtp.mailfrom=codethink.co.uk; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b=zrOUeLN/; arc=none smtp.client-ip=78.40.148.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=codethink.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=codethink.co.uk header.i=@codethink.co.uk header.b="zrOUeLN/" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codethink.co.uk; s=imap5-20230908; h=Sender:Content-Transfer-Encoding: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Reply-To; bh=4QhyIdNvjJG9/SfQXiZAEqun0KFeZ25ciqpUlHFi75k=; b=zrOUeLN/+JKHjL+Z CXL0SE5V5/Tyw8Qo2imFlJrUqAcEGkb7zXekGpPX6w9EW/GCB9pbXdDrg2CPmrT1B1FSp2G2cvxcY IOBLw54rrAifVOcIH6WGsjG5wZT6H7+txZg6ubOmrv/wfk64iF1QbgnOtYL7JkXJzK1M1bn90HGSu CNc5LfAzDBIyLSsxUW8PiygtlV8ByPK8VjAHlHrCP/PFnmhomdGuxlj5nsb0FjD3kY34AOR3sOQ+h DEmZA4ssStXQMTBAdP/fmVEiIf43QsWVvPN38xH7VyYo/NX2x8GIgW4aJcvZ42wnh5viy5AJdugpy Fy7eHrIqv1rbcGSLYA==; Received: from [167.98.27.226] (helo=[10.35.6.194]) by imap5.colo.codethink.co.uk with esmtpsa (Exim 4.94.2 #2 (Debian)) id 1wgmKb-00Gg3Y-Ta; Mon, 06 Jul 2026 17:38:05 +0100 Message-ID: <45e86efe-28a6-491c-80c6-79b2dd947cf5@codethink.co.uk> Date: Mon, 6 Jul 2026 17:37:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/imagination: make pvr_fw_trace_init_mask_ops static To: Alessio Belle Cc: "tzimmermann@suse.de" , "simona@ffwll.ch" , "matt.coster@imgtec.com" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , Frank Binns , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "linux-kernel@vger.kernel.org" References: <20260703162338.2848039-1-ben.dooks@codethink.co.uk> <1c7c5867cfba89094d39e5178cc281c0cc9c87fa.camel@imgtec.com> Content-Language: en-GB From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <1c7c5867cfba89094d39e5178cc281c0cc9c87fa.camel@imgtec.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: ben.dooks@codethink.co.uk On 06/07/2026 17:31, Alessio Belle wrote: > Hi Ben, > > On Fri, 2026-07-03 at 17:23 +0100, Ben Dooks wrote: >> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c >> so make it static to avoid the following sparse warning: >> >> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static? >> >> Fixes: c6978643ea1c ("drm/imagination: Validate fw trace group_mask")? > > nit: the "?" at the end > >> Revied-by: Alessio Belle > > nit: Revied-by -> Reviewed-by > > I can fixup these manually after applying the patch, if you are fine with it, > unless you prefer to send a v3. > > Planning to apply this patch to drm-misc-fixes by the end of this week. Please go ahead and fixup the issues before applying. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html