From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9A7CC77B75 for ; Wed, 17 May 2023 02:44:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbjEQCou (ORCPT ); Tue, 16 May 2023 22:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232155AbjEQCos (ORCPT ); Tue, 16 May 2023 22:44:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78F5F1706 for ; Tue, 16 May 2023 19:44:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 13FAA63ECB for ; Wed, 17 May 2023 02:44:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C44ADC433EF; Wed, 17 May 2023 02:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684291486; bh=qNDtCoajT3pDCRQM68Y/i7MapdhfLICp5GbRlmJgsYo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cKrDFv3Fqj0jRSbVb5JVYzZZ6aQ2YaEDTDuh33Mx3eSy6p93EUDjLrIEryyNUJ4jq YpBZPK71rmQNCGaH5Y8aFgRhseEv4fypMy2NHLT0EWd2V61V5tOkNEqPEBMtbiMmur mVLGVziAfjLXNvcZ51S3R2KEV+rkYzvcipIojRDruDckZeDHl2OwJ0erUrT46GS/eC NsQbO2uAvy9NuSeI67uvwx61Ll8IRSEz+F5ATL9NlJZTuUYoYcVIOfLhSjX6NTn0Tx 5q9El8T4cyTf0Ig8fSsDJq7eJHEdGVw9fboKGsguIBcH7g8+1FqtQXOpm1vfIQe+l3 cDLHLLKomed3g== Message-ID: <45eb63c6-a147-776a-99b5-7ac06848ede8@kernel.org> Date: Wed, 17 May 2023 10:44:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/1] f2fs: pass I_NEW flag to trace event Content-Language: en-US To: Wu Bo , Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, wubo.oduw@gmail.com References: <20230516120747.68844-1-bo.wu@vivo.com> From: Chao Yu In-Reply-To: <20230516120747.68844-1-bo.wu@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/16 20:07, Wu Bo wrote: > Modify the order between 'trace_f2fs_iget' & 'unlock_new_inode', so the > I_NEW can pass to the trace event when the inode initialised. Why is it needed? And trace_f2fs_iget() won't print inode->i_state? Thanks, > > Signed-off-by: Wu Bo > --- > fs/f2fs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index cf4327ad106c..caf959289fe7 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -577,8 +577,8 @@ struct inode *f2fs_iget(struct super_block *sb, unsigned long ino) > file_dont_truncate(inode); > } > > - unlock_new_inode(inode); > trace_f2fs_iget(inode); > + unlock_new_inode(inode); > return inode; > > bad_inode: